On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote:
>
> Add a .editorconfig file which editors can use for basic formatting
> details of files, such as tabs/spaces, line endings etc.
>
> Signed-off-by: Rebecca Cran
Thank you very much for this - this is very useful.
Acked-by:
On Thu, 23 Feb 2023 at 06:53, Yuanhao Xie wrote:
>
> Hi,
>
> Set "Address= BASE_4GB - 1" first is to ensure the maximum address value
> is 4GB, since APs will be switched to 32 bit before OS, I mean in the
> original implementation.
> By the way, in patch 5, only SEV-ES processor keep this l
On Tue, 21 Feb 2023 at 14:58, Gao, Zhichao wrote:
>
> Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create
> the PR after edk2 202302 release.
>
The hard freeze has been deferred until early march, so you can go
ahead and merge this patch.
--
Ard.
> > -Original Mes
On Tue, 21 Feb 2023 at 02:09, Rebecca Cran wrote:
>
> Improve the readability of the SbsaQemu SPCR and DSDT.
>
> Rebecca Cran (2):
> Silicon/Qemu: Convert DSDT ASL from legacy to ASL 2.0 syntax
> Silicon/Qemu: Use the symbolic value for the SPCR table revision.
>
Review
t.
>
> Changes in v2:
>
> Dropped the patch to set PcdTimerPeriod.
>
> Rebecca Cran (2):
> Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome
> driver
> Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from
> CNTFRQ_EL0
>
Hi Rebecca,
Thanks for the effort to fix this.
On Tue, 21 Feb 2023 at 02:03, Rebecca Cran wrote:
>
> The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate
> how many ticks to wait in MicroSecondDelay. Given that the timer clock
> on Juno runs at 50 MHz, it ticks every 20 ns;
in
> FatPkg/EnhancedFatDxe. By doing so, we move collation initialization
> to BDS, where the module responsible for protocol installation should
> have already been loaded and ran.
>
> [1]: https://edk2.groups.io/g/devel/message/100312
>
> Cc: Ard Biesheuvel
> Cc: Marvin Häuser
On Fri, 17 Feb 2023 at 18:31, Pedro Falcato wrote:
>
> On Fri, Feb 17, 2023 at 3:38 PM Marvin Häuser wrote:
> >
> >
> > > On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote:
> > >
> > > So the FAT driver will happily load, but then fail in an obscure
&g
On Fri, 17 Feb 2023 at 15:55, Marvin Häuser wrote:
>
>
> > On 17. Feb 2023, at 15:29, Ard Biesheuvel wrote:
> >
> > On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote:
> >>
> >> Hi Ard,
> >>
> >> Thank you! Is "1/4" a mist
On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote:
>
> Hi Ard,
>
> Thank you! Is "1/4" a mistake or did I miss the other 3? :)
Oops.
It was part of some RPi4 patches but I decided to send it out by itself.
> Comments inline.
>
> On 17. Feb 2023, at 12:12,
: Pedro Falcato
Cc: Marvin Häuser
Signed-off-by: Ard Biesheuvel
---
This fixes an observed failure when attempting to use this driver
Raspberry Pi4 as a builtin.
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Features/Ext4Pkg
On Wed, 15 Feb 2023 at 11:53, Leif Lindholm wrote:
>
> On Mon, Feb 13, 2023 at 12:13:37 +0100, Ard Biesheuvel wrote:
> > A pair of cleanups regarding the use of code that I will propose to
> > remove from the core EDK2 in an upcoming series.
> >
> > Cc: Leif Lindholm
On Wed, 15 Feb 2023 at 00:07, Dionna Glaze wrote:
>
> This event should only trigger once. It should be idempotent, but the
> allocation of the memory map itself is observable and can cause
> ExitBootServices to fail with a modified map key.
>
> Cc: Ard Biesheuvel
> Cc:
On Tue, 14 Feb 2023 at 23:35, Ard Biesheuvel wrote:
>
> On Tue, 14 Feb 2023 at 23:15, Pankaj Gupta wrote:
> >
> > System Memory map is changed when a memory range is Accepted.
> > While returning from AcceptAllMemory(), "gBS->FreePool" is wrongly
> > us
On Thu, 2 Feb 2023 at 21:42, Dionna Amalie Glaze wrote:
>
> > >
> > > This change is made given a request from Ard. The CC capability is not
> > > applied to other system memory ranges that probably should also have
> > > that capability, given that it's encrypted and accepted. I haven't
> > > con
On Tue, 14 Feb 2023 at 23:15, Pankaj Gupta wrote:
>
> System Memory map is changed when a memory range is Accepted.
> While returning from AcceptAllMemory(), "gBS->FreePool" is wrongly
> used which results in changing memory map and hence return an error.
> Fix this by removing the "gBs->FreePool"
On Mon, 13 Feb 2023 at 23:23, Marvin Häuser wrote:
>
>
> On 13. Feb 2023, at 22:59, Ard Biesheuvel wrote:
>
> No, the only reason for adding -fpie here is to ensure that statically
> initialized CONST pointers are emitted into .data.rel.ro and not into
> .rodata, as this is
On Mon, 13 Feb 2023 at 22:32, Marvin Häuser wrote:
>
> Without wanting to blow up your RFC with another one - I discussed this with
> various people, including Bret when he was still at Project Mu, and there was
> a consensus among them that integrating the whole CPU arch code right into
> DxeC
On Mon, 13 Feb 2023 at 22:16, Marvin Häuser wrote:
>
> Hey Ard,
>
> *Praise* to you for this series. Comments inline.
>
Thanks :-)
> On Mon, Feb 13, 2023 at 07:19 AM, Ard Biesheuvel wrote:
>
> Enable the WXN system control bit straight out of reset when running in
>
invocation of SetVirtualAddressMap()) could result in code mappings
losing their executable permissions.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirt.dsc.inc| 1 +
ArmVirtPkg/Library/ArmPlatformLibQemu/AArch64/ArmPlatformHelper.S | 2 +-
2 files changed
the same page to lose
its executable permissions.
Let's avoid this, by moving all quantities that are subject to
relocation fixups to a separate page if the build is using 64k section
alignment, which is only the case when building a runtime driver for
AArch64.
Signed-off-by: Ard Biesh
Map the code flash with read-only attributes so we can execute from it
even under a memory protection regime that enables WXN, making all
writable memory regions non-executable by default.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
1
unmap the code that is performing the split.
However, the BASE variety of ArmMmuLib discovers the HOB and sets a
global pointer to refer to it, which is not possible in PEIMs, and so
all PEIMs must use the PEI variety of this library if one does.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg
DXE core,
as otherwise, it will not be able to dispatch the CPU arch protocol DXE
driver (or any other DXE driver for that matter), as it would lack the
ability to grant executable permissions to those executables.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemu.dsc
dispatch of the
DXE driver that implements the CPU arch protocol, removing the need to
rely on memory mappings that are writable and executable at the same
time.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmSetMemoryOverrideLib/ArmSetMemoryOverrideLib.c | 56
ArmPkg
the DXE core to enforce strict memory permissions
even before dispatching the CPU arch protocol driver itself.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe
- 0x4410 - 0x1000
(0x0008)
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
b/MdeModulePkg/Core
manage the executable permissions on
other DXE and UEFI drivers and applications that it dispatches.
Note that this requires that the DXE IPL executes non-shadowed from a FV
that is mapped executable.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 69
strictly redundant (as the IPL PEIM will
be shadowed anyway, even if RegisterForShadow() is not called), let's
test it anyway to avoid modifying the behavior on existing platforms.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 5 +++-
MdeModulePkg/Core/DxeIp
Add a library call to obtain the start and end of the region covered by
relocation fixups. This will be used in a future patch to limit the
range of memory that needs to be remapped with read-write-execute
permissions at ExitBootServices() time.
Signed-off-by: Ard Biesheuvel
---
MdePkg/Include
implicitly read-only due to the ROM nature, they need to be
mapped with read-only attributes in the page tables to be able to
execute from them.
Also add the XP counterpart which will be used for all normal DRAM right
at the outset.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Include/Library
e ARM memory region types that mark memory as 'non-secure'
explicitly.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Include/Chipset/ArmV7Mmu.h| 51 +++-
ArmPkg/Include/Library/ArmLib.h | 11 -
ArmPkg/Library/ArmMmuLib/AArch64/ArmMm
On Mon, 13 Feb 2023 at 12:39, Gerd Hoffmann wrote:
>
> On Fri, Feb 10, 2023 at 02:46:34PM +0100, Ard Biesheuvel wrote:
> > On Fri, 10 Feb 2023 at 14:42, Ard Biesheuvel wrote:
> > >
> > > > Can LTO be enabled for the NOOPT build? Or depends that on
>
er to drop
this code so we can remove it from the EDK2 main repo as well.
Signed-off-by: Ard Biesheuvel
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
| 6 +--
Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib
dropped.
Signed-off-by: Ard Biesheuvel
---
Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c
b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib
A pair of cleanups regarding the use of code that I will propose to
remove from the core EDK2 in an upcoming series.
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Rebecca Cran
Ard Biesheuvel (2):
Platform/BeagleBoard: Drop PeCoff protocol
Silicon/Marvell: Drop use of NONSECURE ARM memory region
On Sat, 11 Feb 2023 at 01:56, Taylor Beebe wrote:
>
> Hey Ard,
>
> Once the Memory Attribute Protocol is made available, Windows will have
> some expectations about its functionality. Can you run this test app
> created by me and Jiewen to ensure it meets the Windows requirements?
> Part of the te
Acked-by: Ard Biesheuvel
I can go and merge this if desired: what is the situation wrt the stable tag?
On Fri, 10 Feb 2023 at 14:21, Yao, Jiewen wrote:
>
> OvmfPkg: Acked-by: Jiewen Yao
>
> > -Original Message-
> > From: Sunil V L
> > Sent: Friday, Febru
On Fri, 10 Feb 2023 at 14:42, Ard Biesheuvel wrote:
>
> On Fri, 10 Feb 2023 at 09:42, Gerd Hoffmann wrote:
> >
> > On Thu, Feb 09, 2023 at 05:46:15PM +0100, Ard Biesheuvel wrote:
> > > On Thu, 9 Feb 2023 at 11:27, Gerd Hoffmann wrote:
> > > >
> > &g
On Fri, 10 Feb 2023 at 09:42, Gerd Hoffmann wrote:
>
> On Thu, Feb 09, 2023 at 05:46:15PM +0100, Ard Biesheuvel wrote:
> > On Thu, 9 Feb 2023 at 11:27, Gerd Hoffmann wrote:
> > >
> > > Known problem: the NOOPT builds fail due to PEI becoming too big.
> >
On Fri, 10 Feb 2023 at 02:21, Rebecca Cran wrote:
>
> Mike,
>
> Yes, it passed CI - see https://github.com/tianocore/edk2/pull/4022 .
>
> I wasn't sure if we cared about EBC builds these days. Given the link on
> https://www.intel.com/content/www/us/en/architecture-and-technology/unified-extensibl
On Fri, 10 Feb 2023 at 09:00, Gupta, Pankaj wrote:
>
>
> >>> With this patch I observe an issue where my Linux (6.2.0-rc7) guest
> >>> recur to Bootloader menu again. I am testing this with SEV SNP (w/o
> >>> UPM). Also, guest don't have lazy memory acceptance support.
> >>>
> >>
> >> Thanks for t
On Mon, 30 Jan 2023 at 17:29, Girish Mahadevan wrote:
>
> Currently the standalonemmlibinternal assumes the max physical bits
> to be 36 which is causing issues on v8 architectures.
> Instead use the MAX_ALLOC_ADDRESS macro to determine the maximum
> allowed address rather than recomputing it loca
On Thu, 9 Feb 2023 at 14:22, Gerd Hoffmann wrote:
>
> On Wed, Feb 08, 2023 at 11:01:38AM -0700, Rebecca Cran wrote:
> > Allow users to build OVMF then run QEMU by moving the build block above
> > the run block and removing the exit line.
> >
> > Signed-off-by: Rebecc
On Tue, 7 Feb 2023 at 10:07, wrote:
>
> From: Pierre Gondois
>
> The UEFI Shell is a non-active boot option, at the opposite of UiApp.
> If no valid boot option is found, UiApp is selected. UiApp requires a
> human interaction. When installing a new EDKII image in CIs or when
> scripting is requi
On Thu, 9 Feb 2023 at 11:27, Gerd Hoffmann wrote:
>
> Known problem: the NOOPT builds fail due to PEI becoming too big.
>
> What is the reason for doing these NOOPT builds?
They are very useful for doing single step debugging with GDB. On ARM,
I use the NOOPT builds fairly regularly.
> I'm not
On Wed, 8 Feb 2023 at 11:53, Gerd Hoffmann wrote:
>
> On Tue, Feb 07, 2023 at 09:49:37PM +0800, Yuanhao Xie wrote:
> > Add CpuPageTableLib required by MpInitLib in OvmfPkg.
> >
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Ger
On Tue, 7 Feb 2023 at 13:58, Oliver Steffen wrote:
>
> On Tue, Feb 7, 2023 at 12:57 PM Ard Biesheuvel wrote:
>>
>> On Tue, 7 Feb 2023 at 11:51, Oliver Steffen wrote:
>> >
>> > On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen wrote:
>> >>
>>
Expose the protocol introduced in v2.10 that permits the caller to
manage mapping permissions in the page tables.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 +
ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2
Add the Memory Attribute Protocol definition, which was adopted and
included in version 2.10 of the UEFI specification.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519
Signed-off-by: Ard Biesheuvel
Reviewed-by: Liming Gao
---
MdePkg/Include/Protocol/MemoryAttribute.h | 142
In preparation for introducing an implementation of the EFI memory
attributes protocol that is shared between ARM and AArch64, unify the
existing code that converts a page table descriptor into a
EFI_MEMORY_xxx bitfield, so it can be called from the generic code.
Signed-off-by: Ard Biesheuvel
rrect attributes.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 10 ++
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 11 +++
2 files changed, 21 insertions(+)
diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
b/ArmPkg/Library/ArmM
Enable the stack guard in ArmVirtPkg builds, so that stack overflows are
caught as they occur, rather than when they happen to hit a read-only
memory region.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirt.dsc.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ArmVirtPkg
without read permissions.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 8 ++-
ArmPkg/Include/Library/ArmMmuLib.h | 34
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 58 +++-
ArmPkg/Library/ArmMmuLib/Arm
other attributes when
clearing RO or XP.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 94 +---
1 file changed, 81 insertions(+), 13 deletions(-)
diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
b/ArmPkg/Library/ArmMmuLi
: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 47 ++--
ArmPkg/Include/Chipset/ArmV7Mmu.h | 40 +++--
ArmPkg/Library/ArmLib/Arm/ArmV7Support.S| 2 +
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c | 1 +
ArmPkg/Library
.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 3 +++
ArmPkg/Include/Chipset/ArmV7Mmu.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
index ea856f5cdd26..8eb1f71395f5 100644
--- a/ArmPkg/Drivers/CpuDxe
beneficial for maintainability.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Include/Chipset/ArmV7Mmu.h | 8 +++-
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 12 ++--
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/ArmPkg/Include/Chipset/ArmV7Mmu.h
b
large), let's just rip it out.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 8 ++---
ArmPkg/Include/Chipset/ArmV7Mmu.h | 38 ++--
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c | 7 ++--
ArmPkg/Library/ArmMmuLi
iming Gao
Cc: Jiewen Yao
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Taylor Beebe
Ard Biesheuvel (11):
ArmPkg/ArmMmuLib ARM: Remove half baked large page support
ArmPkg/ArmMmuLib ARM: Split off XN page descriptor bit from type field
A
On Thu, 9 Feb 2023 at 00:10, Marcin Juszkiewicz via groups.io
wrote:
>
> From: Marcin Juszkiewicz
>
> Update the TF-A binaries with SVE/SME enablement.
>
> This support was merged into TF-A:
>
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/17825
>
> This allows to test SBSA Refe
On Wed, 8 Feb 2023 at 19:57, Taylor Beebe wrote:
>
>
>
> On 2/8/2023 10:49 AM, Ard Biesheuvel wrote:
> > On Wed, 8 Feb 2023 at 19:32, Marvin Häuser wrote:
> >>
> >> Thanks!! :) Comments inline.
> >>
> >>> On 8. Feb 2023, at 18:58, Ard Bies
being updated?
>
Yes, that was what I had in my initial prototype.
However, I'm not sure how walking the page tables to retrieve all
existing attributes is fundamentally different from walking the page
tables to set them, given that everything is cached and we are running
uniprocessor at
On Wed, 8 Feb 2023 at 19:32, Marvin Häuser wrote:
>
> Thanks!! :) Comments inline.
>
> > On 8. Feb 2023, at 18:58, Ard Biesheuvel wrote:
> >
> > The DXE core implementation of PcdDxeNxMemoryProtectionPolicy already
> > contains an assertion that EfiConventio
On Wed, 8 Feb 2023 at 18:58, Ard Biesheuvel wrote:
>
> Instead of relying on a questionable heuristic that avoids calling into
> the SetMemoryAttributes () DXE service when the old memory type and the
> new one are subjected to the same NX memory protection policy, make
potential recursion
due to NX policies being applied to newly allocated page tables.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 29
1 file changed, 29 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
b
o the DXE core and other drivers. This ensures that
creating EfiBootServicesData allocations does not result in memory
attribute changes, and therefore no recursion.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 77
ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 2
://bugzilla.tianocore.org/show_bug.cgi?id=3316
Cc: Michael Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Taylor Beebe
Cc: Marvin Häuser
Ard Biesheuvel (3):
ArmPkg/ArmMmuLib: Avoid splitting block entries if possible
rrect attributes.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
index 1cf8dc090012..28191938aeb1 1
On Tue, 7 Feb 2023 at 11:13, Marvin Häuser wrote:
>
>
> On 7. Feb 2023, at 11:01, Ard Biesheuvel wrote:
>
> Actually, it seems UnprotectUefiImage () is corrent under the
> assumption that all code regions have EFI_MEMORY_XP cleared by
> default.
>
> However, if you
On Tue, 7 Feb 2023 at 11:51, Oliver Steffen wrote:
>
> On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen wrote:
>>
>>
>> On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote:
>>>
>>> On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote:
>>> >
On Tue, 7 Feb 2023 at 10:16, Ard Biesheuvel wrote:
>
> On Tue, 7 Feb 2023 at 09:56, Marvin Häuser wrote:
> >
> > Hi Taylor and Ard,
> >
> > > On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote:
> > >
> > > On Tue, 7 Feb 2023 at 02:18, Taylor Beebe
On Tue, 7 Feb 2023 at 09:56, Marvin Häuser wrote:
>
> Hi Taylor and Ard,
>
> > On 7. Feb 2023, at 09:29, Ard Biesheuvel wrote:
> >
> > On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote:
> >>
> >> I can't see the Bugzilla you referenced so I
On Tue, 7 Feb 2023 at 02:18, Taylor Beebe wrote:
>
> I can't see the Bugzilla you referenced so I requested security Bugzilla
> access. But, yes, that's the bug to which I was referring :)
>
I cannot see that bugzilla entry either.
> Once Ard's change to add Memory Attribute Protocol support to
latively rare) are usually in
> some other component executed after the agent is acquired which I suspect was
> the case here.
>
Thanks,
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, February 6, 2023 5:04 PM
> To: devel@edk2.groups.io; mikub...@lin
NOT FOR MERGE
Add some DEBUG code to double check that the memory attributes have been
modified as expected by the code that manages read-only and/or non-exec
permissions for page allocations and loaded images.
---
MdeModulePkg/Core/Dxe/DxeMain.inf | 1 +
MdeModulePkg/Core/Dxe/Misc/M
In preparation for introducing an implementation of the EFI memory
attributes protocol that is shared between ARM and AArch64, unify the
existing code that converts a page table descriptor into a
EFI_MEMORY_xxx bitfield, so it can be called from the generic code.
Signed-off-by: Ard Biesheuvel
Expose the protocol introduced in v2.10 that permits the caller to
manage mapping permissions in the page tables.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 +
ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2
.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 3 +++
ArmPkg/Include/Chipset/ArmV7Mmu.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
index 2daf47ba6fe5..e7acd84b8af9 100644
--- a/ArmPkg/Drivers/CpuDxe
Add the Memory Attribute Protocol definition, which was adopted and
included in version 2.10 of the UEFI specification.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519
Signed-off-by: Ard Biesheuvel
Reviewed-by: Liming Gao
---
MdePkg/Include/Protocol/MemoryAttribute.h | 142
o
Cc: Jiewen Yao
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Taylor Beebe
Ard Biesheuvel (5):
MdePkg: Add Memory Attribute Protocol definition
ArmPkg/CpuDxe ARM: Fix page-to-section attribute conversion
ArmPkg/CpuDxe: Expose unified regi
On Sat, 4 Feb 2023 at 02:26, Michael Kubacki
wrote:
>
> Hi Ard,
>
> I'm not an admin on the tianocore Azure DevOps organization so I cannot
> view or do much more than you can.
>
> It appears to me to be a transient issue during provisioning on the
> particular agent. Normally, I'd use a "rerun fa
On Fri, 3 Feb 2023 at 15:53, Sami Mujawar wrote:
>
> Hi Sudeep,
>
> Thank you for the updated patch.
>
> Reviewed-by: Sami Mujawar
> Tested-by: Sami Mujawar
>
Merged as #4006
Thanks all,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (
On Fri, 3 Feb 2023 at 17:28, Gerd Hoffmann wrote:
>
> Hi,
>
> > > Unfortunately it is not a clear size win everywhere.
> > >
> > > PEI jumps up in size even though I'm using the min_pei config for
> > > CryptoPei, seems it *still* has way too much bits compiled in
> > > (didn't look into tweakin
On Sat, 4 Feb 2023 at 02:13, Marvin Häuser wrote:
>
> Hi Ard,
>
> While I agree the tone is a bit irritating, I am not sure what kind of
> context you expect there to be. The library is nearing EOL and usage beyond
> EOL is unacceptable. It will take significant time to solve the related
> issu
On Sat, 4 Feb 2023 at 02:08, Pedro Falcato wrote:
>
> On Fri, Feb 3, 2023 at 11:25 PM Ard Biesheuvel wrote:
> >
> > On Fri, 3 Feb 2023 at 20:45, Pedro Falcato wrote:
> > >
> > > On Fri, Feb 3, 2023 at 4:28 PM Gerd Hoffmann wrote:
> > > >
>
On Fri, 3 Feb 2023 at 20:45, Pedro Falcato wrote:
>
> On Fri, Feb 3, 2023 at 4:28 PM Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > > Unfortunately it is not a clear size win everywhere.
> > > >
> > > > PEI jumps up in size even though I'm using the min_pei config for
> > > > CryptoPei, seems it *s
On Fri, 3 Feb 2023 at 16:37, Gerd Hoffmann wrote:
>
> On Fri, Feb 03, 2023 at 02:33:07PM +0100, Ard Biesheuvel wrote:
> > What is the point of this series? If we are trying to deduplicate
> > crypto code by moving it into a dedicated driver, can we please just
> > do that
On Fri, 3 Feb 2023 at 14:28, Gerd Hoffmann wrote:
>
What is the point of this series? If we are trying to deduplicate
crypto code by moving it into a dedicated driver, can we please just
do that unconditionally, instead of doubling the size of the
validation matrix again? Or are there reasons why
On Fri, 3 Feb 2023 at 13:33, Michael Brown wrote:
>
> On 03/02/2023 12:10, Ard Biesheuvel wrote:
> > +[BuildOptions]
> > +!if $(RUNTIME_BTI_ENABLE) == TRUE
> > + GCC:*_*_AARCH64_CC_FLAGS = -mbranch-protection=bti
> > +!endif
>
> Question: as a producer of
gi?id=4076
> >
> > This module is required by other architectures like RISC-V.
> > Hence, move this to OvmfPkg.
> >
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd Hoffmann
> > Signe
On Fri, 3 Feb 2023 at 12:20, Sudeep Holla wrote:
>
> On Fri, Feb 03, 2023 at 12:10:38PM +0100, Pierre Gondois wrote:
> > Hello Sudeep,
> >
> > On 2/2/23 15:30, Sudeep Holla wrote:
> > > As per the SCMI specification, section CLOCK_DESCRIBE_RATES mentions that
> > > the value of num_rates_flags[11:
On Thu, 2 Feb 2023 at 12:28, Sudeep Holla wrote:
>
> On Thu, Feb 02, 2023 at 11:21:38AM +, Sami Mujawar wrote:
> > The NOR Flash driver was recently moved from the Tianocore\edk2 repository
> > to the Tianocore\edk2-platforms repository at the following location:
> > Platform\ARM\Drivers\NorFl
the command line option to all types.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirt.dsc.inc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 74d98e6314c4..9cb37f3d46a3 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b
it implements support for forward edge
control flow enforcement such as IBT or BTI.
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/AArch64/PeCoffLoaderEx.c | 103
MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf| 5 +-
2 files changed, 107 insertions
expected manner, so set the new flag if all loaded
runtime images were constructed with forward edge control flow guards.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/DxeMain.h| 2 ++
MdeModulePkg/Core/Dxe/Image/Image.c| 9 +
MdeModulePkg/Core
The specialized relocation fixup handlers are used by ARM and RISC-V but
not by IPF/Itanium anymore, so let's clean up the comments referring to
Itanium. No code changes.
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +-
MdePkg/Li
Add an internal helper that detects whether or not a loaded PE/COFF
image was built with support for forward edge control flow guards.
The default implementation will return FALSE, architectures can
specialize this based on arch specific criteria.
Signed-off-by: Ard Biesheuvel
---
MdePkg
Generic headers should only contain arch specific definitions if really
needed, which is not the case for the RISC-V based opcode immediate
parsing constants, so move them out of BasePeCoffLibInternals.h.
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h
UEFI v2.10 introduces a new flag to the memory attributes table to
inform the OS whether or not runtime services code regions were emitted
by the compiler with guard instructions for forward edge control flow
integrity enforcement.
So update our definition accordingly.
Signed-off-by: Ard
901 - 1000 of 3152 matches
Mail list logo
