Re: [edk2-devel] Question Using edk2-UDK2018 and VS2017

2021-08-24 Thread Carsey, Jaben
Adding the new maintainers. From: 김서진 Sent: Sunday, August 22, 2021 10:52 PM To: edk2-li...@mc2research.org; Carsey, Jaben Cc: canoni...@naver.com Subject: Question Using edk2-UDK2018 and VS2017 Dear Daryl McDaniel and Jaben Carsey, This is Seojin Kim from South Korea. Currently, I am

Re: [edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*

2021-08-17 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey -Original Message- From: Kinney, Michael D Sent: Tuesday, August 17, 2021 8:17 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Daryl McDaniel ; Carsey, Jaben Subject: [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib* Cc: Rebecca

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/2] EdkRepo: Add support for subst drives

2020-09-01 Thread Carsey, Jaben
Instead of looping over the dictionary, could we convert the target drive and see if it's in the dictionary? I am thinking like remove the : from os.path.splitdrive(workspace_dir)[0].upper() string and see if that's in the dictionary? > -Original Message- > From: devel@edk2.groups.io

Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob > Feng > Sent: Tuesday, August 11, 2020 11:09 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Chen, Christine > > Subject: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into > AutoGenW

Re: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver

2020-04-24 Thread Carsey, Jaben
oups.io > Cc: Nikita Leshenko ; > liran.a...@oracle.com; aaron.yo...@oracle.com; Justen, Jordan L > ; Laszlo Ersek ; Ard > Biesheuvel ; Carsey, Jaben > > Subject: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name > of driver > > Install Component Name protocols

Re: [edk2-devel] Shell feature?

2020-02-11 Thread Carsey, Jaben
command for a user to view/edit the file associations? Do associations need to maintain over a reboot? -Jaben > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrew > Fish via Groups.Io > Sent: Tuesday, February 11, 2020 6:08 PM > To: Carsey, Jaben &

Re: [edk2-devel] Shell feature?

2020-02-11 Thread Carsey, Jaben
Andrew You can already add a command via a driver (including a driver's library). Check into the Dynamic Commands in the shell spec. Associating a file type with a command, basically if the first thing on the command line is a file of that type, then prepend the command and re-process the line

Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

2019-10-08 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Abner Chang [mailto:abner.ch...@hpe.com] > Sent: Tuesday, October 08, 2019 1:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; Leif > Li

Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug

2019-09-26 Thread Carsey, Jaben
Shell instances that currently developed applications need to maintain support for? Thanks -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, September 26, 2019 5:47 AM > To: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Cc: ed

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, September 23, 2019 3:01 AM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Sub

[edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

2019-08-21 Thread Carsey, Jaben
removing myself from maintainer promoting Zhichao Cc: Ray Ni Cc: Zhichao Gao Cc: Mike Kinney Signed-off-by: Jaben Carsey --- Maintainers.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 919baccc56..1dcc6c64ed 100644 --- a/Mai

Re: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough

2019-08-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Augustine, Linson > Sent: Wednesday, August 14, 2019 1:41 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > oleks...@ami.com > Subject: RE: [edk2-devel]

Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"

2019-08-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, August 13, 2019 8:37 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Rem

[edk2-devel] [Patch v1] ShellPkg: update drivers command for more children

2019-08-13 Thread Carsey, Jaben
this allows for > 99 children Cc: ray ni Cc: linson augustine Cc: zhichao gao Signed-off-by: Jaben Carsey --- ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c

Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues

2019-08-12 Thread Carsey, Jaben
Thanks. I had not checked each of the patches in the set, only the one CC'd to me and this one. Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 5:53 PM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao

Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues

2019-08-12 Thread Carsey, Jaben
What changed in v2? Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Sunday, August 11, 2019 11:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Carsey, Jaben ; Ni, Ray > ; Gao, Zhichao ; Chiu, Chasel > ; Desimone, Na

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked

2019-08-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 11, 2019 5:36 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse > should be ch

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

2019-08-08 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Thursday, August 08, 2019 1:59 AM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAc

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked

2019-08-08 Thread Carsey, Jaben
: Wednesday, August 07, 2019 5:54 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer > Resonse should be checked > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2049 > > ShellPkg\Li

Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview

2019-08-05 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Sami Mujawar > Sent: Monday, August 05, 2019 3:48 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Carsey, Jaben ; Ni, Ra

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-08-02 Thread Carsey, Jaben
@edk2.groups.io > Cc: tim.le...@insyde.com; Carsey, Jaben ; Gao, > Zhichao ; Ni, Ray ; Bi, Dandan > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > > It's been three months now since I contributed the patch. Could

Re: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated

2019-08-02 Thread Carsey, Jaben
s.io; Kinney, Michael D > Cc: Carsey, Jaben ; Ni, Ray ; > Sami Mujawar > Subject: RE: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all > commands integrated > > I used to use the shellpkg.dsc to build a shell.efi binary release. > Full configuration of shell is fine. But

Re: [edk2-devel] [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview

2019-08-01 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Kinney, Michael D > Sent: Thursday, August 01, 2019 1:56 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami Mujawar > > Subject: [Patch v2 0/2] ShellPkg: F

Re: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error

2019-08-01 Thread Carsey, Jaben
, 2019 1:30 PM > To: Sami Mujawar ; devel@edk2.groups.io; > Kinney, Michael D > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: RE: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error > > Hi Sami, > > I agree with your feedback. I saw that there was a

Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

2019-08-01 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Thursday, August 01, 2019 6:24 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > > Subject: [edk2-devel] [Patch] BaseToo

Re: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring

2019-07-18 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Thursday, July 18, 2019 5:32 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ;

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

2019-07-18 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matt

Re: [edk2-devel] [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)

2019-07-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 16, 2019 2:12 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Andrew Fish > Subject: [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar

Re: [edk2-devel] [PATCH] ShellPkg/Type.c: Add value check before (LoopVar - 1)

2019-07-15 Thread Carsey, Jaben
Please remove the typo (there is an extra S after 'return'). This line: // return Swith line feed for displaying each new line from left. > -Original Message- > From: Gao, Zhichao > Sent: Monday, July 15, 2019 12:30 AM > To: devel@edk2.groups.io > Cc: Carsey, J

Re: [edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers before use

2019-07-12 Thread Carsey, Jaben
, 2019 11:53 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com > Subject: [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers > before use > > 1. Check if the global point

Re: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error

2019-07-10 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, July 10, 2019 3:35 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [Patch] ShellPkg/AcpiView: Fix IA32 link error > Imp

Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

2019-06-24 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Much clearer code to see what's actually happening. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Sunday, June 23, 2019 6:51 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/2] Base

Re: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

2019-06-12 Thread Carsey, Jaben
: Wednesday, June 12, 2019 7:11 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Kinney, Michael D > ; Gao, Liming ; > sami.muja...@arm.com; matteo.carl...@arm.com; Stephanie.Hughes- > f...@arm.com; n...@arm.com > Subject: [edk2-devel] [PATCH v1 2/2]

Re: [edk2-devel] [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func DisplaySysEventLogData

2019-06-12 Thread Carsey, Jaben
Pushed. > -Original Message- > From: Bi, Dandan > Sent: Monday, June 10, 2019 5:52 PM > To: devel@edk2.groups.io; oleks...@ami.com; Ni, Ray ; > Carsey, Jaben > Cc: Gao, Zhichao > Subject: RE: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func > DisplaySysE

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

2019-06-10 Thread Carsey, Jaben
Pushed as sufficient RB's were received. > -Original Message- > From: Gao, Zhichao > Sent: Sunday, June 09, 2019 8:09 PM > To: PierreGondois ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > sami.muja...@arm.com; matteo.carl...@arm.com; Stephanie.Hu

Re: [edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

2019-05-20 Thread Carsey, Jaben
Netlib class definition and instance are both moving? Are these modules using MdeModulePkg for a different lib or can we remove it? > -Original Message- > From: Gao, Liming > Sent: Monday, May 20, 2019 6:09 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ;

Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review

2019-05-16 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 16, 2019 6:06 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Liming > Subject: [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg rev

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Carsey, Jaben
Inline. tldr: good answers. If change list to set in name of set object: Reviewed-by: jaben carsey > -Original Message- > From: Rodriguez, Christian > Sent: Friday, May 10, 2019 8:28 AM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming &g

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

2019-05-10 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Code change looks good visually. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Heinrich Schuchardt > Sent: Thursday, May 09, 2019 8:24 PM > To: Gao, Zhichao > Cc: devel @ edk2 . groups .

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-09 Thread Carsey, Jaben
Some questions inline. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Christian Rodriguez > Sent: Thursday, May 09, 2019 2:27 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Zhu, Yonghong > Subject: [edk2-devel] [PATCH] Bas

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Carsey, Jaben
t; To: devel@edk2.groups.io; tim.le...@insyde.com; Carsey, Jaben > ; Gao, Zhichao ; Ni, Ray > > Cc: Bi, Dandan > Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: > Fix '-opt' option > Importance: High > > No apologies necessary! Rais

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Carsey, Jaben
isting shell > scripts. In order to maintain that compatibility, it may be necessary to add > a new option rather than trying to update an existing one. > > Tim > > -----Original Message- > From: devel@edk2.groups.io On Behalf Of Carsey, > Jaben > Sent: Tuesday, M

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Carsey, Jaben
Zhichao, I can help submit errata for shell spec if needed. Per patch, I agree. This looks good. Reviewed-by: Jaben Carsey > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, May 07, 2019 2:52 AM > To: devel@edk2.groups.io; Ni, Ray ; jw...@jwatt.org > Cc: Car

Re: [edk2-devel] Error building Python

2019-04-30 Thread Carsey, Jaben
before. Maybe Daryl has a better starting point. -Jaben > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, April 29, 2019 9:54 AM > To: devel@edk2.groups.io; phlamo...@riseup.net > Cc: Daryl McDaniel ; Carsey, Jaben > > Sub

Re: [edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

2019-04-25 Thread Carsey, Jaben
The 3 new commits look good. Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 25, 2019 5:56 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Carsey, Jaben ; Daryl McDaniel (edk2- > li...@mc2research.org) ; > lei

Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

2019-04-22 Thread Carsey, Jaben
Assuming Laszlo's comment is addressed. Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 17, 2019 6:12 PM > To: Laszlo Ersek ; Ard Biesheuvel > > Cc: edk2-devel-groups-io ; Carsey, Jaben > ; Ni, Ray ; Leif Lindholm >

Re: [edk2-devel] [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

2019-04-20 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Friday, April 19, 2019 5:17 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInter

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-07 Thread Carsey, Jaben
The packages I am maintainer of look good to me. Reviewed-by: Jaben Carsey > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Wednesday, April 03, 2019 4:42 PM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: [