Re: [edk2-devel] [PATCH v2] CryptoPkg/Readme.md: typo and grammar fixes

2022-11-04 Thread Christopher Zurcher
Reviewed-by: Christopher Zurcher > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Friday, November 4, 2022 08:29 > To: Laszlo Ersek ; devel@edk2.groups.io; Kinney, Michael D > > Cc: Zurcher, Christopher ; Jiang, Guomin &

Re: [edk2-devel] CryptoPkg OpensslLib INF files

2022-09-26 Thread Christopher Zurcher
I don't have the resources to work on the script modification at the moment, but I could potentially have something put together in the next month or two. Thanks, Christopher Zurcher > -Original Message- > From: Kinney, Michael D > Sent: Monday, September 26, 2

Re: [edk2-devel] CryptoPkg OpensslLib INF files

2022-09-25 Thread Christopher Zurcher
n QEMU or hardware-based testing. Related to that, it seems the [BuildOptions] section in the INF can't be used to pass DLINK_FLAGS; do you know if this is an intentional limitation or just unimplemented? Thanks, Christopher Zurcher -Original Message- From: Kinney, Michael D Sent: Su

Re: [edk2-devel] CryptoPkg OpensslLib INF files

2022-09-23 Thread Christopher Zurcher
. The build options can also be affected such that you'd have different sets of those as well (the OPENSSL_FLAGS_CONFIG define). If we can commit to limiting the accelerated algorithms to the current selection, it should be possible to unify the files. Thanks, Christopher Zurcher -Ori

[edk2-devel] [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

2022-09-22 Thread Christopher Zurcher
variant is also provided. The implementation here follows the previous implementation of X64 native instructions as committed in 878a92a887. Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Christopher Zurcher (3): CryptoPkg/OpensslLib: Add native instruction support

[edk2-devel] [PATCH v1 3/3] CryptoPkg/OpensslLib: Update generated files for native X64

2022-09-22 Thread Christopher Zurcher
Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Christopher Zurcher --- CryptoPkg/Library/OpensslLib/OpensslLibX64.inf| 53 CryptoPkg/Library/OpensslLib/OpensslLibX64Gcc.inf | 53 2 files changed, 106

[edk2-devel] [PATCH v1 1/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

2022-09-22 Thread Christopher Zurcher
Signed-off-by: Christopher Zurcher --- CryptoPkg/CryptoPkg.ci.yaml| 4 + CryptoPkg/Library/OpensslLib/OpensslLibIa32.inf| 699 CryptoPkg/Library/OpensslLib/OpensslLibIa32Gcc.inf | 699 CryptoPkg/Library/OpensslLib

Re: [edk2-devel] [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

2022-09-21 Thread Christopher Zurcher
-available accelerations in the X64 equivalent library. These flows have also been validated on in-market hardware. Previous benchmarking of this code demonstrated a 12x speed improvement for SHA256 compared to the base algorithm. Thanks, Christopher Zurcher -Original Message- From: devel@edk2

Re: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

2021-08-06 Thread Christopher Zurcher
Ard, Is the removal of the COMMON section during the build not redundant to the -fno-common option? Do you expect cases where we will still see the undesired variable collisions? Thanks, Christopher Zurcher -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent

Re: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

2021-07-20 Thread Christopher Zurcher
Yes, this was verified with OVMF. Thanks, Christopher Zurcher -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Tuesday, July 20, 2021 18:12 To: christopher.zurc...@outlook.com; devel@edk2.groups.io Cc: 'Ard Biesheuvel' ; 'Bob Feng' Subj

[edk2-devel] [PATCH v7 2/3] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-20 Thread Christopher Zurcher
From: Christopher Zurcher BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 Adding OpensslLibX64.inf and modifying process_files.pl to process this file and generate the necessary assembly files. Adding OpensslLibX64Gcc.inf to allow building with GCC toolchain. ApiHooks.c contains a stub

[edk2-devel] [PATCH v7 0/3] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-20 Thread Christopher Zurcher
From: Christopher Zurcher V7 Changes: Move BaseTools change to a separate commit. V6 Changes: Add GCC-compatible version of these modifications. Supporting GCC build of native OpenSSL .S files requires removal of *(COMMON) from the /DISCARD/ section of the GCC linker script. The

[edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

2021-07-20 Thread Christopher Zurcher
From: Christopher Zurcher BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 The COMMON section is used by OpenSSL assembly-optimized crypto functions. OpenSSL assembly code is auto-generated from the submodule and cannot be modified to remove dependence on the COMMON section. The default

Re: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-09 Thread Christopher Zurcher
separate commit. Thanks, Christopher Zurcher -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Tuesday, July 6, 2021 18:41 To: devel@edk2.groups.io; jiewen@intel.com; 'Christopher Zurcher' Cc: 'Wang, Jian J' ; 'Lu, XiaoyuX'

Re: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-06-21 Thread Christopher Zurcher
files as a GCC tool chain alternative. Thanks, Christopher Zurcher -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Sunday, June 20, 2021 18:34 To: devel@edk2.groups.io; christopher.zurc...@outlook.com Cc: 'Jiewen Yao' ; 'Jian J Wang' ; '

[edk2-devel] [PATCH v6 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-06-20 Thread Christopher Zurcher
From: Christopher Zurcher BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 Adding OpensslLibX64.inf and modifying process_files.pl to process this file and generate the necessary assembly files. Adding OpensslLibX64Gcc.inf to allow building with GCC toolchain. ApiHooks.c contains a stub

[edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-06-20 Thread Christopher Zurcher
From: Christopher Zurcher V6 Changes: Add GCC-compatible version of these modifications. Supporting GCC build of native OpenSSL .S files requires removal of *(COMMON) from the /DISCARD/ section of the GCC linker script. The VS/CLANG portion of the patch is unchanged from the