Re: 回复: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-10-05 Thread Cole
r being thrown? Maybe the fix is simple but I can't But as mentioned elsewhere, python2 has been End of Life since Jan 1 2020, over 1.5 years ago. It's going to become increasingly difficult to keep code working on python2 and latest python3. - Cole -=-=-=-=-=-=-=-=-=-=-=- Groups.

[edk2-devel] [PATCH 3/3] BaseTools: Drop check for distutils.utils

2021-07-23 Thread Cole
distutils.utils is no longer used anywhere, so this check can be dropped. Signed-off-by: Cole Robinson --- BaseTools/Tests/RunTests.py | 7 --- 1 file changed, 7 deletions(-) diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py index 81af736cd8..934683a446 100644 --- a

[edk2-devel] [PATCH 1/3] build: Fix python3.10 threading DeprecationWarnings

2021-07-23 Thread Cole
threading camelCase functions have preferred alternatives since python2.6. python3.10 has started emitting DeprecationWarnings for them Signed-off-by: Cole Robinson --- BaseTools/Source/Python/build/build.py | 48 +- 1 file changed, 24 insertions(+), 24 deletions

[edk2-devel] [PATCH 2/3] python: Replace distutils.utils.split_quotes with shlex.split

2021-07-23 Thread Cole
tions/54999301/what-is-the-difference-between-distutils-util-split-quoted-and-shlex-split Signed-off-by: Cole Robinson --- BaseTools/Source/Python/AutoGen/UniClassObject.py | 4 ++-- BaseTools/Source/Python/UPT/Library/UniClassObject.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

[edk2-devel] [PATCH 0/3] BaseTools: fix some python DeprecationWarnings

2021-07-23 Thread Cole
This addresses some python DeprecationWarnings that are popping up with python 3.10 Cole Robinson (3): build: Fix python3.10 threading DeprecationWarnings python: Replace distutils.utils.split_quotes with shlex.split BaseTools: Drop check for distutils.utils .../Source/Python/AutoGen

Re: [edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-12 Thread Cole
On 8/12/20 5:37 AM, Laszlo Ersek wrote: > On 08/12/20 00:51, Cole Robinson wrote: >> On 8/11/20 5:55 PM, Laszlo Ersek wrote: >>> On 08/11/20 20:09, Cole Robinson wrote: >>>> Googling for 'edk2 pull request' did not find this wiki page: >>>> &

Re: [edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-11 Thread Cole
On 8/11/20 5:55 PM, Laszlo Ersek wrote: > On 08/11/20 20:09, Cole Robinson wrote: >> Googling for 'edk2 pull request' did not find this wiki page: >> >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process >> >> Add it

[edk2-devel] [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki

2020-08-11 Thread Cole
Googling for 'edk2 pull request' did not find this wiki page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Add it to CONTRIBUTING.md for more discoverability Signed-off-by: Cole Robinson --- I tried submitting a PR to edk2: https://github.com/tian

[edk2-devel] [PATCH 1/2] BaseTools: fix ucs-2 lookup on python 3.9

2020-08-11 Thread Cole
ject.py", line 303, in OpenUniFile UniFileClassObject.VerifyUcs2Data(FileIn, FileName, Encoding) File "/builddir/build/BUILD/edk2-edk2-stable202002/BaseTools/Source/Python/AutoGen/UniClassObject.py", line 312, in VerifyUcs2Data Ucs2Info = codecs.lookup('ucs-2') Lookup

[edk2-devel] [PATCH 2/2] BaseTools: Work around array.array.tostring() removal in python 3.9

2020-08-11 Thread Cole
mmon/Misc.py", line 1638, in __init__ if ByteArray.tostring() != b'PE\0\0': AttributeError: 'array.array' object has no attribute 'tostring' Signed-off-by: Cole Robinson --- BaseTools/Source/Python/Common/Misc.py | 2 +- 1 file changed, 1 insertion(+), 1 dele

[edk2-devel] [PATCH 0/2] BaseTools: Python 3.9 fixes

2020-08-11 Thread Cole
These patches fix two issues running the BaseTools test suite on python 3.9 from Fedora rawhide. See patches for individual details Cole Robinson (2): BaseTools: fix ucs-2 lookup on python 3.9 BaseTools: Work around array.array.tostring() removal in python 3.9 BaseTools/Source/Python

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-02 Thread Cole, Deric
sembly. -Deric -Original Message- From: Ni, Ray Sent: Monday, June 1, 2020 9:51 PM To: Cole, Deric ; devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek Subject: RE: [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector Deric, Can you explain why changing all padding 0x0 to 0x90 (nop) in you

[edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-02 Thread Deric Cole
in the DI register. The platform-specific SEC code is expected to check for that value and take a different path for APs, if this feature is supported by the platform. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Deric Cole --- UefiCpuPkg/SecCore/Ia32/ResetVec.

[edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-12 Thread Cole Robinson
Building with python3.8 shows a warning like: SyntaxWarning: invalid escape sequence \( GuidName = re.compile("\(GUID=[-a-fA-F0-9]+") It seems harmless, but it's easy enough to fix: mark the string as raw with the 'r' prefix like is used elsewhere in the file Sig