Re: [edk2-devel] [PATCH v1-resend 1/1] ShellPkg: Add revision check for DSDT Header on Arm

2022-08-23 Thread Edward Pickup
Hi Zhichao, Would it be possible to get some feedback on this patch? Regards, Edward On 20/07/2022 09:59, Edward Pickup via groups.io wrote: Bugzilla: 3995 (https://bugzilla.tianocore.org/show_bug.cgi?id=3995) ACPI 6.4 spec states that if the revision field in the DSDT header is less than 2

[edk2-devel] [PATCH v1] DynamicTablesPkg: Fix using RmrNodeCount unitlitialised

2022-08-04 Thread Edward Pickup
Fix using RmrNodeCount uninitliased by initliasing it to zero. Also, add an additional check for ACPI version. This fixes a crash running on kvmtool. Signed-off-by: Edward Pickup --- Change can be seen at https://github.com/edpickup/edk2/tree/2322_rmrnodecount_uninitialised_v1

[edk2-devel] [PATCH] ArmVirtPkg: Fix KVM Guest Firmware

2022-08-02 Thread Edward Pickup
Fix build of KVM Guest Firmware, broken by commit 4c55f6394fafe0494ec24e7c05cb68c938d7852d Signed-off-by: Edward Pickup --- The change can be seen at https://github.com/edpickup/edk2/tree/2321_fix_kvm_guest_v1 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.c | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v1-resend 1/1] ShellPkg: Add revision check for DSDT Header on Arm

2022-07-20 Thread Edward Pickup
6.3 or later, and that legacy tables are not supported. Adds a check for this field and raise warning if revision is less than 2 on arm. Signed-off-by: Edward Pickup --- The changes can be seen at https://github.com/edpickup/edk2/tree/2073_add_DSDT_revision_check_v1_resend Notes: v1

[edk2-devel] [PATCH v1 1/1] ShellPkg: Add revision check for DSDT Header

2022-04-28 Thread Edward Pickup
From: Edward ACPI 6.4 spec states that if the revision field in the DSDT header is less than 2, then all integers are restricted in width to 32 bits, including in SSDTs. Adds a check for this field and raise warning if revision is less than 2. Signed-off-by: Edward Pickup --- The changes can

[edk2-devel] [PATCH v2 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-28 Thread Edward Pickup
full width, fixing the error. Signed-off-by: Edward Pickup --- The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v2 Notes: v2: - Corrected Memory Address Size Limit [Ard] Platform/ARM/VExpressPkg/ConfigurationManager

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-28 Thread Edward Pickup
Hello Collin, thank you for your comments On 27/04/2022 12:36, Ard Biesheuvel wrote: Hello Edward, Thanks for the patch. On Wed, 27 Apr 2022 at 10:59, Edward Pickup wrote: When booting Linux on FVP RevC, Linux reports the following error: ACPI: IORT: [Firmware Bug]: Root complex missing

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-27 Thread Edward Pickup
, so set this in the configuration manager, fixing the error. Signed-off-by: Edward Pickup --- The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c

Re: [edk2-devel] [PATCH TEST edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-27 Thread Edward Pickup
Please ignore this patch, first email on the mailing list and was testing the formatting and configuration. Actual patch to follow shortly and separately -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89342): https://edk2.groups.io/g/dev

[edk2-devel] [PATCH TEST edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-26 Thread Edward Pickup
From: Edward Pickup When booting Linux on FVP RevC, Linux reports the following error: ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit This issue is due to the RC Address Limit not being configured in the configuration manager for the platform. The default model