Re: [edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-19 Thread Fan, ZhijuX
Hi LiMing, I agree with this change and will improve it Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: Gao, Liming > Sent: Wednesday, April 15, 2020 9:21 PM > To: Fan, ZhijuX ; devel@edk2.groups.io > Cc: Feng, Bob C

[edk2-devel] [PATCH V6] BaseTools:Add the spare space FV image size checker

2020-04-15 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

[edk2-devel] [PATCH V4] BaseTools:Add the spare space FV image size checker

2020-04-12 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

[edk2-devel] [PATCH V3] BaseTools:Add the spare space FV image size checker

2020-04-08 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

[edk2-devel] [PATCH V2] BaseTools:Add the spare space FV image size checker

2020-04-07 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
Hi, It can be implemented independent of the GenFds tool It accepts the parameters passed by building and GenFds Tool Best Regards Fan Zhiju From: sean.brogan via [] Sent: Friday, April 3, 2020 10:51 AM To: Fan; Fan, ZhijuX ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1

[edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

[edk2-devel] [PATCH V6] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-26 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [PATCH V5] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-26 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

2020-03-19 Thread Fan, ZhijuX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610 We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error. Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise

[edk2-devel] [PATCH V4] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-17 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [PATCH V3] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-17 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [PATCH V4] BaseTools:copy the common PcdValueCommon.c to output directory

2020-03-11 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2568 PcdValueInit shares the same Edk2\BaseTools\Source\C\PcdValueCommon.c. To avoid the conflict, it should copy this file to its output directory, If so, PcdValueCommon.c file will be private for PcdValueInit Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH V3] BaseTools:copy the common PcdValueCommon.c to output directory

2020-03-11 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2568 PcdValueInit shares the same Edk2\BaseTools\Source\C\PcdValueCommon.c. To avoid the conflict, it should copy this file to its output directory, If so, PcdValueCommon.c file will be private for PcdValueInit Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH V2] BaseTools:copy the common PcdValueCommon.c to output directory

2020-03-11 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2568 PcdValueInit shares the same Edk2\BaseTools\Source\C\PcdValueCommon.c. To avoid the conflict, it should copy this file to its output directory, If so, PcdValueCommon.c file will be private for PcdValueInit Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH 1/1] BaseTools:copy the common PcdValueCommon.obj to output directory

2020-03-09 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2568 PcdValueInit shares the same Edk2\BaseTools\Source\C\PcdValueCommon.obj. To avoid the conflict, it should copy this file to its output directory, If so, PcdValueCommon.obj file will be private for PcdValueInit Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH V2] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-05 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [PATCH] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-04 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt.

[edk2-devel] [Patch 1/1] BaseTools:build failure in CLANGPDB tool chain

2020-02-12 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2520 Incremental build failure in CLANGPDB tool chain on Windows host The build failure is like below when do incremental build. The root cause is in generated deps_target file. It has one line ":". Signed-off-by: Zhiju.Fan Cc: Liming Gao Cc:

[edk2-devel] [Patch] BaseTools: Fixed build failure when using python38

2020-02-11 Thread Fan, ZhijuX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304 SyntaxWarning: "is" with a literal. Did you mean "=="? Using "is" instead of "==" is an irregular syntax Signed-off-by: Zhiju.Fan Cc: Bob C Feng Cc: Liming Gao --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1

[edk2-devel] [PATCH V2] BaseTools:ECC fails to detect function header comments issue

2020-01-21 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1523 When the keyword after @param doesn't match the actual function parameter name, ECC doesn't detect such issue The patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- Optimize the code to Give the

[edk2-devel] [PATCH] BaseTools:ECC fails to detect function header comments issue

2020-01-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1523 When the keyword after @param doesn't match the actual function parameter name, ECC doesn't detect such issue The patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/c.py

[edk2-devel] [PATCH V2] BaseTools:fix Ecc tool issue for check StructPcd

2020-01-16 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142 gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation| {0x0}|SMBIOS_TABLE_TYPE0|0x8001 { IndustryStandard/SmBios.h MdePkg/MdePkg.dec AdvancedFeaturePkg/AdvancedFeaturePkg.dec } If there's a

[edk2-devel] [PATCH V2] BaseTools:fix Ecc tool issue for check StructPcd

2020-01-10 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142 gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation| {0x0}|SMBIOS_TABLE_TYPE0|0x8001 { IndustryStandard/SmBios.h MdePkg/MdePkg.dec AdvancedFeaturePkg/AdvancedFeaturePkg.dec } If there's a

[edk2-devel] [PATCH V3] BaseTools:Change the case rules for ECC check pointer names

2020-01-10 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like

[edk2-devel] [PATCH V2] BaseTools:Fix GenFds issue for BuildOption replace GenFdsOption

2020-01-10 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2455 BuildOption is used by TargetTxtClassObj.py GenFdsOption is used by GenFds.py When the GenFds tool is used alone (e.g. python3 -m GenFds.GenFds -h) With the OptionParser function, the first detected function prints the help message import

[edk2-devel] [PATCH V2] BaseTools:Change the case rules for ECC check pointer names

2020-01-09 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like

[edk2-devel] [PATCH] BaseTools:fix Ecc tool issue for check StructPcd

2020-01-07 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142 gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation| {0x0}|SMBIOS_TABLE_TYPE0|0x8001 { IndustryStandard/SmBios.h MdePkg/MdePkg.dec AdvancedFeaturePkg/AdvancedFeaturePkg.dec } If there's a

[edk2-devel] [PATCH] BaseTools:Change the case rules for ECC check pointer names

2020-01-07 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like

[edk2-devel] [PATCH] BaseTools:Reconfig reset environment value set by edksetup script

2019-12-25 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1985 Reconfig option should not only update build config files. This option should reset environment value set by edksetup script, such as EDK_TOOLS_PATH/PYTHONPATH. If so, this option will be valuable for the user to switch the different

[edk2-devel] [PATCH] BaseTools:replaces the two offending quotes by ascii quotes

2019-12-16 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2423 That commit 13c5e34a1b introduces the first two UTF-8 characters (the quote ') in an otherwise all-ascii file. In Conf\tools_def.template There is tow lines of Notes: Since this tool chain is obsolete, it doesn't enable the compiler

[edk2-devel] [PATCH] BaseTools:Enhance the way to handling included dsc file

2019-12-03 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2400 In Dsc Parser, included dsc file is parsed always no matter if its condition is False gUefiOvmfPkgTokenSpaceGuid.test1|FALSE !if gUefiOvmfPkgTokenSpaceGuid.test1 == FALSE !include OvmfPkg/test1.dsc !else !include OvmfPkg/test2.dsc

[edk2-devel] [PATCH V2] BaseTools:fix issue for decode the stdout/stderr byte arrays

2019-12-01 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2365 This patch is to fix a build tool regression issue which was introduced by commit 8ddec24dea74. compiler output message includes localized string. So build failed when code decode the stdout/stderr byte arrays. The cause of the build failed

[edk2-devel] [PATCH] BaseTools:Change judgment symbol "is" to "==" for python3.8

2019-11-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2304 build.py and BuildReport.py warning using python 3.8 SyntaxWarning: "is" with a literal. Did you mean "=="? For comparison of two strings use "==" instead of "is" The patch is going to fixed this issue. Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH V3] BaseTools:fix regression issue for platform .map file

2019-11-22 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2363 This patch is to fix a build tool regression issue which was introduced by commit b8ac0b7f28.This issue caused map file lost the line of IMAGE=***. For example,in Ovmf.map, there is no line of (IMAGE= ) under each of modules item. The path

[edk2-devel] [PATCH V2] BaseTools:fix regression issue for platform .map file

2019-11-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2363 The line of IMAGE=*** is missing in platform .map file.For example, in Ovmf.map, there is no line of (IMAGE= ) under each of modules item. This is a regression issue. this patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH] BaseTools:fixed Build failed issue for Non-English OS

2019-11-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2365 Build failed on Non-English OS if structurePcd is used in platform dsc file. When the output of some functions is converted to code, Because different OS Character encoding form differently, there may be problems with some functions The

[edk2-devel] [PATCH] BaseTools:fix regression issue for platform .map file

2019-11-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2363 The line of IMAGE=*** is missing in platform .map file.For example, in Ovmf.map, there is no line of (IMAGE= ) under each of modules item. This is a regression issue. this patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng

Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-19 Thread Fan, ZhijuX
er 15, 2019 9:55 AM > To: Fan, ZhijuX ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PATCH V2] BaseTools:Add [packages] section in dsc file > > Zhiju: > Can you show what test are done for this new support? > > Thanks > Liming > >-Original Message-

[edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-13 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2270 Currently a PCD (e.g. FeaturePCD) cannot be used in a conditional statement in a DSC/FDF file without a module in the build referencing the PCD package DEC file. An example implementation that to support this is to allow a [Packages] section

[edk2-devel] [PATCH] BaseTools:Add [packages] section in dsc file

2019-11-12 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2270 Currently a PCD (e.g. FeaturePCD) cannot be used in a conditional statement in a DSC/FDF file without a module in the build referencing the PCD package DEC file. An example implementation that to support this is to allow a [Packages] section

[edk2-devel] [PATCH] BaseTools:Reconfig reset environment value set by edksetup script

2019-09-29 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1985 Reconfig option should not only update build config files. This option should reset environment value set by edksetup script, such as EDK_TOOLS_PATH/PYTHONPATH. If so, this option will be valuable for the user to switch the different

[edk2-devel] [PATCH] BaseTools:fix Ecc tool issue for check StructPcd

2019-09-26 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142 gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation| {0x0}|SMBIOS_TABLE_TYPE0|0x8001 { IndustryStandard/SmBios.h MdePkg/MdePkg.dec AdvancedFeaturePkg/AdvancedFeaturePkg.dec } If there's a

[edk2-devel] [PATCH V2] BaseTools:Fix the issue that build report failed

2019-09-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2201 An error occurs using special VpdPcd that is not used in the Inf file In dsc: [PcdsDynamicExVpd.common.DEFAULT] gBoardModuleTokenSpaceGuid.test1|*|{CODE({ {0x0} // terminator })} In dec: [PcdsDynamicEx] # Vpd GPIO table

[edk2-devel] [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator

2019-09-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1944 FormatDosFiles.py Intel\ServerSiliconPkg --exclude Library\SimRegisters\ Its parameter "Library\SimRegisters\" ends with '\' but I can't seem to get it to exclude the SimRegisters directory This patch is going to fix this issue Cc: Liming

[edk2-devel] [PATCH] BaseTools:Change the way that get some VpdPcd information

2019-09-18 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2201 An error occurs using special VpdPcd that is not used in the Inf file In dsc: [PcdsDynamicExVpd.common.DEFAULT] gBoardModuleTokenSpaceGuid.test1|*|{CODE({ {0x0} // terminator })} In dec: [PcdsDynamicEx] # Vpd GPIO table

[edk2-devel] [PATCH] BaseTools:Replace PlatformInfo with PlatformAutoGen for Moudle

2019-09-12 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2188 build -p MdeModulePkg\MdeModulePkg.dsc -a IA32 -m MdeModulePkg\Universal\PCD\Pei\Pcd.inf Error: AttributeError: 'PlatformInfo' object has no attribute 'DynamicPcdList' The DSC data object used to build a separate module today is

[edk2-devel] [PATCH] BaseTools:change some incorrect parameter defaults

2019-09-12 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1858 for Dict={},There are pitfalls in the way this default parameter is set and Dict is not used in functions, other functions have these two cases, I will change some incorrect parameter defaults This patch is going to fix this issue Cc:

[edk2-devel] [PATCH] BaseTools:Change the case rules for ECC check pointer names

2019-09-11 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like

[edk2-devel] [PATCH] BaseTools:Ecc handle another copyright format

2019-09-05 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2057 Ecc can not handle the copyright format like (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP This will cause Ecc to report wrong information. This patch is going to handle this format Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH] BaseTools:ECC need to handle lower case 'static'

2019-09-04 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1778 We are going to add keyword (lower case) 'static' for functions and global variables which are not referenced outside their current C file. However, the ECC tool only recognizes upper case 'STATIC' at this moment. This will lead to issue

[edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

2019-08-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093 The PlatformAutoGen object has a DataPipe property but no DataPile property So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan

[edk2-devel] [PATCH V2] BaseTools: Update incorrect variable name 'DataPile'

2019-08-19 Thread Fan, ZhijuX
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2093 The PlatformAutoGen object has a DataPipe property but no DataPile property So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Signed-off-by:

[edk2-devel] [PATCH] BaseTools: Update incorrect variable name 'DataPile'

2019-08-19 Thread Fan, ZhijuX
The PlatformAutoGen object has a DataPipe property but no DataPile property So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/build/BuildReport.py | 2

[edk2-devel] [PATCH 2/2] BaseTools:Build cache generate the offset file for hii/vfr module

2019-07-29 Thread Fan, ZhijuX
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1958 Current build cache cannot generate the offset file for hii/vfr module Reproduce steps on OVMF: 1. Generate the build cache and save the build folder as Build1: $ source edksetup.sh $ build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 -t

[edk2-devel] [PATCH 1/2] BaseTools:Fix GenFds multi-thread build fails if enable build cache

2019-07-29 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1923 The GenFds multi-thread will build fail if enable the build cache. 1. First, produce the build cache: edk2>build -p OvmfPkg\OvmfPkgIa32X64.dsc -a IA32 -a X64 -t VS2015x86 -n 5 --genfds-multi-thread --hash --binary-destination=BinCache 2.

[edk2-devel] [PATCH] Build Spec:Add Module Arch to BuildRebuild Module Section

2019-07-25 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2022 Added arch output to build report so it's easy to tell which arch is being generated. Code change https://bugzilla.tianocore.org/show_bug.cgi?id=2016 will be done.The spec change is also required. Cc: Bob Feng Cc: Liming Gao Signed-off-by:

[edk2-devel] [PATCH V2] BaseTools:Added arch output to build report

2019-07-24 Thread Fan, ZhijuX
From: Matthew Carlson BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016 Added arch output to build report so it's easy to tell which arch is being generated. Useful when multiple versions of a single module is being emitted for multiple archs. This patch is going to Added arch output Cc:

[edk2-devel] [PATCH V2] BaseTools:Updata the output encoding of the Popen function

2019-07-24 Thread Fan, ZhijuX
From: Bob Feng BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2015 Not all output works in utf-8, so change the encoding to the default This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/Misc.py

[edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-07-24 Thread Fan, ZhijuX
From: Max Knutsen BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014 Add extra debugging to improve error identification. Error while processing file if the file is read incorrectly This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan ---

[edk2-devel] [PATCH V2] BaseTools: replace the chinese quotation mark with unicode "

2019-07-24 Thread Fan, ZhijuX
From: Sean Brogan BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013 chinese quotation mark are used in the file This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +- 1 file changed, 1

[edk2-devel] [PATCH] BaseTools:Updata the output encoding of the Popen function

2019-07-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2015 Not all output works in utf-8, so change the encoding to the default This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/Misc.py | 2

[edk2-devel] [PATCH] BaseTools:Added arch output to build report

2019-07-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016 Added arch output to build report so it's easy to tell which arch is being generated. Useful when multiple versions of a single module is being emitted for multiple archs. This patch is going to Added arch output Cc: Bob Feng Cc: Liming

[edk2-devel] [PATCH] BaseTools:Add extra debugging message

2019-07-24 Thread Fan, ZhijuX
Add extra debugging to improve error identification. Error while processing file if the file is read incorrectly This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/StrGather.py | 16 ++--

[edk2-devel] [PATCH] BaseTools: replace the chinese quotation mark with unicode "

2019-07-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013 chinese quotation mark are used in the file This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[edk2-devel] [PATCH] BaseTools:Fix GenFds multi-thread build fails if enable build cache

2019-07-22 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1923 The GenFds multi-thread will build fail if enable the build cache. 1. First, produce the build cache: edk2>build -p OvmfPkg\OvmfPkgIa32X64.dsc -a IA32 -a X64 -t VS2015x86 -n 5 --genfds-multi-thread --hash --binary-destination=BinCache 2.

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-28 Thread Fan, ZhijuX
p.org Sent: Wednesday, June 26, 2019 11:48 PM To: devel@edk2.groups.io; Fan, ZhijuX Cc: Gao, Liming ; Feng, Bob C Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged On 2019-06-25 22:46, Fan, ZhijuX wrote: Hi: Python3.6 and python3.7 After the code removes s

[edk2-devel] [PATCH V2] BaseTools:Add the Judgment Method of "--exclude"

2019-06-28 Thread Fan, ZhijuX
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1944 --exclude cannot be used under certain circumstances 1.The value of the parameter USES an absolute path 2.The value of Exclude parameters is based on the value of the Path parameter Neither of these approaches currently works This patch

[edk2-devel] [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

[edk2-devel] [PATCH] BaseTools:Updata the Judgment Method of "--exclude"

2019-06-26 Thread Fan, ZhijuX
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1944 --exclude cannot be used under certain circumstances 1.The value of the parameter USES an absolute path 2.The value of Exclude parameters is based on the value of the Path parameter Neither of these approaches currently works This patch

[edk2-devel] [edk2-platform patch V5] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-26 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni

[edk2-devel] [PATCH V2] BaseTools:Linux changes the way the latest version is judged

2019-06-25 Thread Fan, ZhijuX
Some Linux servers do not have BC installed,so errors occur. So the judgment was changed to avoid this error. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- Change "\<" to "<" and add as two "[]" edksetup.sh | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [edk2-platform patch V3] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-25 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-24 Thread Fan, ZhijuX
;$python_version" ];then These two approaches work Any question, please let me know. Thanks. Best Regards Fan Zhiju -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of rebe...@bluestop.org Sent: Monday, June 24, 2019 11:25 AM To: devel@edk2.grou

[edk2-devel] [edk2-platform patch V2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

[edk2-devel] [PATCH V4] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850

This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs.
The input parameters are Dec file and package directory.

This script can be run in 

[edk2-devel] [edk2-platform patch 1/2 V2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. This tool can be run in both Py2 and Py3. This patch is going to add GenBiosId to Platform/Intel/Tools Cc: Liming Gao Cc: Bob Feng

Re: [edk2-devel] [edk2-platform patch 2/2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
occurs is an original feature of the script, so it is not modified for argparse. Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, June 21, 2019 5:04 PM > To:

Re: [edk2-devel] [edk2-platform patch 1/2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
l@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Friday, June 21, 2019 5:01 PM > To: Fan, ZhijuX > Cc: devel@edk2.groups.io; Gao, Liming ; Feng, Bob C > ; Ard Biesheuvel ; > Kinney, Michael D > Subject: Re: [edk2-devel] [edk2-platform patch 1/2] Pla

[edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1929 Some Linux servers do not have BC installed,so errors occur. So the judgment was changed to avoid this error. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- edksetup.sh | 6 ++ 1 file changed, 2 insertions(+), 4

[edk2-devel] [edk2-platform patch 2/2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

[edk2-devel] [edk2-platform patch 1/2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. This tool can be run in both Py2 and Py3. This patch is going to add GenBiosId to Platform/Intel/Tools Cc: Liming Gao Cc: Bob Feng

[edk2-devel] [PATCH] BaseTools:Add import in FvImageSection

2019-06-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1872 Since MultipleWorkspace is not imported in FvImageSection, an error of "global name 'MWS' is not defined" appeared. This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan ---

[edk2-devel] [PATCH V3] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850

This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs.
The input parameters are Dec file and package directory.

This script can be run in 

[edk2-devel] [PATCH V3] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

2019-06-19 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

[edk2-devel] [PATCH] BaseTools:Remove unused Edk2\BuildNotes2.txt

2019-06-18 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1889 Edk2\BuildNotes2.txt is not maintained any more. User can find the related info in wiki. So, this file can be removed. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BuildNotes2.txt | 154

[edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread Fan, ZhijuX
GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. https://bugzilla.tianocore.org/show_bug.cgi?id=1846 v2:v1 is a tool of C type and v2 is python type. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang ---

[edk2-devel] [PATCH 2/3 V2] Platform/Intel:Add build parameter to support Binary Cache

2019-06-16 Thread Fan, ZhijuX
Need extend the options in the Intel/build_bios.py file to support Binary Cache. --hash: Enable hash-based caching during build process. --binary-destination: Generate a cache of binary files in the specified directory. --binary-source: Consume a cache of binary files from the

[edk2-devel] [PATCH 1/3 V2] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

2019-06-16 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming

[edk2-devel] [PATCH 0/3] Makes binary cache available in Platform/Intel

2019-06-16 Thread Fan, ZhijuX
Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram Cc: Chasel Chiu Cc:

[edk2-devel] [PATCH V2] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-13 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850

This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs.
The input parameters are Dec file and package directory.

This script can be run in 

[edk2-devel] [PATCH] BaseTools:Build cache support the cache files for library package

2019-06-05 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1867 Current build cache cannot store the cache for library package. build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash --binary-destination=BinCache After build, the expected result is the BinCache folder is generated and the MdePkg

[edk2-devel] [PATCH] BaseTools:Build Cache output notification message

2019-06-05 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1868 Build need output the cache miss or hit notification message when consume the build cache. Current build does not output any message which is not clear for user to know whether the module built result is from cache or not. This patch adds

[edk2-devel] [PATCH 4/4] PurleyOpenBoardPkg:Extend options in bld.bat to support Binary Cache

2019-05-30 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Need extend the options in the Kabylake build bld.bat file to support Binary Cache. BINARY_CACHE_PATH: if BINARY_CACHE_PATH is empty, use BinCache as default path Add "cache-produce" and "cache-consume" to command line, Used to generate and

[edk2-devel] [PATCH 3/4] KabylakeOpenBoardPkg:Extend options in bld.bat to support Binary Cache

2019-05-30 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 Need extend the options in the Kabylake build bld.bat file to support Binary Cache. BINARY_CACHE_PATH: if BINARY_CACHE_PATH is empty, use BinCache as default path Add "cache-produce" and "cache-consume" to command line, Used to generate and

[edk2-devel] [PATCH 2/4] Platform/Intel:Add build parameter to support Binary Cache

2019-05-30 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Need extend the options in the Intel/build_bios.py file to support Binary Cache. --hash: Enable hash-based caching during build process. --binary-destination: Generate a cache of

[edk2-devel] [PATCH 1/4] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

2019-05-30 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming

[edk2-devel] [PATCH 0/4] Makes binary cache available in Platform/Intel

2019-05-30 Thread Fan, ZhijuX
Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram Cc: Chasel Chiu Cc:

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Fan, ZhijuX
Wednesday, May 29, 2019 3:16 PM > To: Fan, ZhijuX ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH V5] BaseTools:Make BaseTools support new rules to > generate RAW FFS FILE > > Hi Zhiju, > > For the changes, > > -def __InfParse__(self, Dict = {}): &g

[edk2-devel] [PATCH V2] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

2019-05-29 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

  1   2   >