Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-05-31 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] We did crisis recovery and Opal HD password unlock from S3 resume from SATA HD test on two different version of AHCI host controllers. Thanks, Jiangang -Original Message- From: Wu, Hao A Sent: Tuesday, May 30, 2023 10:30 PM To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library

2023-01-12 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] Timothy will answer the question. From: Chang, Abner Sent: Thursday, January 12, 2023 10:05 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett ; Kinney, Michael D ; He, Jiangang Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2023-01-09 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] Hi Hao, Yes UsbHcUnlinkMemBlock() call should be uncommented. -- for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { UsbHcUnlinkMemBlock (Pool->Head, Block); UsbHcFreeMemBlock (Pool, Block); }

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] UsbHcFreeMemBlock()->IoMmuFreeBuffer()->mIoMmu->FreeBuffer(), which may end up calling PeiFreePages() depending on gEdkiiIoMmuPpiGuid implementation. Surely both will work since UsbHcFreeMemPool() can't be interrupted by any service call to use the memory just

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-19 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] Yes, it is the same issue discussed in https://edk2.groups.io/g/devel/topic/92833071#92165 MdeModulePkg\Bus\Pci\XhciPei\UsbHcMem.c for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { // UsbHcUnlinkMemBlock (Pool->Head, Block);