Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-12-19 Thread Jiading Zhang
Hi. I commit a PR again, and the PR passed all the test. https://github.com/tianocore/edk2/pull/3792/commits Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97556): https://edk2.groups.io/g/devel/message/97556 Mute This Topic: ht

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-12-17 Thread Jiading Zhang
OK. I Commit a PR for the change: UefiPayloadPkg: Define default values for the DynamicEX PCDs #3785 Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97526): https://edk2.groups.io/g/devel/message/97526 Mute This Topic: https://gr

[edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

2022-11-10 Thread Jiading Zhang
The following PCDs have no value in UefiPayloadPkg.dsc,and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupp

Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition.

2022-11-09 Thread Jiading Zhang
OK, I got it, thanks!  By the way, I don't know whether it is appropriate that the PCDs have no value in  UefiPayloadPkg.dsc. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96178): https://edk2.groups.io/g/devel/message/96178 Mute This T

Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition.

2022-11-09 Thread Jiading Zhang
: > > > > These PCDs are used by PciBus driver and MP init logic which are included > in the UefiPayloadPkg. > > > > > > > > *From:* devel@edk2.groups.io *On Behalf Of* Jiading > Zhang > *Sent:* Thursday, November 10, 2022 9:53 AM > *To:* devel

[edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition.

2022-11-09 Thread Jiading Zhang
The following PCDs have no value in the file of UefiPayloadPkg.dsc, and they are not used in UefiPayloadPkg, so remove them from [PcdsDynamicExDefault] section. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSuppo

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Add a parameter to indicate whether the memory allocation is for TRB Ring or not.

2022-10-17 Thread Jiading Zhang
Hi, I renamed the parameter from ‘AllocationForTrbRing’ to ‘AllocationForRing’ in UsbHcAllocMemFromBlock, which matchs the description comment. And the attachment is the updated patch file. According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte bou

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Add a parameter to indicate whether the memory allocation is for TRB Ring or not.

2022-10-17 Thread Jiading Zhang
According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte boundary, so add a parameter to indicate whether the memory allocation is for TRB or not. It will ensure the allocation not crossing 64K boundary in UsbHcAllocMemFromBlock if the memory is alloc

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-13 Thread Jiading Zhang
le, gEfiVariableIndexTableGuid guid hob should not exist. If this > guid hob exits, it should be created by other module. Please check. > > > > > > > > Thanks > > > > Liming > > > > *发件人 :* Jiading Zhang > *发送时间 :* 2022 年 10 月 10 日 16

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Allocate the Ring segments at 64K aligned address to avoid the Rings crossing a 64K byte boundary.

2022-10-10 Thread Jiading Zhang
According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte boundary, so allocate the rings at 64K aligned address to avoid they crossing a 64K byte boundary. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 112 +++-

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-10 Thread Jiading Zhang
gt; Jiading: > > > > Please check why NV variable data is required to be changed in PEI phase. > This will be helpful for this issue. > > > > > > > > Thanks > > > > Liming > > > > *发件人 :* Jiading Zhang > *发送时间 :* 202

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-09 Thread Jiading Zhang
in PEI > phase, this check is not required by NV variable. > > > > > > > > Thanks > > > > Liming > > > > *发件人 :* devel@edk2.groups.io *代表* Jiading Zhang > *发送时间 :* 2022 年 9 月 28 日 11:05 > *收件人 :* devel@edk2.groups.io > *主题 :* [edk2-devel] [PATCH] MdeMod

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-08 Thread Jiading Zhang
Hi gaoliming: I am sorry I missed it, I will take a look, thanks very much! 9 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94845): https://edk2.groups.io/g/devel/message/94845 Mute This Topic: https://groups.io/mt/94193123/21656 Group O

Re: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-07 Thread Jiading Zhang
Hello, Can anyone please help to review the patch? Thanks very much! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94824): https://edk2.groups.io/g/devel/message/94824 Mute This Topic: https://groups.io/mt/93965445/21656 Group Owner: de

[edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-09-27 Thread Jiading Zhang
When read a variable in PEI, it will find it first in the HOB, then find in variable store. When find in variable store, it will check the variable state, but find in HOB, it doesn't check the state, so if the variable was changed, it will find the obsolete variable in the HOB. Signed-off-by: j

Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4074

2022-09-21 Thread Jiading Zhang
OK. Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94051): https://edk2.groups.io/g/devel/message/94051 Mute This Topic: https://groups.io/mt/93819720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.

[edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4074

2022-09-20 Thread Jiading Zhang
Update XhcEvaluateContext/XhcEvaluateContext64 to properly initialize the input context for Evaluate Context command. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/Mde

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-20 Thread Jiading Zhang
Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Jiading Zhang Sent: Tuesday, September 20, 2022 2:00 PM To: Wu; Wu, Hao A ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64(); I up

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Jiading Zhang
I update XhcEvaluateContext64 according your suggesting and test in my platform, the KB and mass storage both can work! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93981): https://edk2.groups.io/g/devel/message/93981 Mute This Topic:

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Jiading Zhang
Hello, I test for several times and find that if add the following line, the KB and MassStorage will work, InputContext->EP[0].EPType = ED_CONTROL_BIDIR; I don't know if the issue is brought in by the different of xHCI controllers or else. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive a

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-14 Thread Jiading Zhang
When I use the newest XhciDxe driver in Phytium Platform( ARM) ,  I found if clearing “Input Context” in XhcEvaluateContext64(), the usb KB doesn't work, and mark the  code   ZeroMem (InputContext, sizeof (INPUT_CONTEXT_64));  it works. I viewed the code again, maybe change the ZeroMem (InputCon

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-14 Thread Jiading Zhang
The value of InputContext structure is initialized in XhcInitializeDeviceSlot/XhcInitializeDeviceSlot64, it shouldn't be cleared when used in XhcEvaluateContext64(). Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePk