[edk2-devel] [PATCH V3 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2022-02-08 Thread Joseph Hemann
-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Stuart Yoder Signed-off-by: Joseph Hemann Change-Id: I126f2c6316f8469455f8e2a19ca7e945e9d5d6ae --- .../SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 29 +++ .../UEFI/EFI/Protocol/TCG2/BlackBoxTest

[edk2-devel] [PATCH V3 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2022-02-08 Thread Joseph Hemann
: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Stuart Yoder Signed-off-by: Joseph Hemann Change-Id: Ibab68cae1d49953d1076c5628ea80319ba7ca831 --- .../SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 5 + .../UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h| 70

[edk2-devel] [PATCH V3 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2022-02-08 Thread Joseph Hemann
Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Stuart Yoder Signed-off-by: Joseph Hemann Change-Id: I626bc21fb3e96692f3c63043651a8e1027c6f611 --- .../SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 10

[edk2-devel] [PATCH V3 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2022-02-08 Thread Joseph Hemann
Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Stuart Yoder Signed-off-by: Joseph Hemann Change-Id: I5ca3a46b3d36e8f11848a788f6cfdcabeb5b04c8 --- .../SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 20 +++ .../UEFI/EFI/Protocol/TCG2

[edk2-devel] [PATCH V3 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2022-02-08 Thread Joseph Hemann
-implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add initial TCG2 protocol test for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -checkpoint for NULL pointer passed for buffer

[edk2-devel] [PATCH V3 0/6] Implementation of TCG2 Protocol test

2022-02-08 Thread Joseph Hemann
Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Joseph Hemann (6): uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test uefi-sct/SctPkg: TCG2

[edk2-devel] [PATCH V3 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2022-02-08 Thread Joseph Hemann
Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Stuart Yoder Signed-off-by: Joseph Hemann Change-Id: Ie71cfebd15ddccff0d8d99359ee10761adb3001f --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174

Re: [edk2-devel] [PATCH 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2022-02-07 Thread Joseph Hemann
See inline comments.. On 2/1/22, 12:33 PM, "Stuart Yoder" wrote: See inline comments... > +EFI_STATUS > +BBTestGetCapabilityConformanceTestCheckpoint2 ( > + IN EFI_STANDARD_TEST_LIBRARY_PROTOCOL*StandardLib, > + IN EFI_TCG2_PROTOCOL *TCG2 > +

[edk2-devel] [PATCH V2 0/6] Implementation of TCG2 Protocol test

2022-01-09 Thread Joseph Hemann
: Supreeth Venkatesh Joseph Hemann (6): uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

[edk2-devel] [PATCH 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2022-01-09 Thread Joseph Hemann
-add initial TCG2 protocol test for HashLogExtendEvent() -checkpoint for test of function with invalid parameters -checkpoint for test of function with valid parameters V2: -fix issue with reused Assertion Guid Signed-off-by: Joseph Hemann Change-Id

[edk2-devel] [PATCH 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2022-01-09 Thread Joseph Hemann
-add initial TCG2 protocol test for SubmitCommand() -checkpoint for test function with TPM2_Hash Command V2: -Change command submitted from GetRandom to TPM2_HASH -combined to 2 assertions into 1 Signed-off-by: Joseph Hemann Change-Id: Ibab68cae1d49953d1076c5628ea80319ba7ca831

[edk2-devel] [PATCH 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2022-01-09 Thread Joseph Hemann
-by: Joseph Hemann Change-Id: I626bc21fb3e96692f3c63043651a8e1027c6f611 --- .../EFI/Protocol/TCG2/BlackBoxTest/Guid.c | 4 + .../EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 10 ++ .../TCG2/BlackBoxTest/TCG2ProtocolBBTest.h| 23 +++ .../TCG2ProtocolBBTestConformance.c | 159

[edk2-devel] [PATCH 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2022-01-09 Thread Joseph Hemann
-add initial TCG2 protocol test for GetEventLog() -checkpoint for test function with invalid eventlog format -checkpoint for test function with valid eventlog format V2: -Change checkpoint names from HashLogExtendEvent to GetEventLog Signed-off-by: Joseph Hemann Change-Id

[edk2-devel] [PATCH 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2022-01-09 Thread Joseph Hemann
-checkpoint for validating fields of the struct returned by GetCapabilty() V2: -adds checkpoint for verifying GetCapablity() when size < Capablity Struct -adds check to ensure ActivePcrBanks is subset of HashAlgorithmBitmap -adds checks for returned status by function Signed-off-by: Joseph Hem

[edk2-devel] [PATCH 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2022-01-09 Thread Joseph Hemann
Signed-off-by: Joseph Hemann --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174 +++ 1 file changed, 174 insertions(+) create mode 100644 uefi-sct/SctPkg/UEFI/Protocol/TCG2.h diff --git a/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h b/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h new file

[edk2-devel] [PATCH 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for SubmitCommand() -checkpoint for test function with GET_RANDOM Command Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off

[edk2-devel] [PATCH 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetEventLog() -checkpoint for test function with invalid eventlog format -checkpoint for test function with valid eventlog format Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc

[edk2-devel] [PATCH 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for HashLogExtendEvent() -checkpoint for test of function with invalid parameters -checkpoint for test of function with valid parameters Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin

[edk2-devel] [PATCH 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann -implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add initial TCG2 protocol test for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -checkpoint for NULL

[edk2-devel] [PATCH 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetActivePcrBanks() -checkpoint for NULL pointer passed for buffer -checkpoint for test of function with proper input Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc

[edk2-devel] [PATCH 0/6] Implementation of TCG2 Protocol test

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann This patch series implements a set of SCT tests, for the TCG2 UEFI protocol as defined in the TCG EFI Protocol Specification. The series implements the code for the test, and the infrastructure needed to run the test from the SCT UI. Patch 1 adds header file with TCG2

[edk2-devel] [PATCH 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2021-10-20 Thread Joseph Hemann
From: Joseph Hemann Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off-by: Joseph Hemann --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174 +++ 1 file changed, 174

[edk2-devel] [PATCH 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for SubmitCommand() -checkpoint for test function with GET_RANDOM Command Signed-off-by: Joseph Hemann Change-Id: I364001c915b9d8d8b79eb4381d828400a1ef72a0 --- .../EFI/Protocol/TCG2/BlackBoxTest/Guid.c | 4 + .../EFI/Protocol

[edk2-devel] [PATCH 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetEventLog() -checkpoint for test function with invalid eventlog format -checkpoint for test function with valid eventlog format Signed-off-by: Joseph Hemann Change-Id: Ie5399f24622ce849d8f1140c56bd71cf886423e3 --- .../EFI/Protocol

[edk2-devel] [PATCH 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for HashLogExtendEvent() -checkpoint for test of function with invalid parameters -checkpoint for test of function with valid parameters Signed-off-by: Joseph Hemann Change-Id: Icac3857a5e0d877e9b21f85c20f7d391a380043e --- .../EFI

[edk2-devel] [PATCH 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetActivePcrBanks() -checkpoint for NULL pointer passed for buffer -checkpoint for test of function with proper input Signed-off-by: Joseph Hemann Change-Id: Ibf289085dc0f21952ff210757b4736619ac34046 --- .../EFI/Protocol

[edk2-devel] [PATCH 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add initial TCG2 protocol test for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -checkpoint for NULL

[edk2-devel] [PATCH 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann Signed-off-by: Joseph Hemann Change-Id: Ib8fafb94c99fbc71f606d23bcdd18963fc7386de --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174 +++ 1 file changed, 174 insertions(+) create mode 100644 uefi-sct/SctPkg/UEFI/Protocol/TCG2.h diff --git a/uefi-sct

[edk2-devel] [PATCH 0/6] Implementation of TCG2 Protocol test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann This patch series implements a set of SCT tests, for the TCG2 UEFI protocol as defined in the TCG EFI Protocol Specification. The series implements the code for the test, and the infrastructure needed to run the test from the SCT UI. Patch 1 adds header file with TCG2

[edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image

2021-10-12 Thread Joseph Hemann
J Wang Cc: Min Xu Signed-off-by: Joseph Hemann Change-Id: I6b2777bd7aeb57773b8876e44c2179ea7501bc8c --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c| 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c b

[edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Set Action for failed unsigned image

2021-10-12 Thread Joseph Hemann
Xu Signed-off-by: Joseph Hemann Change-Id: Ia432ebf4ec811e36d67b80bc438a6aff60bc9b67 --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c| 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c b/SecurityPkg

[edk2-devel] [PATCH] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image

2021-10-12 Thread Joseph Hemann
From: Joseph Hemann If the image is signed but not allowed by DB and the hash of image is not found in DB/DBX, then the EFI_IMAGE_INFO_ACTION of the load of said image should be set to, EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND, rather then being left unset as EFI_IMAGE_EXECUTION_AUTH_UNTESTED. Cc

[edk2-devel] [PATCH] Test comit please ignore this message.

2021-10-11 Thread Joseph Hemann
From: Joseph Hemann Signed-off-by: Joseph Hemann Change-Id: I11d8af6f1db0206019bd00c53c89b68323a295f7 --- patchtest | 1 + 1 file changed, 1 insertion(+) create mode 100644 patchtest diff --git a/patchtest b/patchtest new file mode 100644 index 00..484c9224ab --- /dev/null +++ b

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

2020-08-26 Thread Joseph Hemann
gcc_version returned by compiler is a string, and needs to be converted to a integer before testing Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Cc: Samer El-Haj-Mahmoud Signed-off-by: Joseph Hemann Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26 --- uefi