Re: [edk2-devel] MinPlatformPkg question

2023-01-31 Thread Kirkendall, Garrett via groups.io
AMD> | Twitter<https://twitter.com/AMD> | amd.com<http://www.amd.com/> [cid:image001.png@01D93576.B3AD9190] Words to live by: "Slow is Smooth. Smooth is Fast." From: Pedro Falcato Sent: Tuesday, January 31, 2023 12:58 PM To: devel@edk2.groups.io; Kirkendall, Garre

Re: [edk2-devel] MinPlatformPkg question

2023-01-31 Thread Kirkendall, Garrett via groups.io
[cid:image001.png@01D93562.64340C20] Words to live by: "Slow is Smooth. Smooth is Fast." From: Oram, Isaac W Sent: Thursday, January 12, 2023 3:44 PM To: Kirkendall, Garrett ; devel@edk2.groups.io; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric ; Bobroff, Zachary ; Z

[edk2-devel] MinPlatformPkg question

2023-01-12 Thread Kirkendall, Garrett via groups.io
[Public] + MinPlatformPkg Maintainers Start the conversation: Some time back there were posts about promoting MinPlatformPkg up to a more generic level. Is there still a desire to implement this and possibly even to promote this more generic MinPlatformPkg to the edk2 repository. Would it be

[edk2-devel] MinPlatformPkg question

2023-01-09 Thread Kirkendall, Garrett via groups.io
[AMD Official Use Only - General] Start the conversation: Some time back there were posts about promoting MinPlatformPkg up to a more generic level. Is there still a desire to implement this and possibly even to promote this more generic MinPlatformPkg to the edk2 repository. Would it be

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-19 Thread Kirkendall, Garrett
Any traction on this patch? Thank you Liming Gao for your quick response. GARRETT KIRKENDALL SMTS Firmware Engineer 7171 Southwest Parkway, Austin, TX 78735 USA AMD   facebook  |  amd.com > -Original Message- > From: gaoliming > Sent: Sunday, May 16, 2021 3:10 AM > To

[edk2-devel] [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-14 Thread Kirkendall, Garrett
When build.by POSTBUILD handling section returns other than 0, set ReturnCode to POSTBUILD_ERROR so build.py exits with return code other than 0. Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977 Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Garrett Kirkendall ---

[edk2-devel] [PATCH v1 0/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-14 Thread Kirkendall, Garrett
When build.by POSTBUILD handling section returns other than 0, set ReturnCode to POSTBUILD_ERROR so build.py exits with return code other than 0. Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977 Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Garrett Kirkendall (1): BaseTools: build:

[edk2-devel] DSC POSTBUILD problem/question

2021-05-10 Thread Kirkendall, Garrett
I'm checking out the PREBUILD and POSTBUILD option in a DSC. I can launch my scripts, etc. When there is a POSTBUILD error, build.py properly says the build failed, but build.py is still returning 0 (success). MyBuild.LaunchPostBuild() execution does not look like it affects ReturnCode

[edk2-devel] DMARC

2021-05-05 Thread Kirkendall, Garrett
DMARC is rearing its head at my company soon. I just wanted to check if you think this group is DMARC compatible with the requirements being imposed. IT requested some email examples from me recently and then I got a blanket email today stating they were going to start blocking emails. Below

Re: [edk2-devel] EDK2

2021-02-05 Thread Kirkendall, Garrett
st Parkway, Austin, TX 78735 USA AMD facebook<https://www.facebook.com/AMD> | amd.com<http://www.amd.com/> From: Kinney, Michael D Sent: Friday, February 5, 2021 11:03 AM To: Kirkendall, Garrett ; devel@edk2.groups.io; Feng, Bob C ; Andrew Fish ; Kinney, Michael D Cc: Pham, Tony Q Su

Re: [edk2-devel] EDK2

2021-02-05 Thread Kirkendall, Garrett
[AMD Official Use Only - Internal Distribution Only] 0x9d is one of those pesky "smart quotes" many applications love to use. These are the double quote or single quote characters that slant left and right instead of the straight up and down like the ASCII versions. They can be very hard to

Re: [edk2-devel] [RFC] Request to move MinPlatformPkg out of the Intel folder

2020-10-01 Thread Kirkendall, Garrett
haniel L > Sent: Wednesday, September 30, 2020 6:17 PM > To: devel@edk2.groups.io; r...@edk2.groups.io > Cc: Leif Lindholm ; Laszlo Ersek ; > Ard Biesheuvel ; Kirkendall, Garrett > ; Lendacky, Thomas > ; thomas.abra...@arm.com; > frank@dell.com; Jim Dailey ; Abner Ch

Re: [edk2-devel] EDK2 Specs PDF links don't work.

2020-08-19 Thread Kirkendall, Garrett
I'll second the request for an offline option Garrett Kirkendall SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA AMD facebook | amd.com From: devel@edk2.groups.io On Behalf Of Michael D Kinney via groups.io Sent:

Re: [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE

2020-06-23 Thread Kirkendall, Garrett
[AMD Public Use] Is there anything else needed from me for this patch at this time? GARRETT KIRKENDALL SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA AMD   facebook  |  amd.com -Original Message- From: devel@edk2.groups.io On Behalf Of Kirkendall, Garrett

[edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

2020-06-22 Thread Kirkendall, Garrett
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using

[edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE

2020-06-22 Thread Kirkendall, Garrett
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

[edk2-devel] [PATCH v6 2/4] SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass

2020-06-22 Thread Kirkendall, Garrett
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, SourceLevelDebugPkg/SourceLevelDebugPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be

[edk2-devel] [PATCH v6 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

2020-06-22 Thread Kirkendall, Garrett
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v6 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

2020-06-22 Thread Kirkendall, Garrett
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v5 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

2020-06-19 Thread Kirkendall, Garrett
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using

[edk2-devel] [PATCH v5 2/4] SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass

2020-06-19 Thread Kirkendall, Garrett
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, SourceLevelDebugPkg/SourceLevelDebugPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be

[edk2-devel] [PATCH v5 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

2020-06-19 Thread Kirkendall, Garrett
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v5 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

2020-06-19 Thread Kirkendall, Garrett
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v5 0/4] AMD processor MSR_IA32_MISC_ENABLE

2020-06-19 Thread Kirkendall, Garrett
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

[edk2-devel] [PATCH v4 3/3] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

2020-06-19 Thread Kirkendall, Garrett
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v4 0/3] AMD processor MSR_IA32_MISC_ENABLE

2020-06-19 Thread Kirkendall, Garrett
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

[edk2-devel] [PATCH v4 2/3] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

2020-06-19 Thread Kirkendall, Garrett
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v4 1/3] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

2020-06-19 Thread Kirkendall, Garrett
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using

[edk2-devel] [PATCH v2 0/2] AMD procesor MSR_IA32_MISC_ENABLE

2020-06-18 Thread Kirkendall, Garrett
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. First, to distinguish between AMD and other

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

2020-06-18 Thread Kirkendall, Garrett
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

2020-06-18 Thread Kirkendall, Garrett
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v1 2/2] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

2020-06-15 Thread Kirkendall, Garrett
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, and if the processor is an AMD processor skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

2020-06-15 Thread Kirkendall, Garrett
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v1 0/2] UefiCpuPkg: AMD procesor MSR_IA32_MISC_ENABLE

2020-06-15 Thread Kirkendall, Garrett
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. First, to distinguish between AMD and other

[edk2-devel] Method to identify processor manufacturer: WAS: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-11 Thread Kirkendall, Garrett
, Austin, TX 78735 USA AMD facebook<https://www.facebook.com/AMD> | amd.com<http://www.amd.com/> From: Dong, Eric Sent: Thursday, June 11, 2020 2:07 AM To: Ni, Ray ; devel@edk2.groups.io; Kirkendall, Garrett Cc: Laszlo Ersek Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatureIs

[edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-10 Thread Kirkendall, Garrett
[AMD Public Use] There are currently three instances of StandardSignatureIsAuthenticAMD Function in the below locations. I need to propose another change that will require the same function in PiSmmCpuDxeSmm. I would like to see this function move to a single "LibraryClass" location. I

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
See below -Original Message- From: Kinney, Michael D Sent: Tuesday, May 28, 2019 12:07 PM To: Kirkendall, Garrett ; devel@edk2.groups.io; Wu, Hao A ; Kinney, Michael D Cc: Ni, Ray ; Andrew Fish ; Laszlo Ersek ; Leif Lindholm Subject: RE: Linux Kernel soft hangs if 8259 PIC

Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
Since this change will be removing the 8259 PIC driver, I'll mention a quirk I ran into in the Linux Kernel up through at least 5.0 (and I am sure later, I just didn't verify): Does anyone have pull in the Linux Kernel world to get them to take this seriously? Hopefully someday soon end users