gt;
> Thanks,
>
> Mike
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Wednesday, January 4, 2023 7:13 AM
>> To: devel@edk2.groups.io
>> Cc: Ard Biesheuvel ; Brijesh Singh
>> ; Aktas, Erdem ; Gerd
>>
On 1/5/23 14:52, Gerd Hoffmann wrote:
> On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote:
>> Quoting Gerd Hoffmann (2023-01-05 14:12:22)
>>> Not sure this is an option. Is nested virtualization supported in azure
>>> pipeline VMs? If so, is /dev/kvm passed into containers?
>>
>> I
On 1/5/23 14:15, Gerd Hoffmann wrote:
> On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote:
>> From: Min M Xu
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237
>>
>> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in
>> AcpiPlatformDxe. See the detailed information in
MU_ACPI_TABLE_NOTIFY_PROTOCOL with a NULL associated
>interface.
>
> Above changes 2/4/5 are applied in both CloudHvAcpi.c and QemuFwCfgAcpi.c.
>
> Cc: Laszlo Ersek
> Cc: Erdem Aktas
> Cc: James Bottomley
> Cc: Jiewen Yao
> Cc: Gerd Hoffmann
> Cc: Tom Len
f
Cc: Tom Lendacky
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/PlatformInitLib/Platform.c | 34
1 file changed, 34 insertions(+)
diff --git a/OvmfPkg/Library/PlatformInitLib/Platform.c
b/OvmfPkg/Library/Platf
w
distro packages are picked up by github.com CI.
Suggestions?
Thanks,
Laszlo
Cc: Ard Biesheuvel
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Min Xu
Cc: Sebastien Boeuf
Cc: Tom Lendacky
Laszlo Ersek (1):
OvmfPkg/
On 1/4/23 10:46, Ard Biesheuvel wrote:
> On Tue, 3 Jan 2023 at 16:03, Laszlo Ersek wrote:
>>
>> Repo: https://pagure.io/lersek/edk2.git
>> Branch: smorgasboard
>>
>> Round-up series of small patches, for the BZs noted in the subject.
>>
>> Success
d Hoffmann
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Rahul Kumar
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 13e1335a57dd..3399981bbae7 100644
--- a/Maintainers.txt
+++ b/Maintainers.
Cc: Julien Grall
Cc: Min Xu
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sebastien Boeuf
Cc: Tom Lendacky
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4236
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.fdf| 6 +++---
OvmfPkg/OvmfPkgIa32X64.fdf | 6 +++---
OvmfPkg/OvmfPkgX64.fdf
kg/SmmCpuFeaturesLib as
well.
Testing: OVMF builds, boots, and suspends/resumes (see earlier in this
series).
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4235
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Libra
kg/SmmCpuFeaturesLib
as well.
Build-tested with:
build -a IA32 -a X64 -b NOOPT -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
Cc: Eric Dong
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Cc: Ray Ni
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4235
Signed-off-by: Laszlo Ersek
---
UefiCpuPkg/Libra
emove the delimiter.
Tested by enabling DEBUG in "VbeShim.asm", running the script, building
OVMF, booting Windows 7, and checking the firmware log (debug console).
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_b
Ray Ni
Cc: Rebecca Cran
Cc: Sebastien Boeuf
Cc: Tom Lendacky
Laszlo Ersek (4):
OvmfPkg/QemuVideoDxe/VbeShim.sh: remove end-of-options delimiter for
nasm
OvmfPkg: raise DXEFV size to 13 MB in the traditional platform FDFs
UefiCpuPkg/SmmCpuFeaturesLib: drop obsolete API implemen
s gets
> merged? It would be good to have the regression bug fixed.
>
> Thanks,
>
> Michael
>
series
Acked-by: Laszlo Ersek
Ard, can you please help merge this?
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Rep
On 11/06/22 02:19, Yao, Jiewen wrote:
> Acked-by: Jiewen Yao
Thanks for the ACKs; Jiewen, can you please merge the patch?
Thanks
Laszlo
>
>> -Original Message-
>> From: Kinney, Michael D
>> Sent: Friday, November 4, 2022 11:29 PM
>> To: Laszlo Ersek
omin Jiang
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Michael D Kinney
Cc: Xiaoyu Lu
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- URL:
https://pagure.io/lersek/edk2/c/8d7b26bfb6a1?branch=cryptopkg_readme_typos_v2
- v1 was at:
-
https://listman.redhat.com/archive
Hi Mike,
On 11/02/22 17:48, Kinney, Michael D wrote:
> Hi Laszlo,
>
> Thank you for all the updates. One comment below.
>
> Mike
>
>> -Original Message-----
>> From: Laszlo Ersek
>> Sent: Wednesday, November 2, 2022 2:37 AM
>> To: devel@edk2.g
omin Jiang
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Michael D Kinney
Cc: Xiaoyu Lu
Signed-off-by: Laszlo Ersek
---
Notes:
Best displayed as a word-diff for review, for example with the command
git show --word-diff
or on the web at
https://pagure.io/lersek/edk2/c
On 04/07/22 12:49, Laszlo Ersek wrote:
> On the NUC, this whole child controller chain, and protocol stack,
> breaks down because there is no SerialIo protocol interface in the
> protocol db. The following command returns nothing, even after "connect
> -r":
>
>&
On 10/05/22 07:01, Gerd Hoffmann wrote:
> On Tue, Oct 04, 2022 at 05:57:46PM +0200, Laszlo Ersek wrote:
>> On 10/04/22 15:47, Gerd Hoffmann wrote:
>>> In case the 64-bit pci mmio window is larger than the default size
>>> of 32G be generous and hand out lar
On 10/04/22 15:47, Gerd Hoffmann wrote:
> In case the 64-bit pci mmio window is larger than the default size
> of 32G be generous and hand out larger chunks of address space for
> prefetchable mmio bridge windows.
>
> Cc: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
work
>> component overrides
>> - add Laszlo's ack to patch #1
>>
>> Changes since v1:
>> - instead of a NULL class library that calls the Exit() boot service
>> from its constructor, use a replacement for the UefiDriverEntryPoint
>> library
>>
On 08/22/22 18:59, Ard Biesheuvel wrote:
> On Thu, 18 Aug 2022 at 07:58, Laszlo Ersek wrote:
>>
>> On 08/17/22 17:11, Ard Biesheuvel wrote:
>>> Add a new library that can be incorporated into any driver built from
>>> source, and which permits loading of
On 08/17/22 17:11, Ard Biesheuvel wrote:
> Wire up the newly added UefiDriverEntrypoint in a way that ties dispatch
> of the Ip4Dxe and Ip6Dxe drivers to QEMU fw_cfg variables
> 'opt/org.tianocore/IPv4Support' and 'opt/org.tianocore/IPv6Support'
> respectively.
>
> Setting both variables to 'n'
Table);
> + }
Right, I think this is the way to do it -- we've constructed all the lib
instances, so now we can rely on PCDs and QemuFwCfg.
I'm OK with this version, just one idea: in order to avoid the code
duplication (and to benefit from future improvements to the original
entry
On 08/17/22 10:39, Ard Biesheuvel wrote:
> Agree with all of the above. At this point, I think the only way to do
> this properly is to create an alternative UefiDriverEntrypoint library
> with the fw_cfg check folded into it. This is easy to do and addresses
> all the concerns raised here (as it
On 08/16/22 23:08, Brian J. Johnson wrote:
> On 8/16/22 07:30, Laszlo Ersek wrote:
>> On physical machines, I've seen firmware options for disabling the IP
>> stack entirely; I wonder how those firmwares do it...
>
> I don't know how any physical machine handles that particu
On 08/15/22 11:40, Ard Biesheuvel wrote:
> Add a new library that can be incorporated into any driver built from
> source, and which permits loading of the driver to be inhibited based on
> the value of a QEMU fw_cfg boolean variable. This will be used in a
> subsequent patch to allow dispatch of
On 08/04/22 11:58, Ard Biesheuvel wrote:
> On Thu, 4 Aug 2022 at 07:55, Laszlo Ersek wrote:
>>
>> On 08/04/22 04:52, Yuan Yu wrote:
>>> Currently networking can only be enabled/disabled at compile time. This
>>> patch series will add support to d
surface without recompilation.
>
> The changes can be seen at:
> https://github.com/yyu/edk2/tree/network_cfg_lib_v1
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Anthony Perard
> Cc: Julien Grall
>
> Yuan Yu (2):
> OvmfPkg: Introdu
2022-04-02) copied the wrong setting when creating
"OvmfPkg/IntelTdx/IntelTdxX64.dsc".
(Obviously it needs no repost.)
> Reported-by: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +-
> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2
021 at 10:36:49AM +0200, Laszlo Ersek wrote:
>> Anthony, Julien,
>>
>> (or anyone else subscribed to xen-devel -- CC'd now),
>>
>> On 05/26/21 22:14, Laszlo Ersek wrote:
>>> Bugzilla: bugzilla.tianocore.org/show_bug.cgi?id=2122
>>> Repo: pagure
nk you
>
> -Manic
>
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, April 8, 2022 5:20 AM
> To: Manickavasakam Karpagavinayagam ; Gerd Hoffmann
> ; Srini Narayana ; KarenLee [李致瑤]
> ; Harikrishna Doppalapudi
> Cc: devel@edk2.groups.io; Ramesh R. ; S
On 04/08/22 11:48, Gerd Hoffmann wrote:
>
> Hi,
>
>> And It Just Works (TM), with the following two commands in the UEFI
>> shell (after I copied the binaries to the USB stick, alongside the UEFI
>> Shell binary I built earlier):
>>
>>> Shell> fs0:
>>> FS0:\> cd efi\boot
>>> FS0:\efi\boot\>
On 04/08/22 00:16, Desimone, Nathaniel L wrote:
> Hi Laszlo,
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo
>> Ersek
>> Sent: Thursday, April 7, 2022 12:46 AM
>> To: edk2-devel-groups-io
>> Cc: r, ramesh ; Sivaraman Na
small patch at the bottom (adding "NucSerialPkg",
just for the sake of buildig SerialDxe and TerminalDxe in separation)
applies on top of current master.
Thanks
Laszlo
>
> Thank you
>
> -Manic
>
> -----Original Message-
> From: Laszlo Ersek
> Sent: Thursd
baud-rate=115200, 8 data bits,
no parity, 1 stop bit.
That gave me the following idea:
> commit 0e794fe273b77830532ffb003b0d5539d7ae9823 (HEAD -> nuc_serial_pkg)
> Author: Laszlo Ersek
> Date: Thu Apr 7 14:37:13 2022 +0200
>
> add NucSerialPkg: build SerialDxe and TerminalDxe
On 04/07/22 10:00, Gerd Hoffmann wrote:
> Hi,
>
>> However, the UEFI platform firmware seems to have no support for
>> Serial I/O. I've built a fresh UEFI Shell binary from edk2 master and
>> poked around in the protocol database, with "drivers" and "dh". The
>> necessary drivers seem to be
Hi List,
my toolbox has been extended with an Intel NUC, the base kit model being
NUC8i3PNH. The NUC has a serial port connector on the back, and indeed
Serial I/O works fine once an OS starts.
However, the UEFI platform firmware seems to have no support for Serial
I/O. I've built a fresh UEFI
e Uncrustify changes applied to the files in commit
> ac0a286f4d74.
> 2. Uses a new UncrustifyCheck CI plugin configuration option to
> exclude the files from future formatting checks.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc:
Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc: Rebecca Cran
> Cc: Peter Grehan
> Cc: Laszlo Ersek
> Signed-off-by: Michael Kubacki
> ---
> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h | 1811 ++--
> OvmfPkg/QemuVideoDxe/VbeShim.h | 1389 ---
> 2 fi
Hi Mike,
On 07/08/21 21:50, Michael D Kinney wrote:
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt | 282
> 1 file changed, 139 insertions(+), 143 deletio
On 07/09/21 09:42, Ard Biesheuvel wrote:
> On Thu, 8 Jul 2021 at 09:09, Laszlo Ersek wrote:
>>
>> I'm relinquishing all my roles listed in "Maintainers.txt", for personal
>> reasons.
>>
>> My email address remains functional.
>>
>> To my
Hi Mike,
On 07/08/21 05:46, Michael D Kinney wrote:
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt | 286
> 1 file changed, 143 insertions(+), 143 deletio
c Dong
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Philippe Mathieu-Daudé
Cc: Rahul Kumar
Cc: Ray Ni
Cc: Sami Mujawar
Signed-off-by: Laszlo Ersek
---
Maintainers.txt | 4
1 file changed, 4 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index f4e4c72d0628..e9
ged due to conflict. Please rebase and
> resubmit
>
>
> Let me know if this process of using personal builds and setting 'push' label
> if PR is 'up-to-date' is acceptable. I have tested this process with a few
> different scenarios in the edk2-codereview repo, and they all worked
On 07/06/21 11:53, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude
>
> The Print service driver is not used by OVMF, remove it.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Brijesh Singh
> Cc: Erdem Aktas
> Cc: James Bot
On 07/06/21 11:49, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude
>
> The "Shell Embedded Boot Loader" description (added in
> commit 6f5872b1f401) does not add any value, remove it.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
On 07/05/21 11:36, Neal Gompa wrote:
> Per UEFI Spec 2.8 (UEFI_Spec_2_8_final.pdf, page 114)
> 5.2.3 Protective MBR
> Table 20. Protective MBR Partition Record protecting the entire disk
>
> The description for BootIndicator states the following:
>
>> Set to 0x00 to indicate a non-bootable
On 07/05/21 13:08, Corvin Köhne wrote:
> An USB driver is required to use a keyboard or mouse while installing
> an OS or while in a bootloader menu like grub when using GPU + USB
> Passthrough.
>
> Reviewed-by: Peter Grehan
> Acked-by: Rebecca Cran
> Signed-off-by: Corvin Köhne
> ---
>
ARTITION &&
> +if (ProtectiveMbr->Partition[Index].OSIndicator == PMBR_GPT_PARTITION &&
> UNPACK_UINT32 (ProtectiveMbr->Partition[Index].StartingLBA) == 1
> ) {
>break;
>
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Lin
On 07/01/21 14:01, Corvin Köhne wrote:
> It's neccessary to allocate a Graphics Stolen Memory area to enable
> GPU-Passthrough for integrated Intel GPUs. Therefore, use a new
> memory layout with a static Pci32Baseaddress.
>
> Old layout:
> [..., lowmemlimit] RAM
>
On 07/01/21 20:10, Ethin Probst wrote:
> The first: I don't know how to retrieve the descriptors on the UEFI
> API. I've looked at the Chaos Key DXE, if memory serves, or the
> display port one -- one of the two. One of them contained a
> ReadDescriptor() function, and so I've borrowed that, but
On 07/01/21 01:01, Ethin Probst wrote:
> Hi all,
> So Leif and I have been working on USB Audio but we've run into a snag. We've
> encountered a problem -- neither of us knows enough about USB to figure out
> how to get the class-specific AC interface descriptors, and those contain
> vital
; !if $(SECURE_BOOT_ENABLE) == TRUE
>PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
tVariableLib.inf
>
># re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
>PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this g
com/tianocore/edk2/pull/1780>.
Laszlo
>
> On 29-Jun-21 18:33, Laszlo Ersek wrote:
>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
>> Repo: https://pagure.io/lersek/edk2.git
>> Branch: iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
>> CI
Hi Eric, Mike, Ray,
with "master" being at commit 3cde0d553d93, please consider the
CollectBistDataFromPpi() function in "UefiCpuPkg/CpuMpPei/CpuBist.c":
> /**
> Collects BIST data from PPI.
>
> This function collects BIST data from Sec Platform Information2 PPI
> or SEC Platform
On 06/30/21 14:34, Grzegorz Bernacki wrote:
> The edk2 patch
> SecurityPkg: Create library for setting Secure Boot variables.
>
> removes generic functions from SecureBootConfigDxe and places
> them into SecureBootVariableLib. This patch adds SecureBootVariableLib
> mapping for ArmVirtPkg
On 06/30/21 08:36, Ni, Ray wrote:
> Can you explain why VERBOSE is chosen instead of INFO?
I agree it should be documented in the commit message. One good reason
is if there are many messages, as logging lots of messages is costly (it
slows down booting).
Thanks
Laszlo
>
> Thanks,
> Ray
>
>
On 06/30/21 11:11, Ashish Kalra via groups.io wrote:
> Hello Laszlo,
>
> On Wed, Jun 23, 2021 at 06:49:06PM +0200, Laszlo Ersek wrote:
>> On 06/23/21 18:42, Laszlo Ersek wrote:
>>> On 06/22/21 19:46, Ashish Kalra wrote:
>>
>>>> Please fin
(and session) if the target doesn't
support SHA256.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
Reviewed-by: Maciej Rabeda
Reviewed-by: Philippe Mathieu-Daudé
---
Notes:
v2
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Maciej Rabeda
---
Notes:
v2:
- pick up R-b's [Phil, Maciej]
NetworkPkg/IScsiDxe/IScsiCHAP.h | 3 ++-
NetworkPkg/IScsiDxe/IScsiC
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
---
Notes:
v2:
- Strictly stick with the edk2 coding style, in the multi-line calls to
the CompareMem(), IScsiGenRandom(), and AsciiSPrint() func
uot; field as well.
This patch is functionally a no-op, just yet.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Maciej Rabeda
---
Not
iConnLogin() function.
Right now, do nothing in IScsiSessionResetAuthData(); so functionally
speaking, the patch is a no-op.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
Revie
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Maciej Rabeda
---
Notes:
v2:
- pick up R-b's [Phil, Maciej]
NetworkPkg/IScsiDxe/IScsiC
Please see the Notes section on
every patch.
v2 has been retested, with results identical to those of v1. (Please see
the v1 blurb for details.)
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Thanks,
Laszlo
Laszlo Ersek (6):
NetworkPkg/IScsiDxe: re-set session
On 06/10/21 06:56, Nickle Wang wrote:
> Memory buffer that is allocated by malloc() and realloc() will be
> shifted by 8 bytes because Oniguruma keeps its memory signature. This 8
> bytes shift is not handled while calling free() to release memory. Add
> free() function to check Oniguruma
On 06/29/21 13:41, Jan Beulich via groups.io wrote:
> On 29.06.2021 13:29, Laszlo Ersek wrote:
>> On 06/29/21 12:35, Andrew Cooper wrote:
>>> On 29/06/2021 11:07, Jan Beulich wrote:
>>>> On 29.06.2021 11:20, Laszlo Ersek wrote:
>>>>> On 06/28
On 06/29/21 15:03, Dov Murik wrote:
> Out of curiousity, I wonder regarding the leak fixes -- is there a way
> to see that the fix works? Is there some accounting of used pages that
> we can check that decreases after the fix?
You could try a UEFI memmap comparison, but the cmdline is a pool
> - Organize #include and .inf
> - Add UINTN overflow check
> - Fix error paths and function epilogue to properly release all resources
> - Clarity: rename long variables, reword comments
>
> v2: https://edk2.groups.io/g/devel/message/76664
> v2 changes:
> - Add com
On 06/29/21 12:35, Andrew Cooper wrote:
> On 29/06/2021 11:07, Jan Beulich wrote:
>> On 29.06.2021 11:20, Laszlo Ersek wrote:
>>> On 06/28/21 15:23, Anthony PERARD via groups.io wrote:
>>>> From: Anthony PERARD
>>>>
>>>> Unfortun
003a6 ("OvmfPkg: implement QEMU loader
> library for X86 with legacy fallback", 2020-03-05).
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Reported-by: Laszlo Ersek
> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d
On 06/28/21 12:51, Dov Murik wrote:
> Remove the QemuFwCfgLib interface used to read the QEMU cmdline
> (-append argument) and the initrd size. Instead, use the synthetic
> filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd",
> and "cmdli
thetic filesystem, we also revert back to AllocatePool instead of
> AllocatePages.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
> Signe
b0026 ("OvmfPkg: provide a generic
> implementation of QemuLoadImageLib", 2020-03-05).
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Reported-by: Laszlo Ersek
> Fixes: ddd2be6b0026abcd0f819b3915fc80c3de81
On 06/28/21 12:51, Dov Murik wrote:
> Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
> ground to add a warning about the incompatibility with boot verification
> process.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Jame
On 06/28/21 12:51, Dov Murik wrote:
> Remove the QemuFwCfgLib interface used to read the QEMU cmdline
> (-append argument) and the initrd size. Instead, use the synthetic
> filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd",
> and "cmdli
thetic filesystem, we also revert back to AllocatePool instead of
> AllocatePages.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
> Signe
003a6 ("OvmfPkg: implement QEMU loader
> library for X86 with legacy fallback", 2020-03-05).
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Reported-by: Laszlo Ersek
> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d
b0026 ("OvmfPkg: provide a generic
> implementation of QemuLoadImageLib", 2020-03-05).
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Reported-by: Laszlo Ersek
> Fixes: ddd2be6b0026abcd0f819b3915fc80c3de81
t; + SharedInfo = (VOID*)((UINTN)PcdGet32 (PcdCpuLocalApicBaseAddress) +
> SIZE_1MB);
>Status = PhysicalAddressIdentityMapping ((EFI_PHYSICAL_ADDRESS)SharedInfo);
>if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR,
>
Acked-by: Laszlo Ersek
I guess I should merge this after Jan and/or And
On 06/29/21 08:08, Lange Tang wrote:
> hi gaoliming:
> I'm glad to hear from you！
> I want to build ArmVirtPkg to get QEMU_EFI.fd firmware to support videoo
> qxl.
> The following two files have been modified:
> 1. ArmVirtPkg/ArmVirtQemu.dsc
> 2. ArmVirtPkg/ArmVirtQemu.fdf
n
>> reading the C code and the fact that sizeof() does not produce the
>> expected
>> result make it even worse.
>>
>> If we use flexible array members in this proposed change then there is
>> no need to use OFFSET_OF(). Correct?
>>
>> Mike
>>
Hi Maciej,
[snipping liberally, comments below]
On 06/25/21 16:56, Rabeda, Maciej wrote:
> On 22-Jun-21 17:57, Laszlo Ersek wrote:
>> On 06/11/21 13:54, Rabeda, Maciej wrote:
>>> On 08-Jun-21 15:06, Laszlo Ersek wrote:
>>>> +typedef struct {
>>>&g
ditional PR and review the manual rebase to make sure there are no
> unintended
> side effects.
Sounds great, thank you!
Laszlo
>
> Any objections to this direction?
>
> Thanks,
>
> Mike
>
>> -Original Message-
>> From: devel@edk2.groups.io O
On 06/17/21 14:17, Dov Murik wrote:
> Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
> ground to add a warning about the incompatibility with boot verification
> process.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Jame
Hi Dov,
On 06/17/21 14:16, Dov Murik wrote:
> Remove the QemuFwCfgLib interface used to read the QEMU cmdline
> (-append argument) and the initrd size. Instead, use the synthetic
> filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd",
> and
thetic filesystem, we also revert back to AllocatePool instead of
> AllocatePages.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: James Bottomley
> Cc: Tobin Feldman-Fitzthum
> Signed-off-by: Dov Murik
> ---
> OvmfPkg/QemuKernelLoaderFsDxe
On 06/24/21 14:59, Laszlo Ersek wrote:
> On 06/23/21 16:06, PierreGondois wrote:
>> From: Sami Mujawar
>>
>> Acpiview is a command line tool allowing to display, dump, or
>> check installed ACPI tables. Add the tool to ArmVirt platforms.
>>
>> Signed-off-by:
On 06/23/21 16:06, PierreGondois wrote:
> Pierre Gondois (1):
> ArmVirtPkg: Add cspell exceptions
>
> Sami Mujawar (4):
> ArmVirtPkg: Add DSDT ACPI table for Kvmtool firmware
> ArmVirtPkg: Add Configuration Manager for Kvmtool firmware
> ArmVirtPkg: Enable ACPI support for Kvmtool
>
= TRUE
to "ArmVirtPkg/ArmVirtKvmTool.dsc", and in "ArmVirtPkg/ArmVirt.dsc.inc",
include the new command lib conditionally on ACPIVIEW_ENABLE being TRUE.
(Can be in the same patch.)
Acked-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: Yo
g/Virtio10Dxe/Virtio10.inf
>
> + #
> + # ACPI Support
> + #
> + INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> + #
> + # Dynamic Table fdf
> + #
> + !include DynamicTablesPkg/DynamicTables.fdf.inc
> +
> + INF ArmVirtPkg/KvmtoolCfgMgr
On 06/23/21 16:06, PierreGondois wrote:
> diff --git a/ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf
> b/ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManagerDxe.inf
> new file mode 100644
> index ..9f0bf72fce2d
> --- /dev/null
> +++
DKII_CONFIGURATION_MANAGER_PROTOCOL * CONST This,
> + IN CONST CM_OBJECT_ID CmObjectId,
> + IN CONST CM_OBJECT_TOKEN Token,
> + IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
> + );
> +
> +/** A
On 06/23/21 16:06, PierreGondois wrote:
> From: Pierre Gondois
>
> Kvmtool dynamically generates a device tree describing the platform
> to boot on. Using the patch-sets listed below, the DynamicTables
> framework generates ACPI tables describing a similar platform.
>
> This patch-set:
> -
priate SSDTs.
> +// Although there may not be much to describe
> +// in the DSDT, the DSDT table is mandatory.
> +// Therefore, add an empty stub for DSDT.
> + } // Scope (_SB)
> +}
>
Please insert empty // lines at the top and bottom of the comment block,
to stick
quot;,
> "OvmfPkg/OvmfPkg.dec",
> @@ -97,6 +98,8 @@
> "AuditOnly": False, # Fails right now with over 270 errors
> "IgnoreFiles": [], # use gitignore syntax to ignore errors
> in matching files
>
On 06/12/21 22:43, Rebecca Cran wrote:
> TPM support hasn't been tested and any lines in the .dsc and .fdf files
> that appear to show support are bogus. Remove them.
>
> This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 .
>
> Signed-off-by: Rebecca Cran
> ---
>
901 - 1000 of 4300 matches
Mail list logo
