[edk2-devel] [PATCH v4] BaseTools/Capsule: Support signtool input subject name to sign capsule file

2022-07-25 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

[edk2-devel] [PATCH v4] BaseTools/Capsule: Support signtool input subject name to sign capsule file

2022-07-25 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

[edk2-devel] [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0

2022-07-12 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3988 With the change #3958 using the incorrect variable to store the S-ACM entry version. That would cause the value always 0x0. gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Version variable should be correct

[edk2-devel] [PATCH v3] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

2022-07-08 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922 [Description] CheckOverlap function would do incorrect split on the BiosModule which not happen overlap. This would cause incorrect value locate in FIT entry record. [Condition] - This BiosModule base address is lower th

[edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-08 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

[edk2-devel] [PATCH v2] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-08 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

[edk2-devel] [PATCH v3 3/3] [edk2-platforms] Silicon/Intel/FitGen: Support Startup ACM entries (Type 2) 0x200 Version

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes) / reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. This change is used

[edk2-devel] [PATCH v3 2/3] [edk2-platforms] Silicon/Intel/FitGen: Reduce the typecasting and pointer usage

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 FitGen tool exists lots of typecasting and pointer usage. This code change is used to reduce these in FillFitTable () and GetFitEntryInfo (). To make code more clearly and easy to read. Signed-off-by: Jason1 Lin Cc: Bob

[edk2-devel] [PATCH v3 1/3] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-07-01 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Limin

[edk2-devel] [PATCH v2 2/2] [edk2-platforms] Silicon/Intel/FitGen: Support to override the MBZ byte in Startup ACM entries for other usages

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes)/ reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. In the future, if th

[edk2-devel] [PATCH v2 1/2] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Limin

[edk2-devel] [PATCH v1 1/2] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Limin

[edk2-devel] [PATCH v1 2/2] [edk2-platforms] Silicon/Intel/FitGen: Support to override the MBZ byte in Startup ACM entries for other usages

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes)/ reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. In the future, if th

[edk2-devel] [PATCH v2] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

2022-06-06 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922 [Description] CheckOverlap function would do incorrect split on the BiosModule which not happen overlap. This would cause incorrect value locate in FIT entry record. [Condition] - This BiosModule base address is lower tha

Re: [edk2-devel] [PATCH v1] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

2022-06-06 Thread Lin, Jason1
Hi Bob, Agree. Check the size first is more readable than do the type conversion. That would be align with the address check. I would send out patch v2 based on this change. Thanks, Jason. -Original Message- From: Feng, Bob C Sent: Saturday, June 4, 2022 12:08 To: Lin, Jason1 ; devel