Hello EDK2 community,
The "Nvme-Fabrics-Boot" branch was created in edk2-staging repository.
Role of this branch is to upstream our NVMe-over-Fabrics boot prototype
created under Timberland SIG's umbrella to EDK2.
Link to branch:
https://github.com/tianocore/edk2-staging/tree/Nvme-Fabrics-Boo
aging/tree/HttpProxy
Base edk2 commit:
https://github.com/tianocore/edk2/commit/2c17d676e402d75a3a674499342f7ddaccf387bd
Relevant BZs:
https://bugzilla.tianocore.org/show_bug.cgi?id=3951
https://bugzilla.tianocore.org/show_bug.cgi?id=4052
Thanks,
Maciej Rabeda
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Thanks for the patch!
Reviewed-by: Maciej Rabeda
On 23 sie 2022 18:00, PierreGondois wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Maciej Rabeda
Signed-off-by: Pierre Gondois
---
NetworkPkg/DnsDxe/ComponentName.c
Thanks for the patch, Michael.
Reviewed-by: Maciej Rabeda
On 25 sie 2022 05:48, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Removes Status argument that is not needed from DEBUG macros.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Michael Kubacki
Change merged.
PR: https://github.com/tianocore/edk2/pull/3103
Commit:
https://github.com/tianocore/edk2/commit/671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d
On 19 lip 2022 17:46, Maciej Rabeda wrote:
Thank you for the patch.
Reviewed-by: Maciej Rabeda
On 19 lip 2022 15:54, Saloni Kasbekar
Thank you for the patch.
Reviewed-by: Maciej Rabeda
On 19 lip 2022 15:54, Saloni Kasbekar wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2504
Add support for TLS Client Authentication using Basic Authentication
for HTTP Boot
Cc: Maciej Rabeda
Cc: Wu Jiaxin
Cc: Siyuan Fu
Signed
Reviewed-by: Maciej Rabeda
On 24 cze 2022 09:59, Heng Luo wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=3961
Add below Wpa3 support:
WPA3-Personal:
Ieee80211AkmSuiteSAE= 8
WPA3-Enterprise:
Ieee80211AkmSuite8021XSuiteB= 11
from HTTPS
Proxy Server to EndPoint Server.
Add support to connect through proxy server using DevicePath
sent to the Boot Manager.
Cc: Maciej Rabeda
Cc: Wu Jiaxin
Cc: Siyuan Fu
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Saloni Kasbekar
---
.../Library/UefiBootManagerLib/BmBoot.c | 11 ++
MdeP
fix so I can integrate it.
Thanks,
Maciej
On 17 cze 2022 21:35, Saloni Kasbekar wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2504
Add support for TLS Client Authentication using Basic Authentication
for HTTP Boot
Cc: Maciej Rabeda
Cc: Wu Jiaxin
Cc: Siyuan Fu
Signed-off-by: Sal
For NetworkPkg part: Reviewed-by: Maciej Rabeda
On 22 maj 2022 03:54, yi1 li wrote:
To meet the needs of WPA3 Enterprise, additional cipher algorithms
and TLS APIs need to be added.
Code branch: https://github.com/liyi77/edk2/tree/Add-TLS
Details as follows:
- TlsShutdown: Shutdown the TLS
Patchset merged: https://github.com/tianocore/edk2/pull/2756
On 8 kwi 2022 11:07, Rabeda, Maciej wrote:
Alright.
Reviewed-by: Maciej Rabeda
Merge soon.
On 7 kwi 2022 14:55, Oliver Steffen wrote:
On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej
wrote:
1. In HttpResponseWorker():
if
Patch merged: https://github.com/tianocore/edk2/pull/2756
On 7 kwi 2022 13:54, Maciej Rabeda wrote:
Reviewed-by: Maciej Rabeda
On 6 kwi 2022 04:02, Heng Luo wrote:
Dear Maintainers,
Could you review the patch? All checks have passed the EDK2 CI build.
https://github.com/tianocore/edk2/pull
Alright.
Reviewed-by: Maciej Rabeda
Merge soon.
On 7 kwi 2022 14:55, Oliver Steffen wrote:
On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej
wrote:
1. In HttpResponseWorker():
if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen
("HTTP/1.0")) == 0) {
D
Hi Gerd,
Sorry, I can spare very little time for reviews these days...
I am alright with the patch with two cosmetic changes.
1. In HttpResponseWorker():
if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen
("HTTP/1.0")) == 0) {
DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0.
Reviewed-by: Maciej Rabeda
On 6 kwi 2022 04:02, Heng Luo wrote:
Dear Maintainers,
Could you review the patch? All checks have passed the EDK2 CI build.
https://github.com/tianocore/edk2/pull/2717
Thanks,
Heng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Heng Luo
Sent
Patch merged.
PR: https://github.com/tianocore/edk2/pull/2536
Commit:
https://github.com/tianocore/edk2/pull/2536/commits/18feb439545443e8a3488b82415023601d116fe4
W dniu 21-Feb-22 o 15:57, Maciej Rabeda pisze:
Hi Heng,
Thanks for the patch.
Reviewed-by: Maciej Rabeda
W dniu 26-Jan-22 o 06
Hi Heng,
Thanks for the patch.
Reviewed-by: Maciej Rabeda
W dniu 26-Jan-22 o 06:12, Heng Luo pisze:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3813
The size of buffer should be 3 CHAR16 for Null-terminated Unicode string.
The first char is the AKM/Cipher Suite number, the second
Reviewed-by: Maciej Rabeda
On 06-Dec-21 02:17, Michael D Kinney wrote:
Hello EDK II Maintainers,
A detailed evaluation of the DEBUG_CODE() formatting issue has been completed.
The reason DEBUG_CODE() is a challenge is that this looks like a macro from a
C parsing perspective, but the EDK II
Statement correction
On 30-Nov-21 11:09, Maciej Rabeda wrote:
Hi Kilian,
CdePkg *has not* been integrated into EDK2. It is simply in
edk2-staging, and that's a large difference.
As for "satisfies all my needs" - it does not for the reasons I have
previously outlined.
Reit
Hi Kilian,
CdePkg *has not* been integrated into EDK2. It is simply in
edk2-staging, and that's a large difference.
As for "satisfies all my needs" - it does not for the reasons I have
previously outlined.
Reiterating: unless Torito C library is not released as source code
under an EDK2-comp
Hi Kilian,
From my point of view, the main problem with adoption of CdePkg to EDK2
is that it relies on Torito C library.
1. Torito C library License
(https://github.com/KilianKegel/toro-C-Library/blob/master/LICENSE.md)
only allows for creating UEFI Shell applications.
* What about
Hey Mike,
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 01-Nov-21 22:37, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Michael Kubacki
Signed-off-by: Michael D
Changed commit title to: "NetworkPkg/HttpDxe: Enable wildcard host name
matching for HTTP+TLS."
Patch merged.
PR: https://github.com/tianocore/edk2/pull/2168
Commit:
https://github.com/tianocore/edk2/commit/6f9e83f757ed7c5c78d071f475b2e72d899c2aef
On 02-Nov-21 20:54, Maciej Rabeda
Reviewed-by: Maciej Rabeda
Mike,
Who is going to do the PR?
Thanks,
Maciej
On 03-Nov-21 04:05, Michael D Kinney wrote:
Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib
mapping.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel
Hi Vineel,
I will integrate the change to edk2 tomorrow.
For now:
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 02-Nov-21 19:57, Vineel Kovvuri via groups.io wrote:
Hi Folks,
Thanks for reviewing the patch. May I know what are the next steps to get it in
to edk2?
I have already updated the
Patch merged.
PR: https://github.com/tianocore/edk2/pull/2107
On 22-Oct-21 11:47, Maciej Rabeda wrote:
Thanks for the patch.
Reviewed-by: Maciej Rabeda
On 18-Oct-21 09:21, Lin, Gary (HPS OE-Linux) wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=3694
HttpBootCheckImageType() was using
Hi Vineel,
I do not have any problems with this patch. Before I merge, I would like
Jiaxin to look at it, since he has submitted that code.
Thanks,
Maciej
On 15-Oct-21 02:54, Vineel Kovvuri wrote:
The current UEFI implementation of HTTPS during its TLS configuration uses
EFI_TLS_VERIFY_FLAG_
Thanks for the patch.
Reviewed-by: Maciej Rabeda
On 18-Oct-21 09:21, Lin, Gary (HPS OE-Linux) wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=3694
HttpBootCheckImageType() was using the case-sensitive AsciiStrCmp() to
check the file extensions and this could reject the images with
Change merged: https://github.com/tianocore/edk2/pull/1840
On 28-Jul-21 15:50, Maciej Rabeda wrote:
Reviewed-by: Maciej Rabeda
On 28-Jul-21 13:58, Heng Luo wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496
Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg,
Send HTTP Events
Change merged: https://github.com/tianocore/edk2/pull/1840
Corrections applied:
1. NetworkPkg.dsc: [PdcsDynamic] -> [PdcsDynamicDefault]
2. NetworkPkg.dsc: PcdHttpTimeout -> PcdHttpIoTimeout
On 28-Jul-21 15:59, Maciej Rabeda wrote:
Reviewed-by: Maciej Rabeda
On 28-Jul-21 14:16, He
Naturally. Since it is there, why is it not used for brotli, openssl in
CryptoPkg or jansson in RedfishPkg?
On 28-Jul-21 17:34, Rebecca Cran wrote:
Are you aware of the edk2-libc project at
https://github.com/tianocore/edk2-libc ?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
Reviewed-by: Maciej Rabeda
On 28-Jul-21 14:16, Heng Luo wrote:
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507
HTTP boot has a default set forced timeout value of 5 seconds
for getting the recovery image from a remote source.
This change allows the HTTP
Reviewed-by: Maciej Rabeda
On 28-Jul-21 13:58, Heng Luo wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496
Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg,
Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL
when Dns/ConnectTcp/TlsConnectSession/InitSession
occurs.
Signed-off
Hi,
I have submitted a new edk2-staging branch named "StdLibPkg".
https://github.com/tianocore/edk2-staging/tree/StdLibPkg
Branch contains initial implementation of C standard library and
intrinsic library for UEFI to smoothen open-source submodule integration
(instead of implementing those fu
Hi Ken,
When calling Tcp4->Configure(), what is your
EFI_TCP4_CONFIG_DATA.AccessPoint.ActiveFlag value?
ActiveFlag should be set to FALSE and RemoteAddress set to zero in order
to accept connection requests from any address.
You should be able to double check the fields above by calling
Tcp4
Thanks, Laszlo. I really like moving the condition out of 'if' clause in
IScsiCHAPAuthTarget :)
For the patchset:
Reviewed-by: Maciej Rabeda
On 29-Jun-21 18:33, Laszlo Ersek wrote:
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Repo: https://pagure.io/lerse
Additionally, for claim that IPv4 does not do that, please provide
Wireshark trace, if available.
On 29-Jun-21 18:36, Maciej Rabeda wrote:
Hi guys,
Finally got some time to look into it.
Long story short, this smells like infrastructure problem.
SARR passes over 546/547 port pair. That is
Hi guys,
Finally got some time to look into it.
Long story short, this smells like infrastructure problem.
SARR passes over 546/547 port pair. That is between UEFI PXE client and
DHCP server (even if it is the same machine).
The next packet is essentially a Boot Server choice step. UEFI PXE
cl
n is a leading login).
There is no peer-observable change from this patch, as it only reworks
the
current MD5 support into the new internal representation.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?
Looking at it. Any chance to get Wireshark trace for this scenario?
On 25-Jun-21 09:25, brbarkel via groups.io wrote:
Just poking this to see if anyone has any ideas. Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77088): ht
Hi Siva,
I am fine with the patch per se, but I still have problems applying it.
Have you tried following my suggestions from our meeting?
Thanks,
Maciej
On 24-Jun-21 09:33, INDIA\sivaramann wrote:
Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver.
In this function any non allowe
Reviewed-by: Maciej Rabeda
On 08-Jun-21 15:06, Laszlo Ersek wrote:
Introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro for NetworkPkg.
When explicitly set to FALSE, remove MD5 from IScsiDxe's CHAP algorithm
list.
Set NETWORK_ISCSI_MD5_ENABLE to TRUE by default, for compatibility
re
Reviewed-by: Maciej Rabeda
On 08-Jun-21 15:06, Laszlo Ersek wrote:
Insert a SHA256 CHAP_HASH structure at the start of "mChapHash".
Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32).
This enables the initiator and the target to negotiate SHA256 for CHAP, in
preference t
t MD5 support into the new internal representation.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Philippe Mathieu-Daudé
Cc: Siyuan Fu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Signed-off-by: Laszlo Ersek
---
NetworkPkg/IScsiDxe/IScsiCHAP.h | 55 +++
Netw
, 2021 8:13 PM
To: edk2-devel-groups-io
Cc: Wu, Jiaxin ; Maciej Rabeda
; Philippe Mathieu-Daudé
; Fu, Siyuan
Subject: [edk2-devel] [PUBLIC edk2 PATCH v2 01/10] NetworkPkg/IScsiDxe: wrap
IScsiCHAP source files to 80 characters
Working with overlong lines is difficult for me; rewrap the CHAP
To cut to the chase on this patch:
Reviewed-by: Maciej Rabeda
On 09-Jun-21 15:46, Laszlo Ersek wrote:
On 06/09/21 12:43, Philippe Mathieu-Daudé wrote:
Hi Laszlo,
On 6/8/21 3:06 PM, Laszlo Ersek wrote:
IScsiDxe uses the ISCSI_CHAP_RSP_LEN macro for expressing the size of the
digest (16) that
Nicely aligned spacing...
Feels Good Man by Daniel 168
Reviewed-by: Maciej Rabeda
On 08-Jun-21 15:06, Laszlo Ersek wrote:
In the next patches, we'll need more room for various macro and parameter
names. For maintaining the current visual alignments, insert some
horizontal whitespa
Reviewed-by: Maciej Rabeda
On 08-Jun-21 15:06, Laszlo Ersek wrote:
RFC 7143 explains that a single iSCSI session may use multiple TCP
connections. The first connection established is called the leading
connection. The login performed on the leading connection is called the
leading login
Reviewed-by: Maciej Rabeda
On 28-Mar-21 14:02, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of
Siva,
OEMs are very welcome to submit a patch for that.
Thanks,
Maciej
On 17-Feb-21 10:31, Sivaraman Nainar wrote:
Hello Maciej:
We haven’t met any issue with the current implementation.
RNG Library functions are using Process Based Random Number generation.
Some OEM’s asking about the pla
Hi Siva,
I am not proactively trying to change that.
NET_RANDOM is used throughout the network stack and touching it would
require solid regression.
Is there any defect requiring such a change?
Thanks,
Maciej
On 12-Feb-21 06:52, Sivaraman Nainar wrote:
Hello Maciej:
Do you have any comment
Siva,
Just as Michael mentioned - the log you have provided suggests that you
are recurse-booting iPXE.
Next server: 10.0.84.155
Filename: ipxe.efi
tftp://10.0.84.155/ipxe.efi... ok
May I ask why?
Thanks,
Maciej
On 05-Feb-21 11:10, Michael Brown wrote:
On 05/02/2021 08:28, Sivaraman Nainar
Patch merged.
PR: https://github.com/tianocore/edk2/pull/1371
Commit:
https://github.com/tianocore/edk2/commit/ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3
On 20-Jan-21 12:54, Maciej Rabeda wrote:
Thanks for the patch!
Reviewed-by: Maciej Rabeda
On 15-Jan-21 07:22, GregX Yeh wrote:
https
Thanks for the patch!
Reviewed-by: Maciej Rabeda
On 15-Jan-21 07:22, GregX Yeh wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=3170
Using PcdHttpIoTimeout to set default timeout value to HttpIoLib.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: GregX Yeh
-7-2-2-a-comparison-of-any-pointer-to-zero-must-be-done-via-the-null-type
Do not submit v2, I will correct that upon merging. On terms CS issue is
addressed, I am giving:
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 01-Oct-20 17:25, Vladimir Olovyannikov wrote:
Hi Maciej,
Thank you for
Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
causes NetworkPkg build to fail due to lack of RngLib entry in
NetworkPkg's .dsc file.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
---
NetworkPkg/NetworkPkg.dsc | 1 +
1 file changed, 1 insertion(+)
while, looks like it slipped through the cracks.
Thank you,
Vladimir
-Original Message-
From: Vladimir Olovyannikov
Sent: Friday, August 28, 2020 11:17 AM
To: devel@edk2.groups.io
Cc: Vladimir Olovyannikov ; Maciej
Rabeda ; Jiaxin Wu ;
Siyuan Fu
Subject: [PATCH 1/1] NetworkPkg: Fix possible
Reviewed-by: Maciej Rabeda
On 28-Sep-20 08:29, Abner Chang wrote:
BZ #2909,
https://bugzilla.tianocore.org/show_bug.cgi?id=2909
When Http->Configure() is invoked with HttpConfigData set to
NULL to reset the EFI HTTP instance, TLS child instance is
destroyed but HttpInstance->TlsChildHan
Hi Scott,
Thanks for submitting the patch - I am about to approve the patch,
however - a couple of small remarks to the commit message.
1. Please remove the "From:" line
2. Please add "Cc:" lines before "Signed-off-by". Cc people are added
based on appropriate EDK2 package maintainer & reviewe
the decision whether this should be fixed in ShellPkg and
EmbeddedPkg to the appropriate maintainers.
For the rest of the code:
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 02-Sep-20 06:08, Vladimir Olovyannikov wrote:
Introduce an http client utilizing EDK2 HTTP protocol, to
allow fast image d
HTTTP, 443 for HTTPS.
In the case can we set Min as 1024 and Max as 65535.
Thanks
Siva
*From:* devel@edk2.groups.io [mailto:devel@edk2.groups.io] *On Behalf
Of *Maciej Rabeda
*Sent:* Tuesday, September 1, 2020 7:32 PM
*To:* devel@edk2.groups.io; Sivaraman Nainar
*Subject:* Re: [edk2-devel] TC
Hi Siva,
What seems to be the problem at hand? What kind of range of values for
TargetPort do you propose?
TARGET_PORT_MIN/MAX_NUM refer to a range of values (0-65535) that be set
in TargetPort field in iSCSI HII. 3260 is a default TCP port for iSCSI.
I see nothing wrong with that.
Thanks,
Ma
Hi Vladimir,
I got your message, I will look into it next week.
Have a great weekend!
Maciej
On 27-Aug-20 21:23, Vladimir Olovyannikov wrote:
Hi Maciej,
I would like to get your input (and the HttpDxe driver guys) on the issue
I see with Http redirection (using HttpDynamicCommand)
Basically,
and addressing the items above, you can tie:
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 25-Aug-20 06:16, Vladimir Olovyannikov wrote:
Hi Laszlo,
Sorry, I should've checked. No, there was no intention at all to even touch
an OpenSSL lib.
I will re-send tomorrow morning.
Thank you,
Vla
spec being very vague on the matter or some kind
of ancient knowledge that I am not aware of.
Thanks,
Maciej.
On 21-Aug-20 11:11, Laszlo Ersek wrote:
On 08/20/20 15:41, Michael Brown wrote:
On 20/08/2020 11:44, Maciej Rabeda wrote:
@Michael
I am now wondering whether bit 3 is actually relevant
Hi Siva,
If you want to propose a patch for review, please follow the process:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
I do not think my
4 (Server Identifier)
else
failure
Looking forward to discussion.
Thanks,
Maciej
On 19-Aug-20 21:20, Laszlo Ersek wrote:
On 08/19/20 20:13, Laszlo Ersek wrote:
On 08/19/20 18:53, Maciej Rabeda wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2876
According to PXE 2.1 spec, DHCP optio
@Laszlo,
As for type casting, I don't have strong opinions.
Space after typecast (for me) always seemed to be visually more
consistent with the rest of the code.
In my regular projects written in C-based languages, I would do it the
way you are describing.
@Vladimir
I went through the rest of
choosing boot server IP in PxeBcDhcp4BootInfo().
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
---
NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
b/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
Hi Vladimir,
I am inprog of going through the patch. There are some coding standard
violations.
For reference:
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
Http.c:
Lines 110-111: Spacing before open bracket and != operator
Line 133: Unnecessary brackets around EFI_SUC
ir Olovyannikov ;
devel@edk2.groups.io
Cc: Laszlo Ersek ; Samer El-Haj-Mahmoud ; Maciej Rabeda
; Wu, Jiaxin ; Fu,
Siyuan ; Ni, Ray ; Gao, Liming
; Nd
Subject: RE: [PATCH v5 1/1] ShellPkg/DynamicCommand: add
HttpDynamicCommand
Sorry for the delay reply.
See below:
-Original Message-
Reviewed-by: Maciej Rabeda
On 01-Aug-20 03:04, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2361
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Michael D Kinney
---
.../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +-
1 file changed, 1
Reviewed-by: Maciej Rabeda
On 20-Jul-20 10:37, Zhang, Shenglei wrote:
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
On 10-Jun-20 10:14, Shenglei Zhang wrote:
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg
-------
*From:* devel@edk2.groups.io on behalf of
Maciej Rabeda via groups.io
*Sent:* Monday, May 25, 2020 7:49 AM
*To:* devel@edk2.groups.io ;
andrey.warken...@gmail.com
*Cc:* jiaxin...@intel.com ; siyuan...@intel.com
*Subject:* Re: [edk2-devel] [edk2][PATCH 1/1]
ection.
URI: http://10.0.1.57/bootaa64.efi
File Size: 179160 Bytes
Downloading...100%
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Andrei Warkentin
---
NetworkPkg/HttpBootDxe/HttpBootImpl.c | 35 +++-
NetworkPkg/HttpDxe/HttpImpl.c | 5 +++
Copying my comments from Bugzilla:
I have gone through the Wireshark trace that you have provided. It seems
to be all clear now and the approach to the issue must change.
HttpBootDxe supports HTTP 1.1 and assumes that the HTTP session stays
persistent (single TCP connection for multiple reques
p[Index])) < Len, is
meaningless if Index = 0. So checking 'Index != 0' should be
performed first in the if statement.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
v2: Update 'Index > 0' to 'Index != 0'
NetworkPkg/Li
Hi Liming,
I would like to pull this in.
https://edk2.groups.io/g/devel/message/59947
Thanks,
Maciej
On 19-May-20 13:09, Liming Gao wrote:
Hi Stewards and all:
I collect current patch lists in devel mail list. Those patch
contributors request to add them for 200205 stable tag. Because we
Reviewed-by: Maciej Rabeda
On 20-May-20 05:08, Shenglei Zhang wrote:
The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is
meaningless if Index = 0. So checking 'Index != 0' should be
performed first in the if statement.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Cc: Jiax
Hi Andrei,
Thanks for catching this.
Smells a bit like a potential issue with Python's implementation of
underlying socketserver and interoperability with Windows.
https://stackoverflow.com/questions/46785946/python-socketserver-sends-fin-flag
Nevertheless, HTTP client should be aware that it
Hi Chang,
For any and all of your future patches, "Signed-off" should contain your
name + email and maintainer should be in Cc :)
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 17-Apr-20 04:38, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: Keysound C
Reviewed-by: Maciej Rabeda
On 17-Apr-20 04:51, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: 2020年4月9日 11:02
To: devel@edk2.groups.io
Cc: Fu, Siyuan ; Maciej Rabeda
; Wu, Jiaxin
Subject: [edk2-devel
Reviewed-by: Maciej Rabeda
On 09-Apr-20 10:22, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: michael.kuba...@outlook.com
Sent: 2020年4月8日 13:47
To: devel@edk2.groups.io
Cc: Fu, Siyuan ; Maciej Rabeda
; Wu, Jiaxin
Subject: [PATCH v1 1/1] NetworkPkg/Ip6Dxe
For your patch.
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 15-Apr-20 18:40, Laszlo Ersek wrote:
On 04/15/20 18:25, Laszlo Ersek wrote:
In other words, I personally believe that bug#1974 should have been
closed as INVALID (without patching the edk2 source). The EBS handler in
SnpDxe is nece
_CALLBACK on invocation.
Therefore, this commit changes the TPL of
SnpNotifyExitBootServices() to
TPL_CALLBACK.
Cc: Siyuan Fu
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Signed-off-by: Michael Kubacki
---
NetworkPkg/SnpDxe/Snp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/NetworkPkg/SnpDxe/Snp.
BACK. In addition, it has been
observed in some 3rd party UNDI drivers to cause an issue further down
the call stack if the TPL is higher than TPL_CALLBACK on invocation.
Therefore, this commit changes the TPL of SnpNotifyExitBootServices() to
TPL_CALLBACK.
Cc: Siyuan Fu
Cc: Maciej Rabeda
Cc: Jiax
d logic of recently added ASSERTs which should
ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid
packets.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
Reviewed-by: Siyuan Fu
Tested-by: Laszlo Ersek
Fixes: 9c20342eed70ec99ec50cd73cb81804299f05403
---
Network
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2655
This patch fixes reversed logic of recently added ASSERTs which should
ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid
packets.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
Reviewed-by: Siyuan Fu
h?
Thanks,
Maciej
On 01-Apr-20 14:02, Laszlo Ersek wrote:
Hi Maciej,
On 04/01/20 11:53, Maciej Rabeda wrote:
This patch fixes reversed logic of recently added ASSERTs which should
ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid
packets.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Sig
will receive an already
recycled packet with EFI_SUCCESS token status and finally
dereference invalid pointers from RxData structure.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Maciej Rabeda
Reviewed-by: Siyuan Fu
Acked-by: Zhichao Gao
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 ++
This patch fixes reversed logic of recently added ASSERTs which should
ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid
packets.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
Tested-by: Laszlo Ersek
---
NetworkPkg/Ip6Dxe/Ip6Nd.c | 6 +++---
1 file changed
Always better than not detecting such stuff at all (or by ASSERT in
debug builds). Thanks for the patch!
Reviewed-by: Maciej Rabeda
On 31-Mar-20 02:47, Laszlo Ersek wrote:
When DHCP is misconfigured on a network segment, such that two DHCP
servers attempt to reply to requests (and therefore
.io; maciej.rab...@linux.intel.com
Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4
receive flow.
Ray, Zhichao,
On 02/27/20 12:02, Maciej Rabeda wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032
'ping' command's receive flow utilizes a single Rx
f the
packet (packet size is Head->PayloadLength).
Can you try swapping the >= to <= and rerun your test?
This should apply to lines 2114, 2167 and 2337.
I will submit a patch for that.
Thanks,
Maciej
On 31-Mar-20 02:35, Laszlo Ersek wrote:
Hi Maciej,
On 03/30/20 14:23, Maciej Rabe
ommand Ip4
receive flow.
Ray, Zhichao,
On 02/27/20 12:02, Maciej Rabeda wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2032
'ping' command's receive flow utilizes a single Rx token which it
attempts to reuse before recycling the previously received packet.
This causes a s
acket.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
Reviewed-by: Siyuan Fu
---
NetworkPkg/Ip6Dxe/Ip6Nd.c | 44 +--
NetworkPkg/Ip6Dxe/Ip6Nd.h | 13 +
NetworkPkg/Ip6Dxe/Ip6Option.c | 57 +++-
3 files changed, 83 insertions(+), 31 deletions(-)
Reviewed-by: Maciej Rabeda
On 27-Mar-20 02:56, Gao, Zhichao wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
iSCSI driver required the MD5 function. Change the PcdMD5Enable
to TRUE when NETWORK_ISCSI_ENABLE is TURE.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off
Hi Abner,
For NetworkPkg (3-4/9) & MdePkg/Include (6/9):
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 29-Feb-20 15:13, Abner Chang wrote:
BZ:2562
https://bugzilla.tianocore.org/show_bug.cgi?id=2562
EDK2 CI report (RISCV64 only):
https://github.com/tianocore/edk2-staging/pull/196
EDK
acket.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Maciej Rabeda
---
NetworkPkg/Ip6Dxe/Ip6Nd.c | 44 +--
NetworkPkg/Ip6Dxe/Ip6Nd.h | 13 +
NetworkPkg/Ip6Dxe/Ip6Option.c | 57 +++-
3 files changed, 83 insertions(+), 31 deletions(-)
diff --git a/Network
1 - 100 of 131 matches
Mail list logo
