[edk2-devel] [PATCH v3 4/4] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-22 Thread Michael Roth via groups.io
A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table

[edk2-devel] [PATCH v3 3/4] OvmfPkg: Initialize the PcdSevSnpSecretsAddress PCD during PEI phase

2022-05-22 Thread Michael Roth via groups.io
This needs to be set so that UefiCpuPkg can locate the SEV-SNP secrets page later to set the AP Jump Table address. Signed-off-by: Michael Roth --- OvmfPkg/AmdSev/AmdSevX64.dsc| 3 +++ OvmfPkg/CloudHv/CloudHvX64.dsc | 3 +++ OvmfPkg/IntelTdx/IntelTdxX64.dsc| 3 +++

[edk2-devel] [PATCH v3 2/4] MdePkg: Add PcdSevSnpSecretsAddress to export SEV-SNP secrets page

2022-05-22 Thread Michael Roth via groups.io
OvmfPkg will initially use this to hand off the secrets page address to UefiCpuPkg, which will need this PCD to access the SEV-SNP secrets page address. Define this as an MdePkg PCD so it can be accessed by other packages alongside the secrets page struct defined in MdePkg/Include. Signed-off-by:

[edk2-devel] [PATCH v3 1/4] MdePkg: Add header for SEV-SNP secrets page struct

2022-05-22 Thread Michael Roth via groups.io
This will be needed so that the AP Jump Table address can be stored for use by the operating system later, and possibly for other things in the future. Signed-off-by: Michael Roth --- MdePkg/Include/Register/Amd/SnpSecretsPage.h | 56 1 file changed, 56 insertions(+)

[edk2-devel] [PATCH v3 0/4] Fix AP Jump Table Handling for SEV-SNP

2022-05-22 Thread Michael Roth via groups.io
A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-19 Thread Michael Roth via groups.io
Original Message- > > From: devel@edk2.groups.io On Behalf Of Michael Roth > > via groups.io > > Sent: Monday, May 16, 2022 8:02 PM > > To: devel@edk2.groups.io > > Cc: Tom Lendacky > > Subject: [edk2-devel] [PATCH v2] UefiCpuPkg: Store SEV-SNP AP jum

[edk2-devel] [PATCH v2] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-16 Thread Michael Roth via groups.io
A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table

[edk2-devel] [PATCH v2] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

2022-05-16 Thread Michael Roth via groups.io
The Confidential Computing blob defined here is intended to match the definition defined by linux guest kernel. Previously, both definitions relied on natural alignment, but that relies on both OVMF and kernel being compiled as 64-bit. While there aren't currently any plans to enable SNP support

Re: [edk2-devel] [PATCH] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-13 Thread Michael Roth via groups.io
On Fri, May 13, 2022 at 08:56:06AM -0500, Tom Lendacky wrote: > On 5/13/22 08:22, Michael Roth wrote: > > A full-featured SEV-SNP guest will not rely on the AP jump table, and > > will instead use the AP Creation interface defined by the GHCB. However, > > a guest is still allowed to use the AP

Re: [edk2-devel] [PATCH] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

2022-05-13 Thread Michael Roth via groups.io
On Fri, May 13, 2022 at 08:32:38AM -0500, Tom Lendacky wrote: > On 5/13/22 08:22, Michael Roth wrote: > > The Confidential Computing blob defined here is intended to match the > > definition defined by linux guest kernel. Previously, both definitions > > relied on natural alignment, but that

[edk2-devel] [PATCH] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-13 Thread Michael Roth via groups.io
A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table

[edk2-devel] [PATCH] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

2022-05-13 Thread Michael Roth via groups.io
The Confidential Computing blob defined here is intended to match the definition defined by linux guest kernel. Previously, both definitions relied on natural alignment, but that relies on both OVMF and kernel being compiled as 64-bit. While there aren't currently any plans to enable SNP support

Re: [edk2-devel] [PATCH v8 08/32] OvmfPkg/ResetVector: use SEV-SNP-validated CPUID values

2021-09-22 Thread Michael Roth via groups.io
On Wed, Sep 22, 2021 at 09:55:58AM +0200, Gerd Hoffmann wrote: > Hi, > > > +; If SEV-SNP is enabled, use the CPUID page to handle the CPUID > > +; instruction. > > +mov ecx, SEV_STATUS_MSR > > +rdmsr > > +bt eax, 2 > > +jc SnpCpuidLookup > > Maybe check