Hi Leif and Ard
Could you please help merge this series?
Thanks,
Minh Nguyen
On 5/11/2023 2:51 PM, Minh Nguyen wrote:
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is present or not. One patch also removes
unnecessary checks for PCIe
This refactor is derrived from ArmPkg/SMBIOS and customize to adapt
with platform. These changes help to separate each Type of SMBIOS table
into individual modules. It makes the structure of SmbiosPlatformDxe
module clear and easier to add new type of table.
Signed-off-by: Minh Nguyen
This corrects "PcdSmbiosTables1MajorVersion" and
"PcdSmbiosTables1MinorVersion" of SMBIOS Type 1,
these PCDs should be for Type 0.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec| 14
--
Platform/Am
This adds support SMBIOS Tables Type 16, 17, 19 for information of
Physical Memory, Memory Device and Memory Array Mapped Address.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
| 6 +
Silicon/Ampere
These patches helps to add new SMBIOS Tables (Type 16, 17, 19) and refactor
SmbiosPlatformDxe.
Minh Nguyen (4):
JadePkg: Correct PCD names for SMBIOS Type 0
JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32)
JadePkg: Refactor SmbiosPlatformDxe
JadePkg: Add support SMBIOS Table
This implementation helps SMBIOS Table (Type 0, 1, 2, 3, 13, 32)
of Altra and AltraMax platform to utilize framework from ArmPkg.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Jade.dsc| 7
+-
Platform/Ampere/JadePkg/Jade.fdf
This helps to remove redundant assign for SmbiosHandle.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Minh Nguyen
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe
To iterate entire SMBIOS table records for searching specific records,
"SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
patch helps to fix that.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Minh Nguyen
---
ArmPkg/Universal/
These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign
for SmbiosHandle.
Minh Nguyen (2):
ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
ArmPkg/Universal/Smbios/SmbiosMiscDxe
From: Tam Chi Nguyen
This patch adds a new Pkcs7GetSignature API to support
extracting the signature data from PKCS7 Certificate.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Minh Nguyen
---
CryptoPkg/Include/Library/BaseCryptLib.h | 29
From: Vu Nguyen
This adds PCIe Hot Plug library to support Hot Plug
feature and specific procedures for setting different
Portmap tables (GPIO pins used for PCIe reset).
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec| 8
+-
Silicon
card is present.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib
These patches support NVMe Hot Plug feature for Ampere Altra and Ampere Altra
Max.
Minh Nguyen (2):
AmpereAltraPkg: Add Hot Plug Slot Capable during PCIe port
initialization
AmpereAltraPkg: Change PCIe Amba Link Timeout value
Vu Nguyen (4):
AmpereAltraPkg: Add PCIe Hot Plug library
From: Vu Nguyen
This enables NVMe Hot Plug feature after finishing
PCIe set up. This helps to detect NVMe disk when
it's removed or inserted into its slot.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/PcieInitPei.inf | 3 ++-
Silicon/Ampere/AmpereAlt
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra Max.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi | 24 +
Platform/Ampere/JadePkg
LinkStat and BlockEventStat registers after this fix are
respectively 0x1103 and 0x1 (Link is up).
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/AcpiTables/Dsdt.asl | 499 -
Platform/Ampere/JadePkg/AcpiTables
As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS Hot Plug removal delay.
The greater value the longer delay it is. Per experiments, set it 2
from beginning of Root Port initialization for stable operation.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
In order to detect the NVMe after OS boots successfully but
that NVMe's not present previously. Hot Plug Slot Capable
will help PCI Linux driver to initialize its slot iomem resource
which is used for detecting the disk when it's inserted.
Signed-off-by: Minh Nguyen
---
Sili
Because PCIe Auto bifurcation feature doesn't depend on the default
Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving
the PCIe Devmap default mode.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +-
1
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is present or not. One patch also removes
unnecessary checks for PCIe Devmap mode.
Minh Nguyen (2):
AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devma
Hi all,
Thanks a lot for reviewing these patches
Thanks,
Minh Nguyen
On 5/10/2023 1:11 PM, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 07:59, Nhi Pham wrote:
Thanks Minh for this series. It looks good to me.
Reviewed-by: Nhi Pham
Hi Leif, Ard - Could you please help merge this series
Hi Abner,
Thanks for your information.
Thanks,
Minh Nguyen
On 5/8/2023 8:45 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and proprietary information
protection practices.]
[AMD Official Use Only
Hi Pedro,
I just re-sent in readable format.
Thanks,
Minh Nguyen
On 5/7/2023 12:39 PM, Minh Nguyen wrote:
Hi Pedro,
Firstly, thanks for your comments, let me explain.
- "C99 flexible array members have been well defined and well
supported for maybe 20 years in GCC (
r: expression in static assertion is not an integer*_".
=> Conclusion: This is not problem on compiler, it just comes from the
way BasTools gen PcdValueInit.c
and define macros for this case (map PCD structure to any structure). I
hope it satisfy your concerns.
Thanks,
Minh Nguyen.
Hi Abner,
I have checked in my system and it works fines when using
RedfishConfigHandlerDriver.
I also updated new patches, could you please help me to check it?
Thanks,
Minh Nguyen
On 5/4/2023 3:26 PM, Minh Nguyen wrote:
Hi Abner,
Let me check in my system and will give the
Hi Abner,
I've updated. Thanks for your review.
Thanks,
Minh Nguyen
On 5/5/2023 2:38 PM, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Minh,
Please add my RB for 3/5 in commit message and push to
minhnampere:Adding_necessary_changes_for_RedfishPkg again. I will check th
Hi Abner,
While they're checking this issue, they recommend me to re-send v3 so
I just sent it, you can also use the PR to review at the same time.
Thanks,
Minh Nguyen.
On 5/5/2023 1:01 PM, Minh Nguyen wrote:
Hi Abner,
Here you are: #4338 <https://github.com/tianocore/edk2/p
Hi Abner,
Here you are: #4338 <https://github.com/tianocore/edk2/pull/4338>
Thanks,
Minh Nguyen
On 5/5/2023 12:45 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information prot
Hi Abner,
Yes, me too. I have sent the email to miki.deme...@intel.com for
checking it.
Thanks,
Minh Nguyen
On 5/5/2023 12:03 PM, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Minh,
I don't know why however I can't see V3 patch set on group.io. Can you see
those
interface. This might raise an issue on the system with multiple network
devices that the RestEx child was installed on wrong interface.
Siigned-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/Include/Library/RestExLib.h | 3 +
RedfishPkg
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v3:
+ Replaced __FUNCTION__ with __func__ to be more C11 compliant.
Changes since v2:
+ Added "Cc:" to maintainers in commit message.
+ Corrected patch format subject prefix.
C
From: Vu Nguyen
Add extra option call Auto to the Bifurcation selection. This mode will
automatically select the best bifurcation mode the current Root Complex.
Currently, this option only availabe on the RCA with x16 width.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Include
These patches support for PCIe Auto Bifurcation feature of Ampere
silicon (Altra and Altra Max).
Vu Nguyen (2):
AmpereAltraPkg: Add support for PCIe Auto Bifurcation
AmpereAltraPkg: Enable auto bifurcation via BoardSetting
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.
From: Vu Nguyen
Add support for new BoardSetting's config value (0x000A) to enable auto
bifurcation mode per Root Complex:
Example:
NV_SI_RO_BOARD_S0_RCA2_CFG, 0x0098, 0x000A
NV_SI_RO_BOARD_S0_RCA3_CFG, 0x00A0, 0x000A
Signed-off-by: Minh Nguyen
---
Silicon/A
Hi Abner,
Let me check in my system and will give the confirmation to you.
Thanks,
Minh Nguyen
On 5/4/2023 3:00 PM, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Minh, please check my comment inline,
-Original Message-
From: Minh Nguyen
Sent: Thursday, May 4, 2023 12
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
interface. This might raise an issue on the system with multiple network
devices that the RestEx child was installed on wrong interface.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/Include/Library/RestExLib.h | 3 +
RedfishPkg
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/RedfishDiscoverDxe
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v2:
+ Add "Cc:" to maintainers in commit message.
+ Correct patch format subject prefix.
Changes since v1:
+ Remove redundant change and change the commit message for more prec
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe
interface. This might raise an issue on the system with multiple network
devices that the RestEx child was installed on wrong interface.
Signed-off-by: Minh Nguyen
---
RedfishPkg/Include/Library/RestExLib.h | 3 +
RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153
Hi Abner,
Thanks for this point, I will add the "Cc:" to maintainers in commit
message at PATCH V2.
Thanks,
Minh Nguyen.
On 5/4/2023 9:16 AM, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Minh,
You can run Patchcheck (Basetools/Scripts/) before you sending out
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
1 file changed, 2
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 -
1 file changed, 4 insertions(+), 1 deletion
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v1:
+ Remove redundant change and change the commit message for more precise in
PATCH 2/5.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPk
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Hi Chang,
It seems like my email has the problem, please expect the delay for my v2
patches while my email's fixing. Thanks for your patience.
Thanks,
Minh Nguyen
From: Chang, Abner
Sent: Sunday, April 16, 2023 11:36 AM
To: Minh Nguyen OS ; devel
Hi Chang,
Yes, this is the first time and the issue comes from my internal mail and
waiting for fixing. Thanks for that information and will check with
miki.deme...@intel.com as well.
Thanks,
Minh Nguyen.
From: Chang, Abner
Sent: Thursday, April 20, 2023 8:28
Hi Wang,
Thanks for this point, you're right. It's a redundant change and I will update
in v2 patches, but the second change is necessary. How do you think about that?
Thanks,
Minh Nguyen
-Original Message-
From: Nickle Wang
Sent: Friday, April 14, 2023 4:04 PM
To: Minh
Hi Wang,
Thanks for this point, you're right. It's a redundant change and I will update
in v2 patches, but the second change is necessary. How do you think about that?
Thanks,
Minh Nguyen
-Original Message-
From: Nickle Wang
Sent: Friday, April 14, 2023 4:04 PM
To: Minh
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/RedfishPkg
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishPkg
interface. This might raise an issue on the system with multiple network
devices that the RestEx child was installed on wrong interface.
Signed-off-by: Minh Nguyen
---
RedfishPkg/Include/Library/RestExLib.h | 3 +
RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153
From: Vu Nguyen
This change also fix miscellaneous errors on condition checking and
debug argument missing.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
This patchset adds necessary changes for RedfishPkg to avoid
some unexpected cases and fix compilation.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPkg: Correct variable type to prevent memory corruption
RedfishPkg: Prevent assertion of allocate zero lengt
63 matches
Mail list logo
