Gard, any comments?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Wednesday, July 5, 2023 10:49 AM
> To: devel@edk2.groups.io; Xie, Yuanhao
> Subject: Re: [edk2-devel] [Patch V4 0/5] Eliminate the second INIT-SIPI-SIPI
> sequence
>
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuanhao Xie
> Sent: Wednesday, June 28, 2023 4:47 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V4 0/5] Eliminate the second INIT-SIPI-SIPI
> sequence
>
> To speed up MP initialization, thi
y, July 2, 2023 12:14 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar ; Paul Grimes
> ; Abner Chang ; Dong, Eric
> ; Ni, Ray ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Ard
> Biesheuvel ; Yao, Jiewen ;
> Justen, Jorda
+@Nong, Foster
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chris Li OS
> via groups.io
> Sent: Friday, June 30, 2023 2:07 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add Cxl20.h into
> IndustryStandard
>
> Thanks Jiewen,
> -Original Message-
> From: Jeff Brasen
> Sent: Friday, June 30, 2023 11:21 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A
> Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Add support for driver
> binding
>
> No
, 2023 4:54 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; Jeff Brasen
> Subject: [PATCH] MdeModulePkg/PciHostBridge: Add support for driver binding
>
> If the platform does not support any PCIe devices using the library
>
> meth
> + OriginalValue = InterlockedCompareExchange32 (
> +(UINT32 *)ApStartupSignalBuffer,
> +MP_HAND_OFF_SIGNAL,
> +0
> +);
> + if (OriginalValue == MP_HAND
Reviewed-by: Ray Ni
> -Original Message-
> From: Xie, Yuanhao
> Sent: Monday, June 26, 2023 1:57 PM
> To: devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul R ; Tom
> Lendacky ; Xie, Yuanhao
>
> Subject: [Patch V3 4/5] UefiCpuPkg
Several comments below:
>
> The SaveCpuMpData() function was updated to construct the MP_HAND_OFF
> Hob. Additionally, the function introduced the MP_HAND_OFF_SIGNAL,
> which solely served the purpose of awakening the APs
> and transitioning their context from PEI to DXE. The
> WaitLoopExecutionM
Reviewed-by: Ray Ni
> -Original Message-
> From: Xie, Yuanhao
> Sent: Monday, June 26, 2023 1:57 PM
> To: devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul R ; Tom
> Lendacky ; Xie, Yuanhao
>
> Subject: [Patch V3 2/5] UefiCpu
Reviewed-by: Ray Ni
> -Original Message-
> From: Xie, Yuanhao
> Sent: Monday, June 26, 2023 1:57 PM
> To: devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul R ; Tom
> Lendacky ; Xie, Yuanhao
>
> Subject: [Patch V3 1/5] UefiCpu
ndex is 0.
Thanks,
Ray
> -Original Message-
> From: Xie, Yuanhao
> Sent: Sunday, June 25, 2023 10:39 PM
> To: devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul R ; Tom
> Lendacky ; Xie, Yuanhao
>
> Subject: [Patch V2 6/6]
I don't think that's the solution to resolve pkg dependencies by adding
interfaces to mdePkg.
From: Guo, Gua
Sent: Wednesday, June 21, 2023 9:23 PM
To: Ni, Ray ; devel@edk2.groups.io; Hsu, VictorX
Cc: Gao, Liming ; Chan Laura ;
Prakashan, Krishnadas Veliyathuparambil
; K
Why is this GUID moved to MdePkg?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Wednesday, June 21, 2023 3:02 PM
> To: Hsu, VictorX ; devel@edk2.groups.io
> Cc: Gao, Liming ; Chan Laura
> ; Prakashan, Krishnadas Veliyathuparambil
> ; K N, Karthik
>
> Sub
I updated the patch per Zhiguang's comments to remove ALIGN 16 requirement.
Can you please review again?
Only the 2nd patch is updated.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Wednesday, June 21, 2023 10:55 AM
&g
ResetVector assembly implementation puts "ALIGN 16" in the end
to guarantee the final executable file size is multiple of 16 bytes.
Because the module uses a special GUID which guarantees it's put in
the very end of a FV, which should be also the end of the FD.
All of these (file size is multiple o
Because it's simpler for a platform to include the ResetVector source
and having pre-built binaries add burdens of updating the pre-built
binaries. This patch removes the pre-built binaries and the script
that buids the pre-built binaries.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Ack
Since ResetVector source module shares the same GUID as the binary
module, the binary INF file is just removed from DSC.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Acked-by: Gerd Hoffmann
---
UefiCpuPkg/UefiCpuPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
Ray Ni (3):
UefiCpuPkg: Include ResetVector in DSC
UefiCpuPkg/ResetVector: Add guidance of FDF ffs rule
UefiCpuPkg/ResetVector: Remove pre-built binaries
.../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes
.../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500 -> 0 bytes
.
Gerd,
Can you kindly provide "Reviewed-by" for the patch series?
Thanks,
Ray
> -Original Message-----
> From: Ni, Ray
> Sent: Tuesday, June 13, 2023 3:56 PM
> To: devel@edk2.groups.io; abdat...@amd.com
> Cc: Paul Grimes ; Abner Chang
> ; Dong, Eric ; Kumar, Rahul
Because it's simpler for a platform to include the ResetVector source
and having pre-built binaries add burdens of updating the pre-built
binaries. This patch removes the pre-built binaries and the script
that buids the pre-built binaries.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc:
ResetVector assembly implementation puts "ALIGN 16" in the end
to guarantee the final executable file size is multiple of 16 bytes.
Because the module uses a special GUID which guarantees it's put in
the very end of a FV, which should be also the end of the FD.
Then to make sure the reset vector "J
Ray Ni (3):
UefiCpuPkg: Include ResetVector in DSC
UefiCpuPkg/ResetVector: Add guidance of how to guarantee 16B align
UefiCpuPkg/ResetVector: Remove pre-built binaries
.../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes
.../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500
Since ResetVector source module shares the same GUID as the binary
module, the binary INF file is just removed from DSC.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/UefiCpuPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
I haven't got "Reviewed-by" for MdeModulePkg changes. Can Jian or Liming
approve?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Tuesday, June 13, 2023 2:13 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH V
Is this event signaled regardless of FSP API/Dispatch mode?
> -Original Message-
> From: Chang, Hunter
> Sent: Tuesday, June 13, 2023 8:40 PM
> To: devel@edk2.groups.io
> Cc: Chang, Hunter ; Ni, Ray ;
> Chaganty, Rangasai V ; Oram, Isaac W
> ; S, Ashraf Ali ; Chen,
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abdul Lateef
> Attar via groups.io
> Sent: Tuesday, June 6, 2023 2:07 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar ; Paul Grimes
> ; Abner Chang ; Dong, Eric
> ;
Remove my name from reviewer list of following modules:
* MdeModulePkg: Console and Graphics modules
* MdeModulePkg: Reset modules
* MdeModulePkg: Serial modules
* MdeModulePkg: Universal Payload definitions
Signed-off-by: Ray Ni
Cc: Zhichao Gao
Cc: Hao A Wu
Cc: Zhiguang Liu
Cc: Gua Guo
---
Signed-off-by: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Cc: Jiaxin Wu
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 4
1 file changed, 4 insertions(+)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
index 68af9ab81b..a8537829e3 100644
--- a/Md
When a platform has lots of CPU cores/threads, perf-logging on every
AP produces lots of records. When this multiplies with number of SMIs
during post, the records are even more.
So, this patch adds a new PCD PcdSmmApPerfLogEnable (default TRUE)
to allow platform to turn off perf-logging on APs.
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot
by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and
impact the SMI latency at runtime.
Hence the SmmCorePerformanceLib is updated to disable perf-logging
after ExitBS.
Cc: Jiaxin Wu
Cc: Dandan Bi
Cc: Liming Gao
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot
by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and
impact the SMI latency at runtime.
Hence the SmmPerformanceLib is updated to disable perf-logging
after ExitBS.
Cc: Jiaxin Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc:
SmmDriverDispatchHandler is the routine that dispatches SMM drivers
from FV. It's a time-consuming routine.
Add perf-logging for this routine.
Signed-off-by: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Cc: Jiaxin Wu
Reviewed-by: Jiaxin Wu
Reviewed-by: Eric Dong
---
MdeModulePkg/Core/PiSmmCore/Dis
Following procedures are perf-logged:
* SmmReadyToBootHandler
* SmmReadyToLockHandler
* SmmEndOfDxeHandler
* SmmEntryPoint
(It's the main routine run in BSP when SMI happens.)
* SmiManage
Cc: Jian J Wang
Cc: Liming Gao
Cc: Jiaxin Wu
Reviewed-by: Jiaxin Wu
Reviewed-by: Eric Dong
---
MdeModu
MP procedures are those procedures that run in every CPU thread.
The EDKII perf infra is not MP safe so it doesn't support to be called
from those MP procedures.
The patch adds SMM MP perf-logging support in SmmMpPerf.c.
The following procedures are perf-logged:
* SmmInitHandler
* SmmCpuFeaturesRe
The patch adds perf-logging for the following potential
time-consuming BSP procedures:
* PiCpuSmmEntry
- SmmRelocateBases
- ExecuteFirstSmiInit
* BSPHandler
- SmmWaitForApArrival
- PerformRemainingTasks
* InitPaging
* SetMemMapAttributes
* SetUefiMemMapAttributes
* SetPageT
To avoid impacting runtime performance, the perf-logging is
disabled upon ExitBootServices.
Ray Ni (8):
UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures
UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures
MdeModulePkg/SmmCore: Add perf-logging for time-consuming proced
Sure.
I will update the patch to keep my name for disk modules.
Thanks,
Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, June 13, 2023 11:05 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Gao, Zhichao ; Liu, Zhiguang
> ; Guo, Gua
> Subject: RE: [PATCH]
Reviewed-by: Ray Ni
From: devel@edk2.groups.io on behalf of Sheng Wei
Sent: Monday, June 12, 2023 16:17
To: devel@edk2.groups.io
Cc: Ni, Ray; Chaganty, Rangasai V; Huang, Jenny; Kowalewski, Robert
Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix
Remove my name from reviewer list of following modules:
* MdeModulePkg: Console and Graphics modules
* MdeModulePkg: Disk modules
* MdeModulePkg: Reset modules
* MdeModulePkg: Serial modules
* MdeModulePkg: Universal Payload definitions
Signed-off-by: Ray Ni
Cc: Zhichao Gao
Cc: Hao A Wu
Cc: Zhi
Jiaxin,
you are right!
ExecuteFirstSmiInit doesn't belong to SmmRelocateBases.
I will update commit message.
From: Ni, Ray
Sent: Monday, June 12, 2023 13:16
To: Wu, Jiaxin; devel@edk2.groups.io
Cc: Dong, Eric; Kumar, Rahul R; Gerd Hoffmann
Subjec
From: Wu, Jiaxin
Sent: Friday, June 9, 2023 21:42
To: devel@edk2.groups.io; Ni, Ray
Cc: Dong, Eric; Kumar, Rahul R; Gerd Hoffmann
Subject: RE: [edk2-devel] [PATCH V2 1/6] UefiCpuPkg/CpuSmm: Add perf-logging
for time-consuming BSP procedures
>
&g
We can add perf-logging for the two functions in a separate patch.
From: Wu, Jiaxin
Sent: Friday, June 9, 2023 22:36
To: Ni, Ray; devel@edk2.groups.io
Cc: Wang, Jian J; Gao, Liming
Subject: RE: [PATCH V2 3/6] MdeModulePkg/SmmCore: Add perf-logging for
>
> Could we add the comments to this enum? It defines the ID of the MP procedure.
> For MP procedure, it needs call SMM_MP_PERF_PROCEDURE_ID with entries
> name defined in the SMM_MP_PERF_PROCEDURE_LIST.
Thanks. Will add the comments.
>
>
>
> Others good to me.
>
> Reviewed-by: Jiaxin Wu
e has already done.)
Thanks,
Ray
> -Original Message-
> From: Ard Biesheuvel
> Sent: Friday, June 9, 2023 1:23 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao,
> Jiewen ; Gerd Hoffmann ; Taylor
> Beebe ; Oliver Smith-Denny ;
> Bi, Dandan ; Tan,
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:27 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Gerd
> Hoffmann ; Tom Lendacky
> ; Ni, Ray
> Subject: [Patch V5 01/14] Ovm
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 04/14] UefiCpuPkg: Add DEBUG_CODE for special case
&g
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [edk2-devel] [Patch V5 05/14] Uefi
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 03/14] UefiCpuPkg: Use CpuPageTableLib to convert S
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 08/14] UefiCpuPkg: Extern mSmmShadowStackSize
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 13/14] UefiCpuPkg: Refinement to smm runtime
> Ini
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 12/14] UefiCpuPkg: Sort mProtectionMemRange when
&g
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 11/14] UefiCpuPkg: Sort mSmmCpuSmramRanges in
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 09/14] UefiCpuPkg: Add GenSmmPageTable() to create
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Thursday, June 8, 2023 10:28 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Ni, Ray ;
> Wang, Jian J
> Subject: [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection
> when unset guard pa
This patch is based on patch series:
https://edk2.groups.io/g/devel/message/105492.
I don't want to send a V3 for just including the additional patch.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Wednesday, June 7, 2023 4:38 PM
&g
When a platform has lots of CPU cores/threads, perf-logging on every
AP produces lots of records. When this multiplies with number of SMIs
during post, the records are even more.
So, this patch adds a new PCD PcdSmmApPerfLogEnable (default TRUE)
to allow platform to turn off perf-logging on APs.
Signed-off-by: Ray Ni
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Zhichao Gao
---
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 5209e21449..e40361a0ae 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -592,7 +59
The Shell binaries are not generated anymore in each
stable tag release.
So, remove the section.
Cc: Zhichao Gao
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Ray Ni
---
Maintainers.txt | 8
1 file changed, 8 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9c
Signed-off-by: Ray Ni
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 09d04af27a..9c54800f2f 100644
--- a/Maintainers.txt
+++ b/Maintainers
ectly used with this IPL?
Thanks,
Ray
> -Original Message-
> From: Zhang, Hongbin1
> Sent: Monday, May 22, 2023 1:21 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Hongbin1 ; Yao, Jiewen
> ; Ni, Ray ; Zeng, Star
> ; Wu, Jiaxin ; Sami Mujawar
> ; Ard Biesheuvel ;
>
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
> Sent: Tuesday, June 6, 2023 1:40 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Kinney, Michael D
> ; Michael Kubacki
> ; Sean Brogan
> Subject: [edk2-devel] [PATCH v2] UnitTestFramewo
I just set it up.
It's in https://edk2.groups.io/g/devel/calendar, also in attachment.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, June 6, 2023 10:14 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Leif Li
tion that? I am afraid I may forget
this without clear function header comments.
Others look good to me.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, May 23, 2023 2:36 PM
> To: Ni, Ray ; Attar, Abdul
> +/**
> + Allocate Buffer Or Clear Buffer For Global Data.
> +**/
> +VOID
> +AllocateBufferOrClearBufferForGlobalData (
> + VOID
> + )
> +{
> + ZeroMem (&mPrivateData, sizeof (mPrivateData));
> + if (!PSInitDone) {
1. "PSInitDone" doesn't follow edk2 coding style.
> +mHobBuffer = Alloc
m: Tan, Dun
> Sent: Friday, June 2, 2023 11:47 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: RE: [edk2-devel] [Patch V4 10/15] UefiCpuPkg: Add GenSmmPageTable()
> to create smm page table
>
> Edited the reply to make
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Tuesday, May 16, 2023 6:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
> R ; Gerd Hoffmann
> Subject: [Patch V4 15/15] UefiCpuPkg/PiSmmCpuDxeSmm: Remove unnecessary
&
> + } else {
> +MemoryAttrMask = EFI_MEMORY_XP;
> +for (Index = 0; Index < mSmmCpuSmramRangeCount; Index++) {
> + Base = mSmmCpuSmramRanges[Index].CpuStart;
> + if ((Base > PreviousAddress) && mXdSupported) {
Is "mXdSupported" check really needed? But you didn't add that check f
Why do you add the sort logic?
I thought you might have further changes to remove some unnecessary logic that
deals with un-sorted array.
> -Original Message-
> From: Ni, Ray
> Sent: Friday, June 2, 2023 11:34 AM
> To: Tan, Dun ; devel@edk2.groups.io
> Cc: Dong, Eric ;
Similar comments as patch #12.
You could avoid pool allocation.
> -Original Message-
> From: Tan, Dun
> Sent: Tuesday, May 16, 2023 6:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
> R ; Gerd Hoffmann
> Subject: [Patch V4 13
> + Buffer = AllocateZeroPool (sizeof (EFI_SMRAM_DESCRIPTOR));
> + ASSERT (Buffer != NULL);
You can define a local variable "EFI_SMRAM_DESCRIPTOR OneSmramDescriptor" to
avoid pool allocation.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply O
> - mSmmS3ResumeState->SmmS3Cr3 = (UINT32)(UINTN)PTEntry;
> + mSmmS3ResumeState->SmmS3Cr3 = (UINT32)GenSmmPageTable
> (Paging4Level, 32);
Why is "Paging4Level" used for S3 page table?
The S3 page table is used by S3Resume module:
if (SmmS3ResumeState->Signature == SMM_S3_RESUME_SMM_64) {
he "Guard page" in "mSmmStackSize range" as
not-present.
But the "Guard page" in "mSmmShadowStackSize range" is not marked as
not-present.
Why?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Tuesday, May 16,
You removed all "extern" and added one "extern" in PiSmmCpuDxeSmm.h.
But, where is the mSmmShadowStackSize defined?
No link error?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Tuesday, May 16, 2023 5:59 PM
> To: devel@edk2
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Tuesday, May 16, 2023 5:59 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
> R ; Gerd Hoffmann
> Subject: [edk2-devel] [Patch V4 08/15] Uefi
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Tuesday, May 16, 2023 5:59 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
> R ; Gerd Hoffmann
> Subject: [Patch V4 07/15] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to
&g
following items in next meeting:
1. Alignment of the problem to solve
2. Alignment of the priority
I am available at 10pm~11pm (GMT+8) next Wednesday night.
Thanks,
Ray
> -Original Message-
> From: Michael Kubacki
> Sent: Friday, June 2, 2023 10:24 AM
> To: Ni, Ray ; Ol
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, June 1, 2023 9:31 AM
> To: Zhang, Hongbin1 ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Zeng, Star
> Subject: RE: [PATCH v1] UefiCpuPkg
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index 3deb1ffd67..a25a96f68c 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1,7 +1,7 @@
> /** @file
> Page Fault (#PF) handler for X
Jiewen,
Good suggestion😊.
This also resolve's Jiaxin's comments that check if the variable is
non-volatile.
Thanks,
Ray
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, June 1, 2023 9:06 AM
> To: devel@edk2.groups.io; Wu, Jiaxin ; Li, Zhihao
> ; Gao,
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot
by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and
impact the SMI latency at runtime.
Hence the SmmCorePerformanceLib is updated to disable perf-logging
after ExitBS.
Cc: Jiaxin Wu
Cc: Dandan Bi
Cc: Liming Gao
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot
by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and
impact the SMI latency at runtime.
Hence the SmmPerformanceLib is updated to disable perf-logging
after ExitBS.
Cc: Jiaxin Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc:
SmmDriverDispatchHandler is the routine that dispatches SMM drivers
from FV. It's a time-consuming routine.
Add perf-logging for this routine.
Signed-off-by: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Cc: Jiaxin Wu
---
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 5 -
1 file changed, 4 insertion
Following procedures are perf-logged:
* SmmReadyToBootHandler
* SmmReadyToLockHandler
* SmmEndOfDxeHandler
* SmmEntryPoint
(It's the main routine run in BSP when SMI happens.)
* SmiManage
Cc: Jian J Wang
Cc: Liming Gao
Cc: Jiaxin Wu
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 14 ++
MP procedures are those procedures that run in every CPU thread.
The EDKII perf infra is not MP safe so it doesn't support to be called
from those MP procedures.
The patch adds SMM MP perf-logging support in SmmMpPerf.c.
The following procedures are perf-logged:
* SmmInitHandler
* SmmCpuFeaturesRe
The patch adds perf-logging for the following potential
time-consuming BSP procedures:
* PiCpuSmmEntry
- SmmRelocateBases
* ExecuteFirstSmiInit
* BSPHandler
- SmmWaitForApArrival
- PerformRemainingTasks
* InitPaging
* SetMemMapAttributes
* SetUefiMemMapAttributes
* SetPag
Ray Ni (6):
UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures
UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures
MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures
MdeModulePkg/SmmCore: Add perf-logging for SmmDriverDispatchHandler
MdeModulePkg/S
The patch moves the CpuPageTableLib reference from CoreDxeLib.dsc
to CoreCommonLib.dsc since now not only DxeMpInitLib but also CpuMpPei
depends on it.
Signed-off-by: Ray Ni
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
---
Platform/Intel/MinPlatformPkg/Inclu
> > > > 2.
> > > > When a memory region is marked from not-present to present,
> PageTableLib
> > > expects
> > > > caller to supply all memory attributes (including RW, NX, etc.) as the
> > > > lib
> > > implementation doesn't
> > > > want to carry any default attributes..
> > > > Do you think th
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, May 30, 2023 3:32 PM
> To: Ni, Ray
> Cc: devel@edk2.groups.io; Yao, Jiewen ; Gerd
> Hoffmann ; Taylor Beebe ; Oliver
> Smith-Denny ; Bi, Dandan ;
> Gao, Liming ; Kinney, Michael D
> ; Leif Lindhol
ith me offline😊
Thanks,
Ray
From: devel@edk2.groups.io On Behalf Of Marvin Häuser
Sent: Tuesday, May 30, 2023 6:25 PM
To: Ard Biesheuvel
Cc: edk2-devel-groups-io ; Ni, Ray
Subject: Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and
remap XIP capable DXE drivers
On 30. May 2023,
Reviewed-by: Ray Ni
thanks,
ray
From: devel@edk2.groups.io on behalf of VincentX Ke
Sent: Wednesday, May 31, 2023 10:48:06 AM
To: devel@edk2.groups.io
Cc: Ke, VincentX ; Chiu, Chasel ;
Desimone, Nathaniel L ; Oram, Isaac W
; Gao, Liming ; Dong, Eric
; Sinha
4 minor comments.
> +if (FadtPtr->XFirmwareCtrl) {
1. you should use "if (FadtPtr->XFirmwareCtrl != 0)" to align with edk2 coding
style.
>
> + CallbackFunction ((EFI_ACPI_COMMON_HEADER
> *)(UINTN)FadtPtr->XFirmwareCtrl, TableIndex++, Context);
>
> +} else {
>
> +
+@Abner Chang and @Tom Lendacky
> -Original Message-
> From: Tan, Dun
> Sent: Tuesday, May 30, 2023 6:25 PM
> To: Ni, Ray ; Ard Biesheuvel ;
> devel@edk2.groups.io
> Cc: Yao, Jiewen ; Gerd Hoffmann
> ; Taylor Beebe ; Oliver Smith-
> Denny ; Bi, Dandan ; Gao,
>
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, May 30, 2023 3:52 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Yao, Jiewen ; Gerd Hoffmann ;
> Taylor Beebe ; Oliver Smith-Denny denny.com>; Bi, Dandan ; Gao, Liming
> ; Kinney, Michael D ;
> Leif
Today the delay is 10us but the QSP simulates the multiprocessor
by dividing time into segments and serializing processors within a
segment.
The length of the segment is configurable and Simics open board
is configured using 100us.
But the firmware configures the delay between INIT and SIPI is 10u
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Tuesday, May 30, 2023 3:58 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Yao, Jiewen ; Gerd Hoffmann ;
> Taylor Beebe ; Oliver Smith-Denny denny.com>; Bi, Dandan ; Gao, Limi
Looks good.
@Tan, Dun, can you please evaluate if using MemoryAttribute PPI, what opens
will there be for X64 DxeIpl?
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, May 25, 2023 10:31 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao,
nt to carry any default attributes..
Do you think the MemoryAttribute PPI should expect the same to caller?
Thanks,
Ray
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, May 25, 2023 10:31 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Jiewen
&g
ginal Message-
> From: Ard Biesheuvel
> Sent: Monday, May 29, 2023 6:17 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Jiewen
> ; Gerd Hoffmann ; Taylor Beebe
> ; Oliver Smith-Denny ; Bi, Dandan
> ; Gao, Liming ; Kinney,
> Michael D ; Leif Lindholm
>
401 - 500 of 1843 matches
Mail list logo
