Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-24 Thread Purma, Kondal R
Thanks for the feedback and your view points Bob. I totally agree on your points and the  base tools issues. I think together we can fix the issues you mentioned and apply best software design principles to  base tools . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to t

Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-25 Thread Purma, Kondal R
Thanks for all feedback received so far. As the review and feedback period is over, moving forward to fix the bugs and announce first official release of EDK II Python Development Process specification. Thank you all. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [PATCH] [Tianocore-Docs]: EDK II Python development Process and coding standards spec

2020-03-25 Thread Purma, Kondal R
Fixing typo in  Python development Process and coding standards draft spec Chapter2. Signed-off-by: Purma, Kondal R --- README.md                             | 9 + book.json                             | 2 +- python_coding_guidelines_and_tools.md | 2 +- 3 files changed, 7 insertions

[edk2-devel] [PATCH] [Tianocore-Docs]: EDK II Python development Process and coding standards spec

2020-03-26 Thread Purma, Kondal R
Fixing typo in Python development Process and coding standards draft spec Chapter2. Signed-off-by: Purma, Kondal R mailto:kondal.r.pu...@intel.com>> --- README.md | 9 + book.json | 2 +- python_coding_guidelines_and_to

Re: [edk2-devel] [PATCH] [Tianocore-Docs]: EDK II Python development Process and coding standards spec

2020-04-16 Thread Purma, Kondal R
EDK II Python development process specification release version 1.0 available now. https://github.com/tianocore-docs/edk2-PythonDevelopmentProcessSpecification/tree/release/1.0 Thanks, Kondal. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onli

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

2020-04-20 Thread Purma, Kondal R
Even though submodule approach solves the problem after detaching BaseTools from edk2, I think maintaining BaseTools with PIP is best possible approach. Using PIP and versioning helps to easy environment setup for users over submodule with TAG approach. Moving all non-python based tools to p

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

2020-04-25 Thread Purma, Kondal R
> Can you please explain the effects of the "pip install -e in more detail? "Pip install -e" basically editable mode feature, means it installs setuptools in development mode. We can install any prjects in editable mode and also supports local or from git or svn supported mode. Pip also suppor

[edk2-devel] EDK II Python development process specification -draft

2020-03-06 Thread Purma, Kondal R
Hi, The draft specification for EDK II Python development process for presentation made earlier now available . Presentation thread : https://edk2.groups.io/g/announce/message/92 Wiki Page link for specification document: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Draft-Spec

Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-07 Thread Purma, Kondal R
Thanks for feedback an your are exactly right. This applies for new module/project and every point you mentioned is valid. We should also make sure these rules applies to bug fixes, or code adding as feature in existing files. I raised all these question my self and taken initial step. As a fi

Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-11 Thread Purma, Kondal R
Thank you so much Rebecca. Will fix it. --Kondal. From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Tuesday, March 10, 2020 1:06 PM To: devel@edk2.groups.io; Purma, Kondal R Subject: Re: [edk2-devel] EDK II Python development process specification -draft I just noticed a typo on the

Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-14 Thread Purma, Kondal R
Thanks for feedback so far. Reminder to get more valuable feedback if any, to address before enforcing this spec next week. Plan is to make  initial version of spec along with other specifications and start working on Sean feedback and how to start enforcing the specification. -=-=-=-=-=-=-=-=-=

Re: [edk2-devel] RFC for Edk2-Library

2019-06-11 Thread Purma, Kondal R
Hi Sean , Its great that all python files must pass flake8 Python Style. I remember flake8 does not show errors for undefined member variables or instances . I feel this is one of most common use cases of code failures, due to typing errors and won't be visible unless test that use case. Are

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-06-11 Thread Purma, Kondal R
Hi Sean , Sorry I replied to wrong subject and it's about ToolEnv. It's great that all python files must pass flake8 Python Style. I remember flake8 does not show errors for undefined member variables or instances . I feel this is one of most common use cases of code failures, due to typing e