Reviewed-by: Rodrigo Gonzalez del Cueto
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112055): https://edk2.groups.io/g/devel/message/112055
Mute This Topic: https://groups.io/mt/102974261/21656
Group Owner: devel+ow...@edk2.groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077
Following the design described in the TCG specification,
the driver implementation of the CRB protocol does not require
enforcing completing the transition to goIdle at the end of a command
sequence.
Signed-off-by: "Gonzalez Del Cueto, Rodr
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
TPM must go to Idle state on CRB command completion by rodrigog-intel · Pull
Request #2320 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2320 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You rec
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
Reallocate TPM Active PCRs based on platform support by rodrigog-intel · Pull
Request #2322 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2322 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You re
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
Debug code to audit BIOS TPM extend operations by rodrigog-intel · Pull Request
#2321 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2321 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
between the
TpmActivePcrBanks and the PcdTcg2HashAlgorithmBitmap populated by the
HashLib instances present on the platform's BIOS.
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c
TPM device.
See: TCG PC Client Device Driver Design Principles for TPM 2.0,
Version 1.0, Rev 0.27
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2858
In V2: Fixed patch format and uncrustify cleanup
In V1: Add debug functionality to examine TPM extend operations
performed by BIOS and inspect the PCR 00 value prior to
any BIOS measurements.
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc
PcdTcg2HashAlgorithmBitmap populated by the
HashLib instances present on the platform's BIOS.
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c | 6
+-
SecurityPkg/Library/HashLibBaseCryptoR
on the supported hashing algorithms
> registered by the HashLib instances.
>
> Need to have an additional check for the intersection between the
> TpmActivePcrBanks and the PcdTcg2HashAlgorithmBitmap populated by the
> HashLib instances present on the platform's BIOS.
>
> Signed-off-by:
for TPM 2.0,
> Version 1.0, Rev 0.27
>
> Signed-off-by: Rodrigo Gonzalez del Cueto
>
> Cc: Jian J Wang
> Cc: Jiewen Yao
> ---
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff
extend operations
> performed by BIOS and inspect the PCR 00 value prior to
> any BIOS measurements.
>
> Replaced usage of EFI_D_* for DEBUG_* definitions in debug
> messages.
>
> Signed-off-by: Rodrigo Gonzalez del Cueto
>
> Cc: Jiewen Yao
> Cc:
location is occurring based on the supported hashing algorithms
> registered by the HashLib instances.
>
> Need to have an additional check for the intersection between the
> TpmActivePcrBanks and the PcdTcg2HashAlgorithmBitmap populated by the
> HashLib instances present on the platform'
instances.
Need to have an additional check for the intersection between the
TpmActivePcrBanks and the PcdTcg2HashAlgorithmBitmap populated by the
HashLib instances present on the platform's BIOS.
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Li
Missed adding the Bugzilla reference to the patch.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3463
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78448): https://edk2.groups.io/g/devel/message/78448
Mute This Topic: https://grou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2858
Add debug functionality to examine TPM extend operations
performed by BIOS and inspect the PCR 00 value prior to
any BIOS measurements.
Replaced usage of EFI_D_* for DEBUG_* definitions in debug
messages.
Signed-off-by: Rodrigo Gonzalez
BIOS.
Change-Id: I1cdabe14a4fb5adfc289a2dd60f1b467c64282ac
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 18 +-
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 +
2 files changed, 18 insertions(+), 1 deletion(-)
diff --
: Rodrigo Gonzalez del Cueto
Cc: Jian J Wang
Cc: Jiewen Yao
---
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
index
will review and give comment to the latest version.
>
> Thank you
> Yao Jiewen
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of
> Rodrigo
> > Gonzalez del Cueto
> > Sent: Tuesday, July 21, 2020 5:27 AM
> >
directly from the Tpm2GetCapabilityPcrs()
TPML_PCR_SELECTION output.
The counter should only take into account those PCRs banks
which are active.
Replaced usage of EFI_D_* for DEBUG_* definitions in debug
messages.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Signed-off-by: Rodrigo Gonzalez del
Cc: Qi Zhang
Signed-off-by: Rodrigo Gonzalez del Cueto
---
SecurityPkg/Include/Library/Tpm2CommandLib.h | 25 +-
.../Library/Tpm2CommandLib/Tpm2Integrity.c| 468 --
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 32 +-
3 files changed, 364 insertions(+), 161 deletions
Gonzalez del Cueto
---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 46
+-
1 file changed, 29 insertions(+), 17 deletions(-)
diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
[PATCH 5] Split up TpmPlatformHierarchyLib from Tcg2PlatformDxe modifications
[PATCH 1/2] Add new library class TpmPlatformHierarchyLib
[PATCH 2/2] Add usage in Tcg2PlatformDxe
Rodrigo Gonzalez del Cueto (2):
MinPlatformPkg: Library for customizing TPM platform hierarchy
MinPlatformPkg
should enable to customize
the configuration of the TPM platform, provisioning of endorsement,
platform and storage hierarchy.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Rodrigo Gonzalez del Cueto
---
.../Include/Library/TpmPlatformHierarchyLib.h | 29
Hierarchy.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Rodrigo Gonzalez del Cueto
---
.../Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.c | 168 +++---
.../Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf | 12 +-
2 files changed, 24 insertions(+), 156
, provisioning of endorsement,
platform and storage hierarchy.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Rodrigo Gonzalez del Cueto
---
.../Include/Library/TpmPlatformHierarchyLib.h | 29 +++
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 2
[PATCH 4] Split up TpmPlatformHierarchyLib from Tcg2PlatformDxe modifications
[PATCH 1/2] Introduction of TpmPlatformHierarchyLib
[PATCH 2/2] Modification on Tcg2PlatformDxe to use TpmPlatformHierarchyLib
Rodrigo Gonzalez del Cueto (2):
MinPlatformPkg: Library for customizing TPM platform
ned-off-by: Rodrigo Gonzalez del Cueto
---
.../Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.c | 168 +++---
.../Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf | 12 +-
2 files changed, 24 insertions(+), 156 deletions(-)
diff --git
a/Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2Platfo
figuration of the TPM platform, provisioning of endorsement,
platform and storage hierarchy.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Rodrigo Gonzalez del Cueto
---
.../Include/Library/TpmPlatformHierarchyLib.h | 29 +++
.../Intel/MinP
orm and storage hierarchy.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Rodrigo Gonzalez del Cueto
---
.../Include/Library/TpmPlatformAuthLib.h | 24 ++
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 +
.../Intel/MinPlatformPkg/MinPlatform
30 matches
Mail list logo
