Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-29 Thread Rohit Mathew
Hi, Gentle reminder on the series. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, July 15, 2024 8:57 AM > To: Sami Mujawar ; devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Tho

Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-15 Thread Rohit Mathew
Hi Sami, I have added these as well. Regards, Rohit > -Original Message- > From: Sami Mujawar > Sent: Tuesday, July 9, 2024 9:11 AM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abraham > ; James Morse ; Ray &g

Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-09 Thread Rohit Mathew
: Tuesday, July 9, 2024 8:16 AM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abraham > ; James Morse ; Ray > Ni ; Zhichao Gao ; nd > > Subject: Re: [PATCH V6 0/6] MPAM ACPI definitions and parser > > Hi Rohit, > > Edk2

[edk2-devel] [PATCH V6 6/6] ShellPkg/AcpiView: Add MPAM Parser

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew Cc

[edk2-devel] [PATCH V6 5/6] ShellPkg: acpiview: Add routines to print reserved fields

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Most of the ACPI tables have fields that are marked reserved. Implement functions "DumpReserved" and "DumpReservedBits" aligning with the print-formatter prototype to print out reserved fields. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar

[edk2-devel] [PATCH V6 4/6] ShellPkg: acpiview: Add routine to print 16 chars

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc

[edk2-devel] [PATCH V6 3/6] ShellPkg/AcpiView: Update print-formatter prototype

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew As of now, the print-formatter implemented by the FNPTR_PRINT_FORMATTER function pointer takes two parameters, the format string and the pointer to the field. For cases where the print-formatter has to have access to the length of the field, there is no clean way to currently

[edk2-devel] [PATCH V6 2/6] ShellPkg/AcpiView: Update field-validator prototype

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew As of now, the field-validator implemented by FNPTR_FIELD_VALIDATOR function pointer takes two parameters, the pointer to the field and a context pointer. For cases where the validator has to have access to the length of the field, there is no clean way to currently do it. In

[edk2-devel] [PATCH V6 1/6] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2024-07-08 Thread Rohit Mathew
Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhiguang Liu Acked-by: Liming Gao Reviewed-by: Pierre Gondois Reviewed-by

[edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-08 Thread Rohit Mathew
-arm/edk2/tree/mpam_acpi_v6 CI results/PR can be found at: https://github.com/tianocore/edk2/pull/5888 [1] https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/snapshot/v6.7-rc2 Rohit Mathew (6): MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

Re: [edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser

2023-11-20 Thread Rohit Mathew
Hi, Gentle reminder on the series. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, October 2, 2023 6:14 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abr

[edk2-devel] [PATCH v5 6/6] ShellPkg/AcpiView: Add MPAM Parser

2023-10-02 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew Cc: James Morse Cc

[edk2-devel] [PATCH v5 5/6] ShellPkg: acpiview: Add routines to print reserved fields

2023-10-02 Thread Rohit Mathew
Most of the ACPI tables have fields that are marked reserved. Implement functions "DumpReserved" and "DumpReservedBits" aligning with the print-formatter prototype to print out reserved fields. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abra

[edk2-devel] [PATCH v5 4/6] ShellPkg: acpiview: Add routine to print 16 chars

2023-10-02 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham Cc

[edk2-devel] [PATCH v5 3/6] ShellPkg/AcpiView: Update print-formatter prototype

2023-10-02 Thread Rohit Mathew
resolve this, update the print-formatter's prototype to take the length of the field as a third parameter. This change should improve the overall robustness and flexibility of AcpiView. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhichao Gao --- She

[edk2-devel] [PATCH v5 2/6] ShellPkg/AcpiView: Update field-validator prototype

2023-10-02 Thread Rohit Mathew
e the overall robustness and flexibility of AcpiView. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhichao Gao --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 6 +-- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiPar

[edk2-devel] [PATCH v5 1/6] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-10-02 Thread Rohit Mathew
From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhiguang Liu Acked-by: Liming Gao Reviewed-by: Pierre

[edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser

2023-10-02 Thread Rohit Mathew
found at: https://github.com/tianocore/edk2/pull/4748 [1] https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/snapshot/v6.5-rc1 Rohit Mathew (6): MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification ShellPkg/AcpiView: Update field-validator prototype

[edk2-devel] [PATCH V4 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-08-18 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew Cc: James Morese Cc

[edk2-devel] [PATCH v4 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-08-18 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew Cc: James Morese Cc: Sami Mujawar Cc: Thomas Abraham Cc

[edk2-devel] [PATCH V4 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-08-18 Thread Rohit Mathew
From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew Cc: James Morese Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhiguang Liu Acked-by: Liming Gao Reviewed-by: Pierre

[edk2-devel] [PATCH V4 0/3] MPAM ACPI definitions and parser

2023-08-18 Thread Rohit Mathew
://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/snapshot/v6.5-rc1 Rohit Mathew (3): MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification ShellPkg: acpiview: Add routine to print 16 chars ShellPkg/AcpiView: Add MPAM Parser MdePkg/Include/IndustryStandard

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-08-08 Thread Rohit Mathew
Hi Pierre > -Original Message- > From: Rohit Mathew > Sent: Monday, August 7, 2023 1:45 PM > To: Pierre Gondois ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao ; nd > > Subject: RE: [edk2-devel] [PATCH V3

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-08-07 Thread Rohit Mathew
Hi Pierre, > -Original Message- > From: Pierre Gondois > Sent: Friday, August 4, 2023 12:20 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao ; nd > > Subject: Re: [edk2-devel] [PATCH V3

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-07-31 Thread Rohit Mathew
Hi Pierre, Apologies for the delay in response. ~~ > > + > > +/** > > + This function parses the locator field within the resource node for > ACPI > MPAM > > + table. The parsing is based on the locator type field. > > + > > + This function also performs validatio

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-07-24 Thread Rohit Mathew
Hi Pierre, Thank you for the response. Few comments inline - > -Original Message- > From: Pierre Gondois > Sent: Monday, July 24, 2023 3:40 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-07-24 Thread Rohit Mathew
Hi Pierre, > -Original Message- > From: Pierre Gondois > Sent: Monday, July 24, 2023 3:40 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abraham > ; Sami Mujawar ; > James Morse ; nd > Subject: Re: [edk2-d

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-07-24 Thread Rohit Mathew
Hi Pierre, Thank you for the review. Please find my response inline. > > Hello Rohit, > > On 5/22/23 16:44, Rohit Mathew via groups.io wrote: > > From: Rohit Mathew > > > > Add definitions, macros and types for elements associated with MPAM > > ACPI 2.0

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-07-24 Thread Rohit Mathew
Hi Pierre, Thank you for the detailed review. Please find my response inline. > On 5/22/23 16:45, Rohit Mathew via groups.io wrote: > > Add a parser for the MPAM (Memory system resource partitioning and > > monitoring) ACPI table. This parser would parse all MPAM related > >

Re: [edk2-devel] [PATCH V3 0/3] MPAM ACPI definitions and parser

2023-07-18 Thread Rohit Mathew
Hi, Gentle reminder on the series. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, May 22, 2023 3:44 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abr

[edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-05-22 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew --- ShellPkg/Library

[edk2-devel] [PATCH V3 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-05-22 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew --- ShellPkg/Library/UefiShellAcpiViewCommandLib

[edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-05-22 Thread Rohit Mathew
From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryStandard/Acpi65.h | 7 +- MdePkg/Include/IndustryStandard/Mpam.h | 260 2 files changed, 266

[edk2-devel] [PATCH V3 0/3] MPAM ACPI definitions and parser

2023-05-22 Thread Rohit Mathew
since V2: - Addressed comments related to Interface/Link type defintions from Sami. Changes can be found at: https://github.com/rohit-arm/edk2/tree/mpam_acpi [1] https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/snapshot/v6.2 Rohit Mathew (3): MdePkg/IndustryStandard

Re: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-22 Thread Rohit Mathew
Hi Sami, Thank you for the review. Please find my comments inline. Regards, Rohit From: Sami Mujawar Sent: Monday, May 22, 2023 1:17 PM To: Rohit Mathew ; devel@edk2.groups.io Cc: Michael D Kinney ; Liming Gao ; Thomas Abraham ; James Morse ; nd Subject: Re: [PATCH V2 1/3] MdePkg

[edk2-devel] [PATCH V2 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-05-18 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew --- ShellPkg/Library

[edk2-devel] [PATCH V2 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-05-18 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew --- ShellPkg/Library/UefiShellAcpiViewCommandLib

[edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-18 Thread Rohit Mathew
From: Rohit Mathew add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryStandard/Acpi65.h | 7 +- MdePkg/Include/IndustryStandard/Mpam.h | 258 2 files changed, 264

[edk2-devel] [PATCH V2 0/3] MPAM ACPI definitions and parser

2023-05-18 Thread Rohit Mathew
github: https://github.com/rohit-arm/edk2/tree/mpam_acpi [1] https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/snapshot/v6.2 Rohit Mathew (3): MdePkg/IndustryStandard: add definitions for MPAM ACPI specification ShellPkg: acpiview: Add routine to print 16 chars

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-03-30 Thread Rohit Mathew
Thanks Sami, Michael, Liming for the review/ack. I'll post a V2 with the comments addressed. Let me also work on the Acpi parser for the same. Regards, Rohit > -Original Message- > From: Sami Mujawar > Sent: Wednesday, March 29, 2023 10:57 AM > To: Rohit Mathew ; dev

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-03-27 Thread Rohit Mathew
Hi all, Gentle reminder on the patch. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, February 13, 2023 9:01 PM > To: devel@edk2.groups.io > Cc: 'Michael D Kinney' ; Sami Mujawar

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-02-13 Thread Rohit Mathew
Hi all, Gentle reminder on the patch. Thanks, Rohit > -Original Message- > From: gaoliming > Sent: 29 January 2023 05:39 > To: Rohit Mathew ; devel@edk2.groups.io > Cc: 'Michael D Kinney' ; Sami Mujawar > ; 'Zhiguang Liu' ; > Thomas Abraham

[edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-01-24 Thread Rohit Mathew
add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryStandard/Acpi64.h | 7 +- MdePkg/Include/IndustryStandard/Mpam.h | 229 2 files changed, 235 insertions(+), 1 deletion

Re: [edk2-devel] [PATCH 1/2] MdePkg: Support for MPAM ACPI Table

2023-01-16 Thread Rohit Mathew
Hi Swatisri, Just wanted to check if you would still be interested in posting MPAM ACPI 2.0 header? If you are caught up with something else, I could try to post a patch for the same. Regards, Rohit From: devel@edk2.groups.io On Behalf Of Sami Mujawar via groups.io Sent: 03 October 2022 14:0

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-24 Thread Rohit Mathew
Hi Hesham, The idea for keeping it as separate type was to abstract locator field to have a view similar to that of its definition in the spec (MPAM ACPI 1.0, section 2.2, table 7 - Resource node.) Something of the lines – typedef struct { UINT32 Identifier; UINT8

Re: [edk2-devel] [PATCH 2/2] Dynamic Tbl Mgr: MPAM: MPAM Generator and supporting files

2022-08-24 Thread Rohit Mathew
Hi Swatisri, I have dropped comments on the Flag's type based on Andrew's feedback. Regards, Rohit > -Original Message- > From: Rohit Mathew > Sent: 19 August 2022 09:26 > To: devel@edk2.groups.io; usern...@nvidia.com; Sami Mujawar > ; Alexei Fedorov ; >

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-24 Thread Rohit Mathew
blic interfaces. > > Given there is lots of code 1st kind of things going on I’d figured I’d > mention this. > > Thanks, > > Andrew Fish > > > On Aug 23, 2022, at 2:28 PM, Rohit Mathew wrote: > > > > Hi Andrew, > > > >

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-23 Thread Rohit Mathew
Hi Andrew, From: Andrew Fish Sent: 23 August 2022 21:11 To: devel@edk2.groups.io; Rohit Mathew Cc: usern...@nvidia.com; Sami Mujawar ; Alexei Fedorov ; Mike Kinney ; gaolim...@byosoft.com.cn; zhiguang@intel.com; Swatisri Kantamsetti ; Thomas Abraham ; Thanu Rangarajan ; nd Subject: Re

Re: [edk2-devel] [PATCH 2/2] Dynamic Tbl Mgr: MPAM: MPAM Generator and supporting files

2022-08-19 Thread Rohit Mathew
Hi Swatisri, Thanks for the patch. Please find my comments inline marked [Rohit] - > -Original Message- > From: devel@edk2.groups.io On Behalf Of Name > via groups.io > Sent: 16 August 2022 21:18 > To: devel@edk2.groups.io; Sami Mujawar ; > Alexei Fedorov ; michael.d.kin...@intel.com; >

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-19 Thread Rohit Mathew
Hi Swatisri, Thanks for the patch. Please find my comments inline marked [Rohit] - > -Original Message- > From: devel@edk2.groups.io On Behalf Of Name > via groups.io > Sent: 16 August 2022 21:18 > To: devel@edk2.groups.io; Sami Mujawar ; > Alexei Fedorov ; michael.d.kin...@intel.com; >

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-08-17 Thread Rohit Mathew
Thanks Sami. Regards, Rohit From: Sami Mujawar Sent: 17 August 2022 10:46 To: Rohit Mathew ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi Rohit, Apologies for the delay. I will pick this up once the merge window opens

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-08-17 Thread Rohit Mathew
Gentle reminder for this patch series. Regards, Rohit From: Rohit Mathew Sent: 02 August 2022 14:51 To: devel@edk2.groups.io; Sami Mujawar Cc: Thanu Rangarajan ; Thomas Abraham ; nd Subject: RE: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi Sami, Gentle

Re: [edk2-devel] [edk2][PATCH V4 1/1] ArmPlatformPkg/PrePeiCore: Invoke constructors for SEC phase

2022-08-09 Thread Rohit Mathew
2:12 > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Rebecca Cran > ; Pierre Gondois ; Thomas > Abraham ; nd > Subject: Re: [edk2][PATCH V4 1/1] ArmPlatformPkg/PrePeiCore: Invoke > constructors for SEC phase > > Hi Rohit, > > This patch looks goo

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-08-02 Thread Rohit Mathew
Hi Sami, Gentle reminder for this patch series. Regards, Rohit. From: devel@edk2.groups.io On Behalf Of Rohit Mathew via groups.io Sent: 25 July 2022 15:56 To: Thanu Rangarajan ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-25 Thread Rohit Mathew
> > > > Regards, > > > > Thanu > > > > *From:* Sami Mujawar > *Date:* Monday, 25 July 2022 at 16:12 > *To:* Rohit Mathew , "devel@edk2.groups.io" > > *Cc:* Thanu Rangarajan , nd > *Subject:* Re: [edk2-devel] [PATCH 2/2] Platform/

Re: [edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-07-22 Thread Rohit Mathew
Hi Sami, On Thu, Jul 21, 2022 at 05:26 PM, Sami Mujawar wrote: > > Hi Rohit, > > On Wed, Jul 6, 2022 at 06:42 AM, Rohit Mathew wrote: > >> =20 >> @@ -86,6 +86,10 @@ CEntryPoint ( >> ArmEnableVFP (); >> } >> =20 >> + // Explicitly in

Re: [edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-07-22 Thread Rohit Mathew
Hi Sami, Thank you for the review. Please find my response inline - On Thu, Jul 21, 2022 at 04:55 PM, Sami Mujawar wrote: > > > > Hi Rohit, > > > > Please find my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar

[edk2-devel] [edk2][PATCH V4 1/1] ArmPlatformPkg/PrePeiCore: Invoke constructors for SEC phase

2022-07-22 Thread Rohit Mathew
ve all the dependent library constructors called (this includes a call to "SerialPortInitialize"). Signed-off-by: Rohit Mathew --- ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 12 +++- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 6 +- 2 files changed, 16 insertions(+), 2

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-22 Thread Rohit Mathew
oving to use Dynamic Tables Framework? There is > just too much repetition in this series which can be easily avoided. It > will also make the code more maintainable. > > Apart from this I have a comment marked inline as [SAMI]. > > Regards, > > Sami Mujawar > >

Re: [edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-07-18 Thread Rohit Mathew
Hi Team, Gentle reminder for this patch. Regards, Rohit On Wed, Jul 6, 2022 at 03:20 PM, Thomas Abraham wrote: > > On 06/07/2022 14:42, Rohit Mathew wrote: > >> Invoke the constructor in the SEC phase to call into initialization >> functions associated with libra

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage

2022-07-18 Thread Rohit Mathew
Hi Team, Gentle reminder for this patch set. Regards, Rohit On Mon, Jul 4, 2022 at 05:59 PM, Rohit Mathew wrote: > > Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of > consoles") setup the routing of console messages to a different set > of UART ports.

[edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-07-06 Thread Rohit Mathew
initialize uart for SEC phase. Signed-off-by: Rohit Mathew --- ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 11 ++- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 6 +- 2 files changed, 15 insertions(+), 2 deletions(-) Changes since V1: - Rebased on top of latest master branch. - Addressed com

[edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-04 Thread Rohit Mathew
Add a new device entry in the SSDT ACPI table to describe the serial port used as the debug port. On the Neoverse reference design platforms, the UART0 port of the SoC is used as the debug port. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 1

[edk2-devel] [PATCH 1/2] Platform/Sgi: Update ACPI tables to use console UART

2022-07-04 Thread Rohit Mathew
Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of consoles") assigns different address for the console UART and the debug UART. Correspondingly, update the SPCR and SSDT ACPI tables to use the address of the console UART port instead of the debug UART port. Signed-off

[edk2-devel] [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage

2022-07-04 Thread Rohit Mathew
vice entry for the debug UART. Link to github branch for the patches in this series - https://github.com/rohit-arm/edk2-platforms/tree/serial_port_acpi Rohit Mathew (2): Platform/Sgi: Update ACPI tables to use console UART Platform/Sgi: Add serial debug controller to SSDT .../SgiPkg/

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-22 Thread Rohit Mathew
Hi Thomas, I have addressed the comments in V3. On Mon, Jun 20, 2022 at 06:29 PM, Thomas Abraham wrote: > > Hi Rohit, > > On 20/06/2022 16:25, Rohit Mathew via groups.io wrote: > >> Route secure (from secure partition) and non-secure console messages >> to dif

[edk2-devel] [edk2-platforms][PATCH V3 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-22 Thread Rohit Mathew
platforms. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 6 +++--- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 3 ++- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 3 ++- Platform/ARM/SgiPkg

[edk2-devel] [edk2-platforms][PATCH V3 0/2] Uart segregation patch series

2022-06-22 Thread Rohit Mathew
grouping of uart related PCDs for all Neoverese reference design platforms Dependency: https://edk2.groups.io/g/devel/message/90674 Link to github branch with the patches in this series - https://github.com/rohit-arm/edk2-platforms/tree/uart_segregation Rohit Mathew (2): Platform/Sgi: Remove

[edk2-devel] [edk2-platforms][PATCH V3 1/2] Platform/Sgi: Remove redundant platform description from DSDT

2022-06-22 Thread Rohit Mathew
Remove redundant platform descriptions (descriptions which are already part of SSDT) from DSDT for SGI-575 platform. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 66 +--- 1 file changed, 1 insertion(+), 65 deletions(-) diff --git a/Platform

[edk2-devel] [edk2-platforms][PATCH V2 0/2] Uart segregation patch series

2022-06-20 Thread Rohit Mathew
design platforms Link to github branch with the patches in this series - https://github.com/rohit-arm/edk2-platforms/tree/uart_segregation Rohit Mathew (2): Platform/Sgi: Remove redundant platform description from DSDT Platform/Sgi: Route logs to different sets of consoles Platform/ARM/SgiPkg

[edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-20 Thread Rohit Mathew
platforms. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 ++-- Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 ++-- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 6 -- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 3 ++- Platform/ARM/SgiPkg

[edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/Sgi: Remove redundant platform description from DSDT

2022-06-20 Thread Rohit Mathew
Remove redundant platform descriptions (descriptions which are already part of SSDT) from DSDT for SGI-575 platform. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 66 +--- 1 file changed, 1 insertion(+), 65 deletions(-) diff --git a/Platform

[edk2-devel] [edk2][PATCH V2 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-06-20 Thread Rohit Mathew
rt for SEC. Signed-off-by: Rohit Mathew --- ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 11 ++- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 5 - 2 files changed, 14 insertions(+), 2 deletions(-) Changes since V1: - Rebased on top of latest master branch. - Addressed comments from Ard. Link

Re: [edk2-devel] [edk2][PATCH V1 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-06-20 Thread Rohit Mathew
Hi Ard, Apologies, I missed your response. On Tue, May 3, 2022 at 09:43 AM, Ard Biesheuvel wrote: > > (+ Rebecca) > > On Tue, 8 Mar 2022 at 12:55, Rohit Mathew wrote: > >> PrePeiCore's CEntry function calls DebugLib library's print API before >> the l

[edk2-devel] [edk2-platforms][PATCH V1 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-03-09 Thread Rohit Mathew
platforms. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 ++-- Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 ++-- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 6 -- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 3 ++- Platform/ARM/SgiPkg

[edk2-devel] [edk2-platforms][PATCH V1 0/2] Uart segregation patch series

2022-03-09 Thread Rohit Mathew
/rohit-arm/edk2-platforms/tree/uart_segregation Rohit Mathew (2): Platform/Sgi: Remove redundant platform description from DSDT Platform/Sgi: Route logs to different sets of consoles Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 +-- Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8

[edk2-devel] [edk2-platforms][PATCH V1 1/2] Platform/Sgi: Remove redundant platform description from DSDT

2022-03-09 Thread Rohit Mathew
Remove redundant platform descriptions (descriptions which are already part of SSDT) from DSDT for SGI-575 platform. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 64 1 file changed, 64 deletions(-) diff --git a/Platform/ARM/SgiPkg

[edk2-devel] [edk2-platforms][PATCH V1 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-03-08 Thread Rohit Mathew
rt for SEC. Signed-off-by: Rohit Mathew --- ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 11 ++- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 9 +++-- 2 files changed, 17 insertions(+), 3 deletions(-) Link to github branch with the patches in this series - https://github.com/rohit-arm