expected to be applied on top of
the patch at:
ArmPkg: Fix GicV2 BaseAddress types
(https://edk2.groups.io/g/devel/message/104721)
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1751_arm_giclib_v1
Sami Mujawar (12):
ArmPkg: Fix data type used for GicDistributorBase
ArmPkg
Hi Rohit,
Please send an updated series with the issues fixed.
Regards,
Sami Mujawar
From: Rohit Mathew
Date: Monday, 22 May 2023 at 14:08
To: Sami Mujawar , "devel@edk2.groups.io"
Cc: Michael D Kinney , Liming Gao
, Thomas Abraham , James
Morse , nd
Subject: RE: [PATCH V2 1
Hi Rohit,
Just to be clear, I am looking at the following spec
https://documentation-service.arm.com/static/638757e5e1ed1c2162fc75b2?token=
Regards,
Sami Mujawar
On 22/05/2023 01:16 pm, Sami Mujawar wrote:
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/05/2023 04:06 pm, Rohit Mathew wrote:
From: Rohit Mathew
add definitions, macros and types for elements associated with MPAM
ACPI 2.0 specification.
Signed-off-by: Rohit Mathew
---
MdePkg/Include
ed runtime variable support, but do not
enable it by default.
The firmware is expected to dynamically discover if the CFI
flash is present and subsequently enable NorFlash or emulate
the runtime variables.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +-
1 file changed, 5
dispatched.
Also link the NorFlashKvmtoolLib as a NULL library so that
it can discover if the CFI flash is absent and setup the PCD
PcdEmuVariableNvModeEnable. This is required in case the
NorFlashDxe is not yet dispatched.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc
initialise the value at runtime. Therefore, move the PCD declaration
from the [FixedPcd] section to the [Pcd] section in the platform
boot manager library file PlatformBootManagerLib.inf. Without this
change the build would not succeed.
Signed-off-by: Sami Mujawar
---
ArmPkg/Library/PlatformBootManagerLib
y is allocated for a new stack
and the stack is switched to use the newly allocated stack
for the Dxe phase.
Therefore, specify 128 KiB as the stack size in the call to
LoadDxeCoreFromFv () so that a separate stack is allocated
and used for the Dxe phase.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/
are resent with the v2 series.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2646_dynamic_cfi_detection_v2
Sami Mujawar (5):
ArmPkg: Configure PcdEmuVariableNvModeEnable as a dynamic PCD
ArmVirtPkg: Define variables for emulating runtime variables
ArmVirtPkg: Fallback t
e for UEFI variables. To support this
the PCD gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable
must be set to TRUE.
Therefore, update the NorFlashKvmtoolLib to fallback to variable
emulation if a CFI device is not detected. Also improve the error
logging.
Signed-off-by: Sa
ughts about this.
[/SAMI]
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105038): https://edk2.groups.io/g/devel/message/105038
Mute This Topic: https://groups.io/mt/98987538/21656
Group Owner: devel+ow...@edk2.
Hi Ard,
Thank you for the feedback and for the pointers.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/05/2023 12:01 pm, Ard Biesheuvel via groups.io wrote:
On Thu, 18 May 2023 at 11:10, Sami Mujawar wrote:
The patch "f07a9df9af60 ArmVirtPkg: Enable stack
initialise the value at runtime. Therefore, move the PCD declaration
from the [FixedPcd] section to the [Pcd] section in the platform
boot manager library file PlatformBootManagerLib.inf. Without this
change the build would not succeed.
Signed-off-by: Sami Mujawar
---
ArmPkg/Library/PlatformBootManagerLib
scadeProcessVariables ()
which apparently consumes the available stack space and
overflows.
Therefore, increase the primary core stack size.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmVirtPkg/ArmV
e for UEFI variables. To support this
the PCD gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable
must be set to TRUE.
Therefore, update the NorFlashKvmtoolLib to fallback to variable
emulation if a CFI device is not detected. Also improve the error
logging.
Signed-off-by: Sa
ed runtime variable support, but do not
enable it by default.
The firmware is expected to dynamically discover if the CFI
flash is present and subsequently enable NorFlash or emulate
the runtime variables.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +-
1 file changed, 5
/edk2/tree/2646_dynamic_cfi_detection_v1
Sami Mujawar (6):
ArmPkg: Configure PcdEmuVariableNvModeEnable as a dynamic PCD
ArmVirtPkg: Define variables for emulating runtime variables
ArmVirtPkg: Fallback to variable emulation if no CFI is found
ArmVirtPkg: Dispatch variable service if variable
dispatched.
Also link the NorFlashKvmtoolLib as a NULL library so that
it can discover if the CFI flash is absent and setup the PCD
PcdEmuVariableNvModeEnable. This is required in case the
NorFlashDxe is not yet dispatched.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc
scadeProcessVariables ()
which apparently consumes the available stack space and
overflows.
Therefore, increase the primary core stack size.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmVirtPkg/A
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/05/2023 06:57 pm, Leif Lindholm via groups.io wrote:
The GIC addresses as currently declared as FixedPcd for SbsaQemu.
Change them to dynamic, to enable future patches
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/05/2023 06:57 pm, Leif Lindholm via groups.io wrote:
gArmTokenSpaceGuid.PcdGicDistributorBase and
gArmTokenSpaceGuid.PcdGicRedistributorsBase are both defined as UINT64
Hi Minh,
Thank you for this patch.
This fix looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/05/2023 08:08 am, Minh Nguyen wrote:
This helps to remove redundant assign for SmbiosHandle.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Minh
Hi Minh,
Thank you for this fix.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/05/2023 08:08 am, Minh Nguyen wrote:
To iterate entire SMBIOS table records for searching specific records,
"SmbiosHandle" input need to be as "SMBIOS_HAN
Hi Ard,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 13:09, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:05, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
>
Hi Ard,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 12:39, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
>
Hi Ard,
Thank you for the feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 12:33, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
> Alt
On Tue, Apr 25, 2023 at 09:04 AM, Sami Mujawar wrote:
>
> +/** RSI interface Version
> + See Section B4.4.3, RMM Specification, version A-bet0.
> + The width of the RsiInterfaceVersion fieldset is 64 bits.
> +*/
> +#define RSI_VER_MINOR_MASK 0x00FFULL
> +#define RSI_VER
Merged as d39c665fe302..35a84b1838ba
Thanks.
Sami Mujawar
On 02/05/2023 09:32 am, sahil wrote:
V2 delta changes:
Split the patch in two for Platform/ARM/N1Sdp and Silicon/ARM/NeoverseN1Soc
sahil (2):
Platform/ARM/N1Sdp: Fix RemoteDdrSize cast
Silicon/ARM/NeoverseN1Soc: Fix
Hi Sahil,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/05/2023 09:32 am, sahil wrote:
V2 delta changes:
Split the patch in two for Platform/ARM/N1Sdp and Silicon/ARM/NeoverseN1Soc
sahil (2):
Platform/ARM/N1Sdp: Fix RemoteDdrSize cast
Silicon/ARM
Merged as 24d22fe163c4..64b06a4d19ad
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103714): https://edk2.groups.io/g/devel/message/103714
Mute This Topic: https://groups.io/mt/96197163/21656
Group Owner
Merged as 0ed7b18b92e4..24d22fe163c4
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103711): https://edk2.groups.io/g/devel/message/103711
Mute This Topic: https://groups.io/mt/97470584/21656
Group Owner
Hi Jose,
Thank you for this patch.
I have some minor updates that I will do before merging. These include a
note to indicate that the same FVP firmware binary can be used for both
FVP Base AEMvA-AEMvA and FVP Base RevC models.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 08/03
Merged as 8758130fdbbb..0ed7b18b92e4
Thanks.
Regards,
Sami Mujawar
On 24/03/2023 11:02 am, Vivek Gautam wrote:
Arm reference design Fixed Virtual Platforms (FVPs) such as the RD-N2
platform variants have multiple IO virtualization blocks that allow
connecting PCIe root bus or non-PCIe SoC
Hi Vivek,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
For all the RD-N2 platform variants, include the SSDT ACPI table that
describes the devices present in SoC expansion block that is connected
to the IO
Hi Vivek,
Thank you for this patch.
I have some minor feedback that I will address before merging.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
From: Shriram K
The IO virtualization block on reference design platforms allow
connecting SoC
Hi Vivek,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
Arm reference design platforms have multiple IO virtualization blocks
that allow connecting PCIe root bus or non-PCIe SoC peripherals to the
system. Each of these
Hi Vivek,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
Enable the virtio-p9 device that is present as part of the RoS
peripherals on RD-N2 platform variants. This will allow filesystem
Hi Vivek,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/03/2023 11:02 am, Vivek Gautam wrote:
Some of the Arm reference design FVP platforms support the Virtio-p9
device as part of the RoS subsystem. Add an entry for this
Hi Sahil,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 01/02/2023 08:13 am, sahil wrote:
NT_FW_CONFIG DTB contains platform information passed by
Tf-A boot stage.
This information is used for Virtual memory map generation
during PEI phase
- Repo: https://gitlab.arm.com/linux-arm/edk2-cca
- Branch: 2595_arm_cca_0abet0_rfc_v1
- URL:
https://gitlab.arm.com/linux-arm/edk2-cca/-/tree/2595_arm_cca_0abet0_rfc_v1
[13] Building Arm CCA software stack using Shrinkwrap
https://shrinkwrap.docs.arm.com/en/latest/userguide/configstore/cca-3worl
for SMC call.
Signed-off-by: Sami Mujawar
---
ArmPkg/Include/Library/ArmSmcLib.h| 50 ++--
ArmPkg/Library/ArmSmcLib/AArch64/ArmSmc.S | 22 ++---
2 files changed, 62 insertions(+), 10 deletions(-)
diff --git a/ArmPkg/Include/Library/ArmSmcLib.h
b/ArmPkg/Include/Library
protection attribute in ArmMmuLib, defer this to an Arm CCA
specific library so that additional dependencies for
ArmMmuLib can be avoided.
Therefore, export the SetMemoryRegionAttribute () in
ArmMmuLib so that the Realm software can configure the
protection attribute.
Signed-off-by: Sami Mujawar
Add helper function to check if the Realm Management
Extension (RME) is implemented by the hardware.
Signed-off-by: Sami Mujawar
---
ArmPkg/Include/Chipset/AArch64.h | 3 ++-
ArmPkg/Include/Library/ArmLib.h| 15 ++-
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c
operations can be performed by bouncing buffers using pages shared
with the Host. It uses the Realm Aperture Management protocol to
share the buffers with the Host.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmCcaIoMmuDxe/ArmCcaIoMmu.c | 813
ArmVirtPkg/ArmCcaIoMmuDxe
DXE so that the DXE
dispatcher can schedule this to be loaded at the very beginning
of the Dxe phase. The DevicePathDxe.inf and Pcd.inf modules have
also been included to satisfy the required dependencies.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmCcaDxe/ArmCcaDxe.c | 50
side effect as the behaviour
will be similar to that of release builds where the asserts
would be removed.
Signed-off-by: Sami Mujawar
---
MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/BaseRngLib/AArch64
for AArch64 firmware builds. The AArch32 firmware builds
will continue to use BaseRngLibTimerLib.
Note: The guest firmware already supports Virtio RNG. So, should
the processor not implement FEAT_RNG, the guest firmware can fall
back to use Virtio RNG.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg
apertures for sharing buffers.
The RAMP also keeps track of the apertures that have been opened
and closes them on ExitBootServices. It also registers for reset
notification and closes all open apertures before the platform
resets the system.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec
RAMP check if the code is executing
in a Realm before installing the respective protocols. If the
code is not executing in a Realm the gIoMmuAbsentProtocolGuid is
installed, thereby allowing the same firmware to be used both for
normal and Realm Guest firmware.
Signed-off-by: Sami Mujawar
functions to call the Realm
Service Interface.
Therefore, add these libraries in the Kvmtool guest firmware
workspace as part of enabling support for Arm CCA.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 7 +++
1 file changed, 7 insertions(+)
diff
s external
abort being reflected to the Realm by the RMM.
Therefore, link the Null version of DebugLib in PrePi stage.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool
Unprotected IPA.
Note: ArmCcaInitialize () is implemented in ArmCcaInitPeiLib for
which a Null implementation is provided. Therefore, this change
should not break existing platforms that do not implement the
Arm CCA.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/PrePi/PrePi.c | 10 +-
1 file
ArmCcaConfigureMmio () to configure the MMIO regions
by setting the Unprotected IPA attribute in the page tables.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec| 1 +
ArmVirtPkg/Include/Library/ArmCcaInitPeiLib.h| 49 +
ArmVirtPkg/Library
gArmCcaIpaWidthGuid.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec | 1 +
ArmVirtPkg/Include/Library/ArmCcaLib.h | 114
ArmVirtPkg/Library/ArmCcaLib/ArmCcaLib.c | 190
ArmVirtPkg/Library/ArmCcaLib/ArmCcaLib.inf | 34
4 files changed
have an impact for non-Arm CCA enabled systems.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 6 +-
ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 3 ++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/PrePi/AArch64
which configures the MMIO
regions as Unprotected IPA by setting the protection attribute in the
page tables for the MMIO regions.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/KvmtoolVirtMemInfoLib.c | 39
+++-
ArmVirtPkg/Library/KvmtoolVirtMemIn
Add a NULL instance of ArmCcaInitPeiLib library that guest firmware
for VMMs that do not implement Arm CCA Realms can use.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirt.dsc.inc | 2 +
ArmVirtPkg/Library/ArmCcaInitPeiLibNull/ArmCcaInitPeiLibNull.c
RETURN_UNSUPPORTED.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 21
1 file changed, 21 insertions(+)
diff --git a/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
b/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
index
Add a Null instance of ArmCcaLib so that guest firmware that does
not support Arm CCA can link to this Null version of the library.
Also include it in ArmVirt.dsc.inc so that it is linked for the
non-Arm CCA firmware builds.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirt.dsc.inc
.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.c | 21
1 file changed, 21 insertions(+)
diff --git a/ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.c
b/ArmVirtPkg/Library/XenVirtMemInfoLib/XenVirtMemInfoLib.c
index
eMmio () that can be called
during the early firmware startup.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmVirtMemInfoLib.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/ArmVirtPkg/Include/Library/ArmVirtMemInfoLib.h
b/ArmVirtPkg/In
RETURN_UNSUPPORTED.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 22
+++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
b/ArmVirtPkg/Library
Section B4.3.3 RSI_HOST_CALL command.
Also update the ArmCcaRsiLib library to add a new interface
RsiHostCall () to make a Host call.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 36 ++
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h| 1
extend measurements to REMs.
Therefore, update ArmCcaRsiLib to add interfaces to get and extend REMs.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 53
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h| 2 +
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c
on defines the following Realm Service Interfaces for
managing the IPA state:
* RSI_IPA_STATE_GET
* RSI_IPA_STATE_SET
Therefore, update the ArmCcaRsiLib to add interfaces to get and set the
IPA state of Realm memory pages.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmC
-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec
index
0bc7d697428636d42ffb27e8e92fca947665a79e..ebdb9629fa2754e6f8b59f23750ea50cf702d8fd
100644
--- a/ArmVirtPkg/ArmVirtPkg.dec
+++ b
services from the RMM.
Therefore, add a library that implements the RSI interfaces to:
- query the RSI version
- get the Realm configuration.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec| 1 +
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h| 72
attestation token from the RMM.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 42 +
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsi.h| 10 +-
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 193
3 files changed, 241 insertions(+), 4 deletions
variable storage
is desirable.
Therefore, make Emulated Runtime variable storage as the default
option and add a build flag ENABLE_CFI_FLASH to configure the
firmware build to use the CFI Flash as the Variable storage.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 22
move
the PcdMonitorConduitHvc in the PcdsDynamic section to prevent
the build from breaking.
Signed-off-by: Sami Mujawar
---
ArmPkg/ArmPkg.dec| 10 +-
ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.c | 4 ++--
ArmVirtPkg/ArmVirtKvmTool.dsc| 4 ++--
3
Hi Pierre,
Thank you for this patch.
These changes look good to me, other than the change-id in the commit
message (which I will drop before merging the change).
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/03/2023 03:32 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Merged as ab9805e0020b..310d31231d69
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103295): https://edk2.groups.io/g/devel/message/103295
Mute This Topic: https://groups.io/mt/98319017/21656
Group Owner: devel+ow
Hi Leif,
Thank you for reviewing the patch and for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/04/2023 02:30 pm, Leif Lindholm wrote:
Hi Sami,
On Mon, Apr 17, 2023 at 14:22:49 +0100, Sami Mujawar wrote:
For older FVPs (without support for RME
/gitiles/
TF-A/trusted-firmware-a/+/c8720729726faffc39ec64f3a02440a48c8c305a))
Signed-off-by: Sami Mujawar
---
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
b
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/04/2023 02:14 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci
is patch 4/4 in this series.
Is it possible to review the ArmVirtPkg changes and if I have your
approval to merge this series, please?
Regards,
Sami Mujawar
On 20/03/2023 02:05 pm, Sami Mujawar wrote:
This patch series has the following fixes for DynamicTablesPkg and
ArmVirtPkg/Kvmtool:
Hi Rohit,
Thank you for this patch, and apologies for the delay in reply.
I have a few minor suggestions marked inline as [SAMI].
Other than that, I would like to see a corresponding patch to add MPAM
support to Acpiview.
With that addressed,
Reviewed-by: Sami Mujawar
regards,
Sami
Hi Ard,
This patch fixes a build break for the CloudHv firmware.
Can you let me know if I can merge this patch, please?
Regards,
Sami Mujawar
On 28/03/2023, 10:11, "Jianyong Wu" mailto:jianyong...@arm.com>> wrote:
commit f13264b34 introduces a bug for CloudHv as OvmfPk
Hi Jianyong,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 28/03/2023, 09:17, "Jianyong Wu" mailto:jianyong...@arm.com>> wrote:
Hi Sami,
I have never added CI for CloudHv. So, should I add it?
[SAMI] I think you can prepare the patch that adds th
Hi Jianyong,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 28/03/2023, 08:45, "Sunil V L" mailto:suni...@ventanamicro.com>> wrote:
On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote:
> Add Ard Biesheuvel mailto:a...@kernel.org>> and
Hi Jianyong,
Thank you for this fix.
The subject line should have the package name as prefix followed by the short
description for the patch e.g. "ArmVirtPkg: xxx".
Other than that, this change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/03/2
set the memory attributes fails with
error code EFI_NOT_AVAILABLE_YET.
Therefore, set the library dependency on the CPU Arch protocol.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
correct order to fix this issue.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c
b
correct order to fix this issue.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 4
++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
b
ures.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2596_bug_fix_dynamictables_kvmtool_v1
Sami Mujawar (4):
DynamicTablesPkg: Reduce log output from TableHelperLib
DynamicTablesPkg: Fix parsing of serial port node
ArmVirtPkg: Fix parsing of serial port node
ArmVi
Reduce the log output from Configuration Manager Object Parser
in TableHelperLib by enabling the logs only if DEBUG_INFO is
enabled.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 28 ++--
1 file changed, 14
Hi Girish,
On 10/03/2023 04:23 pm, Girish Mahadevan wrote:
Hi Sami
Response inline.[GM]
Best Regards
Girish
On 3/9/2023 3:41 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for your feedback.
Please find my response inline marked
; // We have copied 10 chars
> BytesCopied = StrElement->StringLen + 1;
> BytesRemaining -= BytesCopied;
> // Increment SmbiosString of 10 chars, so SmbiosString is pointing
> // to an un-initialized char now and we can continue.
> SmbiosString += BytesCopied;
> "&qu
ng related patch (the
SmbiosStringLibrary).
It works well. (I think I've ack'd that patch).
[SAMI] I will get the SmbiosStringLibrary merged soon.
Regards,
Sami Mujawar
My responses inline [GM].
Best Regards
Girish
On 3/8/2023 1:31 AM, Sami Mujawar wrote:
> *External email:
Hi Girish,
Thank you for your feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/03/2023, 17:41, "Girish Mahadevan" mailto:gmahade...@nvidia.com>> wrote:
Hi Sami
Thanks for v2, I will apply these to my tree and test it out.
One small
Hi Girish,
Apologies for the delay in reply.
Please find my response marked inline as [SAMI].
Regards,
Sami Mujawar
On 28/01/2023 12:09 am, Girish Mahadevan wrote:
Hi Sami
Sorry for the long silence. I've sent you v2 of the patch (only
framework not the Type17) which includes a link
table dispatcher table accordingly.
Signed-off-by: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Cc: Girish Mahadevan
Cc: Jeff Brasen
Cc: Ashish Singhal
Cc: Nick Ramirez
Cc: William Watson
Cc: Abner Chang
Cc: Samer El-Haj-Mahmoud
Cc: Jose Marinho
---
Notes:
v2:
- New patch
would be already dispatched.
A top level dispatch function DispatchSmbiosTables() has been introduced
to schedule the dispatch of Default Ordered and Ordered SMBIOS tables.
Signed-off-by: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Cc: Girish Mahadevan
Cc: Jeff Brasen
Cc: Ashish Singhal
installed
before the parent table is installed.
Signed-off-by: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Cc: Girish Mahadevan
Cc: Jeff Brasen
Cc: Ashish Singhal
Cc: Nick Ramirez
Cc: William Watson
Cc: Abner Chang
Cc: Samer El-Haj-Mahmoud
Cc: Jose Marinho
---
Notes:
v2
dispatched. The ordered SMBIOS
tables can also have a level that allows the dispatcher to sequence
their dispatch.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2406_smbios_dispatcher_v2
Sami Mujawar (4):
DynamicTablesPkg: Define a SMBIOS Structure/Table type
lude it in
the definition of CM_STD_OBJ_SMBIOS_TABLE_INFO.
Acked-by: Abner Chang
Signed-off-by: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Cc: Girish Mahadevan
Cc: Jeff Brasen
Cc: Ashish Singhal
Cc: Nick Ramirez
Cc: William Watson
Cc: Abner Chang
Cc: Samer El-Haj-Mahmoud
Cc: Jo
Hi Gerd,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/02/2023, 14:37, "Gerd Hoffmann" mailto:kra...@redhat.com>> wrote:
SetMem arguments 2+3 are in the wrong order, resulting in
the call having no effect because Length is zero.
F
Hi Sahil,
Thank you for pointing me to the V2 patch at
https://edk2.groups.io/g/devel/message/99391
I will review this soon.
Regards,
Sami Mujawar
From: on behalf of "Sami Mujawar via groups.io"
Reply to: "devel@edk2.groups.io" , Sami Mujawar
Date: Friday, 10 Febru
Hi Sahil,
Thomas is referring to my feedback at
https://edk2.groups.io/g/devel/topic/87497028#84347
Can you check your patch once again to see those issues are fixed, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View
Hi Swatisri,
Thank you for this patch,
I have some suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 25/01/2023 06:40 pm, Name wrote:
From: Swatisri Kantamsetti
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https://developer.arm.com/documentation
401 - 500 of 1365 matches
Mail list logo
