Merged as b9bb27e1ff40..0a4079ad86f5
Thanks.
Regards,
Sami Mujawar
On 24/08/2022 05:35 am, Jeff Brasen wrote:
Expose the UID value to GeneratePciSlots().
This is needed for some cases for example:
https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports
Hi Jeff,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93047): https://edk2.groups.io/g/devel/message/93047
Mute This Topic: https://groups.io/mt/93220941
Merged as 033ba8bb2976..b9bb27e1ff40
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93044): https://edk2.groups.io/g/devel/message/93044
Mute This Topic: https://groups.io/mt/93085812/21656
Group Owner
Hi Jeff,
Thank you for this patch.
There are some minor documentation changes that I will fix before pushing.
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group
Merged as 9ca7ece8b3b1..033ba8bb2976
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93040): https://edk2.groups.io/g/devel/message/93040
Mute This Topic: https://groups.io/mt/92947263/21656
Group Owner
Hi Nhi,
Thank you for the updated patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93038): https://edk2.groups.io/g/devel/message/93038
Mute
Hi Michael,
Thank you for this fix.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/08/2022 04:48 am, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Michael Kubacki
Dropped last patch in this series as discussed at
https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using
guest firmware for Kvmtool.
For this series.
Tested-by: Sami Mujawar
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/08/2022 11:28 pm, Kun Qin wrote:
REF: https
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Leif Lindholm
Cc: Ard
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Leif Lindholm
Cc: Ard
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Ard Biesheuvel
Signed-off
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 05:00 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Hi Nhi,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
In some scenarios, the information of Bios Version, Bios Release
and Embedded Controller Firmware Release are fetched during UEFI
booting
Hi Nhi,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
This patch removes redundant updates of "BoardManufacturerType02"
and "SerialNumberType02".
Signed-off-by: Nhi Pham
---
Arm
Hi Nhi,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
This patch fixes typo from "AssertTagType02"
to "AssetTagType02".
Signed-off-by: Nhi Pham
---
ArmPkg/Include/
Hi Nhi,
These change look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
This adds an API to OemMiscLib for fetching the system UUID according to
the platform.
Signed-off-by: Nhi Pham
---
ArmPkg/Include/Library/OemMiscLib.h
Hi Nhi,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
According to "SMC Calling Convention" specification, section 7.4,
return value of Arm Architecture Calls is stored at first argument of
SM
Hi Nhi,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
From: Minh Nguyen
In some scenarios, the processor version may be updated dynamically
from pre-UEFI firmware during booting. But the processor
Hi Jeff,
Thank you for the updated patch.
These changes look good to me.
I will queue this patch to be merged once the merge window opens.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2022 05:47 pm, Jeff Brasen wrote:
Current code will generate duplicate UID
the final call as he maintains this package.
[SAMI] CreateAmlProcessorContainer is more appropriate. Please change
CreateAmlCluster to CreateAmlProcessorContainer.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92550
Hi Jianyong,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
From: Jianyong Wu
Date: Thursday, 18 August 2022 at 06:22
To: "devel@edk2.groups.io" , Jianyong Wu
, Sami Mujawar
Cc: Ard Biesheuvel , Justin He ,
nd
Subject: RE: [edk2-devel] [PATCH 1/2] CloudH
Hi Kun,
I plan to get this series merged when the merge window opens.
If you agree, I will drop this patch before merging. Please let me know
if that is ok.
Regards,
Sami Mujawar
On 17/08/2022 09:53 am, Pierre Gondois wrote:
On 8/17/22 02:17, Kun Qin wrote:
Hi Pierre,
You are correct
Hi Kun,
Thank you for the updated patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/08/2022 11:28 pm, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space
Hi Rohit,
Apologies for the delay. I will pick this up once the merge window opens.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92512): https://edk2.groups.io/g/devel/message/92512
BLE = TRUE).
Therefore, add PlatformPKProtectionLib library instance
to Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc to fix
the build.
Cc: Ard Biesheuvel
Cc: Thomas Abraham
Signed-off-by: Sami Mujawar
---
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
1 file changed, 1 insertion(+)
Hi Jeff, Pierre,
Please findmy response inline marked [SAMI].
Regards,
Sami Mujawar
On 12/08/2022 02:36 pm, Pierre Gondois wrote:
Hi Jeff,
Please find some inline comments below:
On 8/5/22 17:14, Jeff Brasen via groups.io wrote:
Add APIs needed to build _DSD with different UUIDs
Hi Kun,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 09/08/2022, 00:44, "Kun Qin" wrote:
Hi Sami,
Thank you for taking time testing this change!
I have a question about one comment you have for this specific patch
inline (marke
Hi Kun,
I have just replied to your patch series. I think patches 4 & 5 may need some
adjustment.
Can you look into those, please?
Regards,
Sami Mujawar
On 08/08/2022, 16:34, "Kun Qin" wrote:
Hi DynamicTablePkg maintainers,
Just a gentle ping on thi
Hi Kun,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/08/2022 02:05 pm, Sami Mujawar wrote:
Hi Kun,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https
Hi Kun,
I have just tried testing your patch with Kvmtool guest firmware and
think this patch may need some modifications.
Also, the patch 4/6 may need some adjustment, which I will reply back on
that patch separately.
Regards,
Sami Mujawar
On 08/08/2022 02:22 pm, Sami Mujawar wrote:
Hi
Hi Kun,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
This change added a switch case handling for PCI_SS_CONFIG during SSDT
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space
Hi Kun,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
This change added an extra step to allow check for installed ACPI tables.
For FADT, MADT
Hi Jianyong,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/07/2022 08:21 am, Jianyong Wu wrote:
As Cloud Hypervisor has its own PeiMemLib, change it in dsc file
accordingly.
Signed-off-by: Jianyong Wu
---
ArmVirtPkg
Hi Jianyong,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 29/07/2022 08:21 am, Jianyong Wu wrote:
Memory layout in CLoud Hypervisor for arm is changed and is different
with Qemu, thus we should build its own PeiMemInfoLib.
The main change
Hi Michael,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/08/2022 05:09 am, Michael Kubacki wrote:
For the series: Reviewed-by: Michael Kubacki
The patch formatting seems a little strange:
1. The patches don't have "Cc" lines.
[SAMI] I have not been
Hi Michael,
Please find the link for the pull request with the review tags updated
at https://github.com/tianocore/edk2/pull/3183
Regards,
Sami Mujawar
On 05/08/2022 04:08 pm, Michael Kubacki wrote:
Hi Sami,
I see you created a PR that is marked as draft with these changes:
https
Hi Edward,
Thank you for this patch.
This fix looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/08/2022 10:20 am, Edward Pickup wrote:
Fix using RmrNodeCount uninitliased by initliasing it to zero. Also, add
an additional check for ACPI version. This fixes a crash
Signed-off-by: Sami Mujawar
---
PrmPkg/PrmPkg.ci.yaml | 1 +
PrmPkg/PrmPkg.dsc | 24 +---
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml
index
babaf2214ec86ff04531ae216d957be8d3487387
This patch series adds support to build PRM for AARCH64 using GCC.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1
Jose Marinho (5):
Basetools/GenFw: Allow AARCH64 builds to use the --prm flag
PrmPkg: Enable external visibility on PRM symbols
From: Jose Marinho
Enable GCC compilations to keep external symbols when generating a PRM
module.
Signed-off-by: Jose Marinho
Signed-off-by: Sami Mujawar
---
PrmPkg/Include/Prm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PrmPkg/Include/Prm.h b/PrmPkg/Include/Prm.h
index
symbol.
- Force the linker to maintain the PRM handler funtion's symbol.
Signed-off-by: Jose Marinho
Signed-off-by: Sami Mujawar
---
PrmPkg/Samples/PrmSampleAcpiParameterBufferModule/PrmSampleAcpiParameterBufferModule.inf
| 4
PrmPkg/Samples/PrmSampleContextBufferModule
for EDK2 builds targeting
AARCH64.
Signed-off-by: Jose Marinho
Signed-off-by: Sami Mujawar
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c
b/BaseTools/Source/C/GenFw/Elf64Convert.c
index
by resorting to
the --require-defined linker flag.
Signed-off-by: Jose Marinho
Signed-off-by: Sami Mujawar
---
PrmPkg/Readme.md | 11 +++
1 file changed, 11 insertions(+)
diff --git a/PrmPkg/Readme.md b/PrmPkg/Readme.md
index
4ff8a36123d5f987fdd8b54ebaa87e605fa0b4ea
Hi Ard, Mike,
Sorry, I did not see the your messages before responding.
Please ignore my last message. I will leave the change as is.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91988): https://edk2.groups.io
The definition for ARM_PROCESSOR_TABLE has been removed by
commit c8af26627a4e9a3659255dc147d75596da08248e
as it is a pseudo ACPI table.
This causes the JadePkg builds to fail. Therefore, update
Ampere/JadePkg to reflect this change.
Signed-off-by: Sami Mujawar
---
Platform/Ampere/JadePkg
G2 ACPI table
Can you advise what I should be doing here, please?
Also, please let me know if I should be reverting all the commits in
reverse order till the 'Merge' commit and then reapply all the changes.
Regards,
Sami Mujawar
On 29/07/2022 09:20 pm, Kinney, Michael D wrote:
Hi Sami,
There
Adding Leif and Mike.
On 29/07/2022 08:54 pm, Sami Mujawar wrote:
Hi Ard,
I have accidentally pushed a change to the edk2-platforms repo.
The commit is
2faefb2bbcc8083e1bd28908c0b29b5d18595298 Merge branch
'master' of github.com:/tianocore/edk2-platforms
Appologies for the trouble. Can you
Hi Ard,
I have accidentally pushed a change to the edk2-platforms repo.
The commit is
2faefb2bbcc8083e1bd28908c0b29b5d18595298 Merge branch
'master' of github.com:/tianocore/edk2-platforms
Appologies for the trouble. Can you advise on how this can be fixed, please?
Regards,
Sami Mujawar
Hi Kun,
Thank you for this patch.
This change fixes the build break for Phytium platforms.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/07/2022 09:07 pm, Kun Qin via groups.io wrote:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib
Hi Nishant,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 27/07/2022 02:53 pm, Nishant Sharma wrote:
Hi Sami,
Please find my reply inline
On Thu, Jul 21, 2022 at 12:47 PM, Sami Mujawar wrote:
Hi Nishant,
Please find my response inline marked [SAMI].
Regards
, requesting review for the edk2-platform patches from the respective
maintainers for the following modules:
- Silicon/AMD/Styx
- Silicon/Socionext/SynQuacer
- Platform/LeMaker
- Platform/Socionext
- Silicon/NXP & Platform/NXP/*
Regards,
Sami Mujawar
On 19/07/2022, 17:24, "devel@edk2.groups.io
a setup tomorrow to confirm.
Regards,
Sami Mujawar
From: Oliver Steffen
Date: Tuesday, 26 July 2022 at 16:50
To: Sami Mujawar
Cc: "devel@edk2.groups.io" , Rebecca Cran
, "quic_rc...@quicinc.com" , Ard
Biesheuvel , Chasel Chiu ,
Gerd Hoffmann , Leif Lindholm ,
Nate
Hi Oliver,
There is a patch for review at https://edk2.groups.io/g/devel/message/4
which prints the firmware version string. I believe with Ard's comments
addressed that patch can be merged.
Would that patch solve your purpose to print an early message for debug purpose?
Regards,
Sami
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 21/07/2022 05:23 pm, Sami Mujawar via groups.io wrote:
Hi Rebecca, Ard,
On Tue, May 3, 2022 at 12:43 AM, Ard Biesheuvel wrote:
// Data Cache enabled on Primary core when MMU is enabled.
ArmDisableDataCache
Hi Rohit,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/07/2022 06:02 pm, Rohit Mathew wrote:
On platforms that do not have the serial console port pre-initialized
prior to the SEC phase and due to the absence of a call to
"SerialPortIniti
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/07/2022 01:46 pm, Rohit Mathew wrote:
Hi Sami,
Thank you for the review.
Regarding the use of Dynamic Tables Framework, there are no short term
plans to migrate to it. Please find my response for your
Hi Ard,
Thank you for this patch.
I have just checked and that patch v2 1/2 from this series is no longer
required but this patch v2 2/2 is still applicable.
I have applied patch v2 2/2 on latest edk2 master and tested with FVP
model and can boot Linux.
Reviewed-by: Sami Mujawar
Tested
Pushed as 57729d3c3466..2f5e841018d9
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91695): https://edk2.groups.io/g/devel/message/91695
Mute This Topic: https://groups.io/mt/90260402/21656
Group Owner
Hi Pranav,
Apologies for the delay.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/04/2022 07:48 am, Pranav Madhu wrote:
Replace EfiResetSystemLib library with ResetSystemLib library. UEFI
ResetSystem() API is implemented in both these libraries
Hi Zhiguan,
The ArmPkg/Library/* changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/07/2022 08:57 am, Zhiguang Liu wrote:
Hide the Exception implementation details in CpuExcetionHandlerLib and
caller only need to provide buffer
Cc: Eric Dong
Cc: Ray Ni
Cc
);
> +
I missed this in my previous feedback, but ProcessLibraryConstructorList()
should only be called by the Primary core.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91644): https://edk2.groups.io/g/devel/messag
l port.
So, maybe these patches need adjustment so that we avoid calling
SerialPortInitialize () twice.
[/SAMI]
regards,
Sami Mujawar
>
>
>
>> + __TIME__,
>> + __DATE__
>> + );
>> + SerialPortWrite ((UINT8 *)Buffer, CharCount);
>
>
-=-=-=-=-=-=-=
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/07/2022 02:42 pm, Rohit Mathew wrote:
Invoke the constructor in the SEC phase to call into initialization
functions associated with libraries linked with this particular module.
For instance, PrePeiCore's
Hi Rohit,
Have you considered moving to use Dynamic Tables Framework? There is
just too much repetition in this series which can be easily avoided. It
will also make the code more maintainable.
Apart from this I have a comment marked inline as [SAMI].
Regards,
Sami Mujawar
On 04/07/2022
Hi Rohit,
These changes are fine, just too repetitive.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/07/2022 05:59 pm, Rohit Mathew wrote:
Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of
consoles") assigns different address for the console UART and the
Hi Nishant,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 17/06/2022 07:07 am, Nishant Sharma wrote:
Isolated CPUs are those that are not to be used on the platform for
various reasons. The isolated CPU list is an array of MPID values of
[SAMI] Can you explain
Hi Kun,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI], otherwise this
patch looks good to me.
With that updated.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
This change added more token fixers for other node types, including
Hi Kun,
Thank you for this fix.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The content of token should be derived from the data section of the
`CmObject
Hi Kun,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib
Merged as f0064ac3afa2..19a87683654a
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91567): https://edk2.groups.io/g/devel/message/91567
Mute This Topic: https://groups.io/mt/92260869/21656
Group Owner
& Platform/NXP/*
Regards,
Sami Mujawar
On 14/07/2022 05:55 pm, Sami Mujawar wrote:
This v4 series includes 5 additional patches (13-17) that
fix various build breaks caused by changes in edk2 repo.
The patches 1-12 have not changed between v3 series, except
updates to the r-b received.
Th
, these changes look good to me.
I will make the changes locally before pushing.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91538): https://edk2.groups.io/g/devel/message/91538
Mute
Hi Jeff,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91537): https://edk2.groups.io/g/devel/message/91537
Mute This Topic
Hi Jeff,
Thank you for this fix.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91536): https://edk2.groups.io/g/devel/message/91536
Mute This Topic: https
Hi Guomin,
Thank you for confirming.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/07/2022, 13:24, "Jiang, Guomin" wrote:
Hi Sami,
I am sure that the PcdConOutGopSupport will being removed.
We will keep it in dec file temporarily because some downstre
Pushed as 039bdb4d3e96..fc4a132c0e9d
Regards,
Sami Mujawar
On 27/04/2022 03:49 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Device Tree PCI interrupt flags use the convention described at
linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml
The 3rd cell
Pushed as bc93dea9b98c..31bd1678a1db
Regards,
Sami Mujawar
On 27/04/2022 03:59 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
DEPENDENCY:
This patch set relies on a fix sent at:
https://edk2.groups.io/g/devel/message/89348
The DynamicTablesPkg can now generate the AML description
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 27/04/2022 03:59 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The Dynamic Tables Framework has been updated to add support for
generating an ASL description
Hi Pierre,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 27/04/2022 03:59 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The values printed in the 'DEBUG' are not printed in the right
order. Re-order them.
Signed-off-by: Pierre Gondois
Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
Other than the comment below, these changes looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 27/04/2022 03:59 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The Dynamic Tables
Hi Pierre,
I will make that change locally before pushing.
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91447): https://edk2.groups.io/g/devel
Hi Pierre,
Please find my response inline marked [SAMI]
Regards,
Sami Mujawar
On Wed, Apr 27, 2022 at 07:49 AM, PierreGondois wrote:
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci=
>
> eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcie
Hi Zhichao,
Is it possible to provide your feedback for this patch, please?
Regards,
Sami Mujawar
On 14/07/2022 05:50 pm, Sami Mujawar wrote:
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping
Hi Guomin,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/07/2022 02:50 am, Guomin Jiang wrote:
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ArmPkg.
Signed-off-by: Guomin
Hi Guomin,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/07/2022 02:50 am, Guomin Jiang wrote:
From: GuoMinJ
REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Remove All
The DeveloperBox platform firmware build breaks due to the missing
dependency on VariableFlashInfoLib.
Therefore, to satisfy the dependency include VariableFlashInfoLib
in the LibraryClasses section.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
1
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Jeremy Linton
Reviewed-by: Pierre Gondois
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/AMD
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1
.
Signed-off-by: Sami Mujawar
---
Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
| 2 +-
1 file changed, 1
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
The CelloBoard platform firmware build breaks due to the missing
dependency on VariablePolicyHelperLib.
Therefore, to satisfy the dependency include VariablePolicyHelperLib
in the LibraryClasses.common section.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/LeMaker
-off-by: Sami Mujawar
---
Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
-off-by: Sami Mujawar
---
Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
Reviewed-by: Nhi Pham
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
1 file changed, 1 insertion(+), 1
601 - 700 of 1693 matches
Mail list logo
