Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
Other than the comment below, these changes looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 27/04/2022 03:59 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The Dynamic Tables
Hi Pierre,
I will make that change locally before pushing.
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91447): https://edk2.groups.io/g/devel
Hi Pierre,
Please find my response inline marked [SAMI]
Regards,
Sami Mujawar
On Wed, Apr 27, 2022 at 07:49 AM, PierreGondois wrote:
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci=
>
> eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcie
Hi Zhichao,
Is it possible to provide your feedback for this patch, please?
Regards,
Sami Mujawar
On 14/07/2022 05:50 pm, Sami Mujawar wrote:
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping
Hi Guomin,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/07/2022 02:50 am, Guomin Jiang wrote:
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ArmPkg.
Signed-off-by: Guomin
Hi Guomin,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/07/2022 02:50 am, Guomin Jiang wrote:
From: GuoMinJ
REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Remove All
The DeveloperBox platform firmware build breaks due to the missing
dependency on VariableFlashInfoLib.
Therefore, to satisfy the dependency include VariableFlashInfoLib
in the LibraryClasses section.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
1
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Jeremy Linton
Reviewed-by: Pierre Gondois
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/AMD
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1
.
Signed-off-by: Sami Mujawar
---
Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
| 2 +-
1 file changed, 1
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
The CelloBoard platform firmware build breaks due to the missing
dependency on VariablePolicyHelperLib.
Therefore, to satisfy the dependency include VariablePolicyHelperLib
in the LibraryClasses.common section.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/LeMaker
-off-by: Sami Mujawar
---
Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
-off-by: Sami Mujawar
---
Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
Reviewed-by: Nhi Pham
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
1 file changed, 1 insertion(+), 1
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The NXP platform firmware build breaks due to the missing
dependency on VariableFlashInfoLib.
Therefore, to satisfy the dependency include VariableFlashInfoLib
in the LibraryClasses.common section.
Signed-off-by: Sami Mujawar
---
Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
1 file changed, 1
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1
dates"
(https://edk2.groups.io/g/devel/message/91361), which must
be merged in edk2 before this patch series can be integrated.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v4
Sami Mujawar (17):
Platform/ARM: FVP: Update for IOR
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
mory Range node.
- add definition for Memory Range Descriptors.
- add PASID capabilities and flags field to Root Complex node.
Signed-off-by: Sami Mujawar
---
Notes:
v6:
- No code change since v4. Re-sending with v6 series.[SAMI]
v5:
- No code change si
check that the Identifier field is
unique.
- Populate the PASID capabilities and Flags field of the
Root complex node.
- Added checks to not generate IORT Rev E, Rev E..
Signed-off-by: Sami Mujawar
---
Notes:
v6:
- Add check to not generate IORT Rev E, E..
com/samimujawar/edk2/tree/1527_iort_rev_ed_v6
Sami Mujawar (8):
ShellPkg: Acpiview: Abbreviate field names to preserve alignment
DynamicTablesPkg: Handle error when IdMappingToken is NULL
DynamicTablesPkg: IORT set reference to Id array only if present
DynamicTablesPkg: IORT set reference t
v E.b, Rev E.c as
some fields were deprecated in these revisions.
Signed-off-by: Sami Mujawar
---
Notes:
v6:
- Make output format for Flags filed consistent. [PIERRE]
- Define macro for IORT Rev E.c and RMR Node revision 2[PIERRE]
and use these to check for
Mapping count is zero rather than populating it with an incorrect
value.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v6:
- No code change since v1. Re-sending with v6 series.[SAMI]
v5:
- No code change since v1. Re-sending with v5 series.[SAMI
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Add error handling when the IdMappingCount is not zero and the
IdMappingToken is NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v6:
- No changes since v3. Resending with v6 series. [SAMI]
v5:
- No changes since v3. Resending with v5 series. [SAMI
rs so that Git Bisect can work.
Signed-off-by: Sami Mujawar
Reviewed-by: Liming Gao
---
Notes:
v6:
- Add definition for IORT Rev 4 and RMR Node Rev 2. [PIERRE]
- Added definition for IORT Rev 4 and RMR Node 2 so that[SAMI]
appropriate checks can be per
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v6
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91354): https://edk2.groups.io/g/devel/message/91354
Mute This Topic
Hi Nhi,
Looks like the file
Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in
upstream edk2-platforms.
See
https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg
Regards,
Sami Mujawar
On 14/07/2022 08:40 am, Sami Mujawar via groups.io
Hi Pierre,
Thank you for the review.
I have some comments marked inline as [SAMI].
Regards,
Sami Mujawar
On 14/07/2022 09:01 am, Sami Mujawar wrote:
Hi Masahisa,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 14/07/2022 07:38 am, Masahisa Kojima wrote:
Hi Sami
Hi Masahisa,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 14/07/2022 07:38 am, Masahisa Kojima wrote:
Hi Sami,
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
also requires the VariableFlashInfoLib library.
I have checked that the build error is fixed with the
Hi Nhi,
I will do that no problem. However, we really need an edk2-platforms CI
to catch such issues.
Regards,
Sami Mujawar
On 14/07/2022 04:34 am, Nhi Pham wrote:
Hi Sami,
Could you help update for
Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
Thanks,
Nhi
On
Hi Pierre,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 13/07/2022 01:18 pm, Pierre Gondois wrote:
Hi Sami,
@@ -37,9 +37,11 @@ Requirements:
- EArmObjSmmuV1SmmuV2
- EArmObjSmmuV3
- EArmObjPmcg
+ - EArmObjRmr
Hi Pierre,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 13/07/2022 01:10 pm, Pierre Gondois wrote:
Hi Sami,
+
/**
Helper Macro for populating the IORT Node header in the
ACPI_PARSER array.
@@ -108,15 +160,15
Hi Pierre,
Thank you for the feedback.
Please find my response inline marked [SAMI]
On 13/07/2022 01:10 pm, Pierre Gondois wrote:
Hi Sami,
+
/**
Helper Macro for populating the IORT Node header in the
ACPI_PARSER array.
@@ -108,15 +160,15 @@ ValidateItsIdArrayReference (
@param
The CelloBoard platform firmware build breaks due to the missing
dependency on VariablePolicyHelperLib.
Therefore, to satisfy the dependency include VariablePolicyHelperLib
in the LibraryClasses.common section.
Signed-off-by: Sami Mujawar
---
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
1
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Phytium/FT2000-4Pkg
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Ampere/JadePkg
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables
forms/tree/1527_iort_rev_ed_platforms_v3
Sami Mujawar (12):
Platform/ARM: FVP: Update for IORT revision macro renaming
Platform/ARM: Morello: Update for IORT revision macro renaming
Platform/ARM: SGI: Update for IORT revision macro renaming
Silicon/AMD/Styx: Update for IORT revision macr
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
b/Platform
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
Reviewed-by: Jeremy Linton
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
Signed-off-by: Sami Mujawar
---
Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
mory Range node.
- add definition for Memory Range Descriptors.
- add PASID capabilities and flags field to Root Complex node.
Signed-off-by: Sami Mujawar
---
Notes:
v5:
- No code change since v4. Re-sending with v5 series.[SAMI]
v4:
- Update ArmNameSpace
check that the Identifier field is
unique.
- Populate the PASID capabilities and Flags field of the
Root complex node.
Signed-off-by: Sami Mujawar
---
Notes:
v5:
- Change IORT revision macro name to make it similar to [THOMAS]
macro names for other A
rs so that Git Bisect can work.
Signed-off-by: Sami Mujawar
---
Notes:
v5:
- Change IORT revision macro name to make it similar to [THOMAS]
macro names for other ACPI tables.
- Updated IORT revision macros from
an be seen at:
https://github.com/samimujawar/edk2/tree/1527_iort_rev_ed_v5
Sami Mujawar (8):
ShellPkg: Acpiview: Abbreviate field names to preserve alignment
DynamicTablesPkg: Handle error when IdMappingToken is NULL
DynamicTablesPkg: IORT set reference to Id array only if present
DynamicTablesPkg
d.
- add validation to check that the IORT Table Revision is
not 4 as IORT Rev E.c is deprecated.
- add validation to check that the IORT RMR node revision
is not 2 as it breaks backward compatibility and was
deprecated as part of IORT Rev E.c.
Signed-off-by: Sami Mujawar
---
Not
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Mapping count is zero rather than populating it with an incorrect
value.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v5:
- No code change since v1. Re-sending with v5 series.[SAMI]
v4:
- No code change since v1. Re-sending with v4 series.[SAMI
Add error handling when the IdMappingCount is not zero and the
IdMappingToken is NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v5:
- No changes since v3. Resending with v5 series. [SAMI]
v4:
- No changes since v3. Resending with v4 series. [SAMI
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v5
Fixed issues reported by CI and merged as f193b945eac5..5496c763aadd
Thanks,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91139): https://edk2.groups.io/g/devel/message/91139
Mute This Topic: https://groups.io/mt
Hi Jon,
Thank you for your feedback. Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 07/07/2022 07:05 am, Jon Nettleton wrote:
On Wed, Jul 6, 2022 at 11:57 AM Sami Mujawar wrote:
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https
Hi Liming,
Thank you for your feedback. Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 07/07/2022 02:51 am, gaoliming wrote:
Sami:
I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can
be EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has
On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:
>
> -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5
Based on discussion at
https://edk2.groups.io/g/devel/topic/patch_edk2_
. If needed,
I could submit a edk2-platforms patch as required.
Regards,
Sami Mujawar
Reviewed-by:
Regards,
Pierre
On 7/6/22 13:40, Sami Mujawar wrote:
The CM_STD_OBJ_ACPI_TABLE_INFO.AcpiTableRevision can be used to specify
the major revision number of the ACPI table that the generator must
Hi Thomas,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/07/2022 03:18 pm, Thomas Abraham wrote:
On 06/07/2022 11:39, Sami Mujawar wrote:
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been
defaults to the latest supported minor revision.
Since the CM_STD_OBJ_ACPI_TABLE_INFO.MinorRevision field is added to
the end of the structure, it should not break existing platform code.
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/ARM
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
amimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v2
Sami Mujawar (11):
Platform/ARM: FVP: Update for IORT revision macro renaming
Platform/ARM: Morello: Update for IORT revision macro renaming
Platform/ARM: SGI: Update for IORT revision macro renaming
Silicon/AMD/Styx: Update for IOR
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Ampere/JadePkg/Drivers
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
b/Platform/ARM/SgiPkg
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
b
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc
b/Platform
EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
b
check that the Identifier field is
unique.
- Populate the PASID capabilities and Flags field of the
Root complex node.
Signed-off-by: Sami Mujawar
---
Notes:
v4:
- Update IORT generator to support spec revision E.d[SAMI]
- Populate the PASID capabilities and Flag
Add error handling when the IdMappingCount is not zero and the
IdMappingToken is NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v4:
- No changes since v3. Resending with v4 series. [SAMI]
v3:
- New patch in this series. Moves error handling code for [SAMI
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Mapping count is zero rather than populating it with an incorrect
value.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v4:
- No code change since v1. Re-sending with v4 series.[SAMI]
v3:
- No code change since v1. Re-sending with v3 series.[SAMI
d.
- add validation to check that the IORT Table Revision is
not 4 as IORT Rev E.c is deprecated.
- add validation to check that the IORT RMR node revision
is not 2 as it breaks backward compatibility and was
deprecated as part of IORT Rev E.c.
Signed-off-by: Sami Mujawar
---
Not
hanges for the v4 series can be seen at:
https://github.com/samimujawar/edk2/tree/1527_iort_rev_ed_v4
Sami Mujawar (8):
MdePkg: IORT header update for IORT Rev E.d spec
ShellPkg: Acpiview: Abbreviate field names to preserve alignment
ShellPkg: Acpiview: IORT parser update for IORT Re
vilege and attributes for the
memory ranges.
Therefore, update the IORT header file to reflect these changes,
and also rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Notes:
v4:
- Updated patch seri
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v4
mory Range node.
- add definition for Memory Range Descriptors.
- add PASID capabilities and flags field to Root Complex node.
Signed-off-by: Sami Mujawar
---
Notes:
v4:
- Update ArmNameSpaceObjects to support IORT specification[SAMI]
revision E.d.
- Add PASID capabi
Hi Ray,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/06/2022 04:39 am, Ni, Ray via groups.io wrote:
Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx
and updated DxeMain to call InitializeCpuExceptionHandlers
for
Hi Ray,
Thank you for this patch.
I have one minor suggestion marked inline as [SAMI], otherwise this
patch looks good to me.
With that updated.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/06/2022 04:39 am, Ray Ni wrote:
CpuExceptionHandlerLib has been refactored with
Hi Michael,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 17/05/2022, 17:01, "mikub...@linux.microsoft.com"
wrote:
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
Hi Michael,
Thank you for fixing these issues.
I have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks
good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 17/05/2022, 17:01, "mikub...@linux.microsoft.com"
wrote:
From: Michael Kubacki
Hi Min,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89776): https://edk2.groups.io/g/devel/message/89776
Mute This Topic: https://groups.io/mt/91135116
Hi Min,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89775): https://edk2.groups.io/g/devel/message/89775
Mute This Topic: https://groups.io/mt/91135111
Hi Rebecca,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89774): https://edk2.groups.io/g/devel/message/89774
Mute This Topic
Hi Michael,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/04/2022 03:18 am, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib
Hi Michael,
There are other platforms in edk2-platforms that would possibly require
similar changes.
e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc,
Platform\ARM\JunoPkg\ArmJuno.dsc, etc.
Do you plan to submit patches to update these platforms as well?
Regards,
Sami Mujawar
701 - 800 of 1564 matches
Mail list logo
