Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix bug for correct return value checking when get X509Cert

+Srinivasan Mani, +Prarthana Sagar, +Gayathri Thunuguntla -Original Message- From: Li, Yi1 Sent: Sunday, May 19, 2024 6:41 PM To: Sountharya N Cc: Yao, Jiewen ; devel@edk2.groups.io; Li, Yi1 ; Shang, Qingyu Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix bug for

[edk2-devel] [PATCH] CryptoPkg: Check ASN1_get_object() return value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4509 In ASN1_get_object(), Inf should compare with 0x80 instead of 0x00. Cc: Sountharya N Signed-off-by: Sountharya N --- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH] CryptoPkg: Check ASN1_get_object() return value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4509 ASN1_get_object() returns (0x80) in error case and it is compared with (0x00). If ASN1_get_object() returns 0x80 it should returns FALSE, but here it is compared with (0x00) and if it returns 0x80 it is coming out of the condition and

Re: [edk2-devel] [PATCH] CryptoPkg: BaseCryptLib: ASN1_get_object() function return value is not checked properly in CryptX509.c.

you should use logic or instead of and. Before you send V2 patch, please create a PR in EDK2 github to test CI: https://github.com/tianocore/edk2/pulls Regards, Yi -Original Message- From: devel@edk2.groups.io On Behalf Of Sountharya N via groups.io Sent: Tuesday, March 19, 2024 1:

[edk2-devel] [PATCH] PATCH_V2

--- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c index 1182323b63..021cc328f8 100644 ---

Re: [edk2-devel] [PATCH] CryptoPkg: BaseCryptLib: ASN1_get_object() function return value is not checked properly in CryptX509.c.

as errors and returned. So you should use logic or instead of and. Before you send V2 patch, please create a PR in EDK2 github to test CI: https://github.com/tianocore/edk2/pulls Regards, Yi -Original Message- From: devel@edk2.groups.io On Behalf Of Sountharya N via groups.io Sent

[edk2-devel] [PATCH] CryptoPkg: BaseCryptLib: ASN1_get_object() function return value is not checked properly in CryptX509.c.

Added Inf variable, and the error case returned value was checked properly. --- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c

[edk2-devel] RE : when will Edk2 Update CryptoPkg with OpenSSL 3.0

Hi, OpenSSL 1.1.1 series reach End of Life (EOL) on 11th September 2023. For Next Edk2 Release, it is possible to update openssl to 3.0? or When Openssl_3.0 will be updated in edk2. Kindly provide your comments. Thanks, Sountharya From: Sountharya N Sent: Thursday, June 29, 2023 1:00 PM To:

[edk2-devel] RE : when will Edk2 Update CryptoPkg with OpenSSL 3.0

Hi, OpenSSL 1.1.1 series reach End of Life (EOL) on 11th September 2023. For Next Edk2 Release, it is possible to update openssl to 3.0? or When Openssl_3.0 will be updated in edk2. Kindly provide your comments. Thanks, Sountharya -The information contained in this message may be confidential

[edk2-devel] RE : Build Error after adding GLOBAL_REMOVE_IF_UNREFERENCED in CryptoPkg's CryptTs.c file

Hi, We are facing Build error in Old platforms after adding GLOBAL_REMOVE_IF_UNREFERENCED in CryptoPkg's CryptTs.c file in edk202211 tag. GLOBAL_REMOVE_IF_UNREFERENCED macro is defined in MdePkg/Include/Base.h // // The Microsoft* C compiler can removed references to unreferenced data