Re: [edk2-devel] [edk2-platform PATCH] Intel/FitGen: Fixed overflow issue when overlap checking

2022-02-22 Thread Vin Xue
Hi Sir, Could you help to review this simple change? It was verified on Client BIOS. Thanks. From: Vin Xue Sent: Monday, January 24, 2022 5:09 PM To: devel@edk2.groups.io Cc: Bob Feng ; Liming Gao ; Yuwei Chen Subject: [edk2-platform PATCH] Intel/FitGen

[edk2-devel] [edk2-platform PATCH] Intel/FitGen: Fixed overflow issue when overlap checking

2022-01-24 Thread Vin Xue
Chen Signed-off-by: Vin Xue --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c index 290e688f6e..3cb8516757 100644 --- a/Silicon/Intel/Tools/FitGen/FitGen.c +++ b

[edk2-devel] [edk2-platforms PATCH v2 2/4] Silicon/Synopsys/DesignWare: Remove platform specific init code.

2020-08-06 Thread Vin Xue
Remove platform specific init code for device mode enable. The code is different for different silicon vendor. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- .../Drivers/UsbDeviceDxe/UsbDeviceDxe.c | 18 - .../Drivers/UsbDeviceDxe/UsbDeviceDxe.h | 8

[edk2-devel] [edk2-platforms PATCH v2 3/4] Silicon/Synopsys/DesignWare: Support build against DesignWare.dsc

2020-08-06 Thread Vin Xue
Support GCC IA32/X64 build. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- Silicon/Synopsys/DesignWare/DesignWare.dec| 9 +++- Silicon/Synopsys/DesignWare/DesignWare.dsc| 17 --- .../Drivers/UsbDeviceDxe/UsbDeviceDxe.inf | 1 + .../Drivers/UsbDeviceDxe

[edk2-devel] [edk2-platforms PATCH v2 4/4] Silicon/Synopsys/DesignWare: Basic support for USB SuperSpeedPlus

2020-08-06 Thread Vin Xue
Add basic support for USB 3.1 SuperSpeedPlus. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- Silicon/Synopsys/DesignWare/Drivers/UsbDeviceDxe/XdciCommon.h | 3 ++- Silicon/Synopsys/DesignWare/Drivers/UsbDeviceDxe/XdciDWC.c| 3 ++- 2 files changed, 4 insertions(+), 2

Re: [edk2-devel] [edk2-platforms PATCH 1/5] Silicon/Synopsys/DesignWare: Import DesignWare USB3 peripheral driver

2020-08-05 Thread Vin Xue
rt Android Fastboot feature. How about your suggestion about directory name? (Also change driver name?) Best regards, Vin From: Leif Lindholm Sent: Thursday, July 30, 2020 8:18 PM To: Vin Xue Cc: devel@edk2.groups.io ; Michael D Kinney Subject: Re: [edk2-platforms

[edk2-devel] [edk2-platforms PATCH 2/5] Silicon/Synopsys/DesignWare: Replace BSD License with BSD+Patent License

2020-07-17 Thread Vin Xue
Replace BSD 2-Clause License with BSD+Patent License. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- .../DesignWare/Drivers/UsbDeviceDxe/ComponentName.c| 8 +--- .../DesignWare/Drivers/UsbDeviceDxe/UsbDeviceDxe.c | 8 +--- .../DesignWare/Drivers/UsbDeviceDxe

[edk2-devel] [edk2-platforms PATCH 4/5] Silicon/Synopsys/DesignWare: Support build against DesignWare.dsc

2020-07-17 Thread Vin Xue
Support GCC IA32/X64 build. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- Silicon/Synopsys/DesignWare/DesignWare.dec | 9 - Silicon/Synopsys/DesignWare/DesignWare.dsc | 17 +++-- .../Drivers/UsbDeviceDxe/UsbDeviceDxe.inf | 1

[edk2-devel] [edk2-platforms PATCH 5/5] Silicon/Synopsys/DesignWare: Basic support for USB SuperSpeedPlus

2020-07-17 Thread Vin Xue
Add basic support for USB 3.1 SuperSpeedPlus. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- Silicon/Synopsys/DesignWare/Drivers/UsbDeviceDxe/XdciCommon.h | 3 ++- Silicon/Synopsys/DesignWare/Drivers/UsbDeviceDxe/XdciDWC.c| 3 ++- 2 files changed, 4 insertions(+), 2

[edk2-devel] [edk2-platforms PATCH 3/5] Silicon/Synopsys/DesignWare: Remove platform specific init code.

2020-07-17 Thread Vin Xue
Remove platform specific init code for device mode enable. The code is different for different silicon vendor. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Vin Xue --- .../Drivers/UsbDeviceDxe/UsbDeviceDxe.c | 18 - .../Drivers/UsbDeviceDxe/UsbDeviceDxe.h | 8

Re: [edk2-devel] [edk2-platforms][PATCH] Readme.md: Update cross compiling section

2020-07-15 Thread Vin Xue
. From: Leif Lindholm Sent: Wednesday, July 15, 2020 5:26 PM To: Vin Xue Cc: devel@edk2.groups.io ; Michael D Kinney Subject: Re: [edk2-platforms][PATCH] Readme.md: Update cross compiling section On Wed, Jul 15, 2020 at 14:05:03 +0800, Vin Xue wrote: > 1. Upd

[edk2-devel] [edk2-platforms][PATCH] Readme.md: Update cross compiling section

2020-07-15 Thread Vin Xue
1. Update invalid URL link of Linaro GCC toolchains. 2. Add build command example for cross compiling. Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Vin Xue --- Readme.md | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Readme.md b/Readme.md index

[edk2-devel] [PATCH] SignedCapsulePkg: Address NULL pointer dereference case.

2020-07-14 Thread Vin Xue
Original code GetFmpImageDescriptors for OriginalFmpImageInfoBuf pointer, if failed, return a NULL pointer. The OriginalFmpImageInfoBuf should not be NULL and the NULL pointer dereference case should be false positive. Signed-off-by: Vin Xue --- .../SystemFirmwareUpdateDxe.c

[edk2-devel] [PATCH] SignedCapsulePkg: Address NULL pointer dereference case.

2020-07-14 Thread Vin Xue
Original code GetFmpImageDescriptors for OriginalFmpImageInfoBuf pointer, if failed, return a NULL pointer. The OriginalFmpImageInfoBuf should not be NULL and the NULL pointer dereference case should be false positive. Cc: Jiewen Yao Cc: Chao Zhang Signed-off-by: Vin Xue

[edk2-devel] [PATCH] SignedCapsulePkg: Address NULL pointer dereference case.

2020-07-13 Thread Vin Xue
Original code GetFmpImageDescriptors for OriginalFmpImageInfoBuf pointer, if failed, return a NULL pointer. The OriginalFmpImageInfoBuf should not be NULL and the NULL pointer dereference case should be false positive. Signed-off-by: Vin Xue --- .../SystemFirmwareUpdateDxe.c