Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-10-02 Thread Vladimir Olovyannikov via groups.io
> >> Laszlo Ersek > >> Subject: Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible > >> infinite loop in HTTP msg body parser > >> > >> Hi Vladimir, > >> > >> Yes, this must have go past my radar, sorry. Things are becoming more &

Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-10-01 Thread Vladimir Olovyannikov via groups.io
: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite > loop > in HTTP msg body parser > > Hi Vladimir, > > Yes, this must have go past my radar, sorry. Things are becoming more and > more busy out here :/ I will take a look at it by the end of week. > > On 24-S

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-29 Thread Vladimir Olovyannikov via groups.io
Hi Zhichao, Thank you for review. There is another commit waiting for review, which is related to Http, but it is not related to ShellPkg: https://edk2.groups.io/g/devel/message/64765 If one has a server which replies with Content-type: HTML, but does not send the Content-Length field, this con

Re: [edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-09-24 Thread Vladimir Olovyannikov via groups.io
Hi Maciej, Can you please review this patch? It is sitting there for a while, looks like it slipped through the cracks. Thank you, Vladimir > -Original Message- > From: Vladimir Olovyannikov > Sent: Friday, August 28, 2020 11:17 AM > To: devel@edk2.groups.io > Cc: Vladimir Olovyannikov ;

[edk2-devel] [PATCH v13 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-24 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

[edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-24 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [PATCH v12 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-17 Thread Vladimir Olovyannikov via groups.io
e? Were you able to run these tests locally? Is there any step-by-step instruction I can follow? > Thanks, > Zhichao Thank you, Vladimir > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > Vladimir > > Olovyannikov via groups.io >

[edk2-devel] [PATCH v12 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-15 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v12 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-15 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-14 Thread Vladimir Olovyannikov via groups.io
Hi Zhichao, > -Original Message- > From: Gao, Zhichao > Sent: Monday, September 14, 2020 1:19 AM > To: Vladimir Olovyannikov ; Laszlo > Ersek ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > ; Samer El-Haj-Mahmoud mahm...@arm.com> >

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-13 Thread Vladimir Olovyannikov via groups.io
Hi Zhichao, Thank you for reviewing. > -Original Message- > From: Gao, Zhichao > Sent: Sunday, September 13, 2020 5:52 PM > To: Vladimir Olovyannikov ; Laszlo > Ersek ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > ; Samer El-Haj-Mah

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-11 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Friday, September 11, 2020 12:20 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v11 0/1] She

Re: [edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-10 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 9, 2020 11:33 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATC

[edk2-devel] [PATCH v11 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-09 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 9, 2020 3:51 AM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; devel@edk2.groups.io; > Zhichao Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu > ; Siyuan Fu ; Liming Gao > ; Nd > Subject: Re: [PATCH v10 1/1] She

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-08 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Monday, September 7, 2020 2:37 AM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; devel@edk2.groups.io; > Zhichao Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu > ; Siyuan Fu ; Liming Gao > ; Nd > Subject: Re: [PATCH v10 1/1] ShellP

Re: [edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-04 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, Macieji, Thank you for spotting these. Some comments below. > -Original Message- > From: Laszlo Ersek > Sent: Friday, September 4, 2020 8:21 AM > To: Rabeda, Maciej ; Vladimir Olovyannikov > ; devel@edk2.groups.io; Zhichao > Gao ; Ray Ni > Cc: Samer El-Haj-Mahmoud ; Jiaxin Wu

[edk2-devel] [PATCH v10 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-01 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

[edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-01 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [PATCH v9 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-01 Thread Vladimir Olovyannikov via groups.io
or EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c in a later, separate patch. > > Others are OK for me. > > Thanks, > Zhichao Thank you, Vladimir > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of > Vladimir > > Olovyannikov via groups.io

Re: [edk2-devel] [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-31 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Monday, August 31, 2020 2:15 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v9 0

[edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-08-29 Thread Vladimir Olovyannikov via groups.io
When an HTTP server sends a non-chunked body data with no Content-Length header, the HttpParserMessageBody in DxeHttpLib gets confused and never sets the Char pointer beyond the body start. This causes "for" loop to never break because the condition of "Char >= Body + BodyLength" is never satisfied

[edk2-devel] [PATCH v9 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-29 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-29 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-29 Thread Vladimir Olovyannikov via groups.io
ive given the API. > > Thanks > Sean > > > > > > > On 8/28/2020 10:04 AM, Vladimir Olovyannikov via groups.io wrote: > >> -Original Message- > >> From: Rabeda, Maciej > >> Sent: Friday, August 28, 2020 8:27 AM > >> To

[edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-08-28 Thread Vladimir Olovyannikov via groups.io
When an HTTP server sends a non-chunked body data with no Content-Length header, the HttpParserMessageBody in DxeHttpLib gets confused and never sets the Char pointer beyond the body start. This causes "for" loop to never break because the condition of "Char >= Body + BodyLength" is never satisfied

[edk2-devel] [PATCH v8 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-28 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

[edk2-devel] [PATCH v8 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-28 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-28 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Rabeda, Maciej > Sent: Friday, August 28, 2020 8:27 AM > To: Vladimir Olovyannikov > Cc: devel@edk2.groups.io > Subject: Re: Http redirection handling using HttpDxe driver > > Hi Vladimir, > > I got your message, I will look into it next week. > Have a great w

[edk2-devel] Http redirection handling using HttpDxe driver

2020-08-27 Thread Vladimir Olovyannikov via groups.io
Hi Maciej, I would like to get your input (and the HttpDxe driver guys) on the issue I see with Http redirection (using HttpDynamicCommand) Basically, let's say that we connect to a server "server.com" Request: GET / HTTP/1.1 Host: server.com Reply: HTTP/1.1 301 Moved permanently Location: www.s

Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-08-26 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, August 26, 2020 3:03 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io; zhiguang@intel.com > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix > buffer ove

Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-26 Thread Vladimir Olovyannikov via groups.io
: Maciej Rabeda ; Zhichao Gao > ; Jiaxin Wu ; Siyuan Fu > ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/25/20 19:20, Vladimir Olovyannikov via

Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-25 Thread Vladimir Olovyannikov via groups.io
iej Rabeda > >> ; Jiaxin Wu ; > >> Siyuan Fu ; Ray Ni ; Liming > >> Gao ; Nd > >> Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: > add > >> HttpDynamicCommand > >> > >> Hi Vladimir, > >> > >>

[edk2-devel] [PATCH v7 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-25 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-25 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Reviewed-by: Maciej Rabeda Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast im

Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-08-24 Thread Vladimir Olovyannikov via groups.io
BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2783 as you suggested. Thank you, Vladimir > > > > > Thanks, > > Laszlo > > > >> > >>> -Original Message- > >>> From: devel@edk2.groups.io On Behalf Of > >>> Vladimir Olovyann

Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-24 Thread Vladimir Olovyannikov via groups.io
ladimir.olovyanni...@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, >

Re: [edk2-devel] Patch List for 202008 stable tag

2020-08-21 Thread Vladimir Olovyannikov via groups.io
Hi Gao, Can someone please also consider including this one? https://edk2.groups.io/g/devel/message/61938 It was reviewed, but then stuck in limbo for a couple of months. Thank you, Vladimir > -Original Message- > From: Laszlo Ersek > Sent: Friday, August 21, 2020 4:10 AM > To: Vladimi

[edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-21 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v6 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-21 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

Re: [edk2-devel] Patch List for 202008 stable tag

2020-08-20 Thread Vladimir Olovyannikov via groups.io
Hi Gao, > -Original Message- > From: Tom Lendacky > Sent: Thursday, August 20, 2020 5:44 AM > To: Gao, Liming ; Leif Lindholm ; > Laszlo Ersek ; af...@apple.com; Kinney, Michael D > ; Guptha, Soumya K > ; Chang, Abner (HPS SW/FW Technologist) > ; Vladimir Olovyannikov > > Cc: devel@edk2.

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-19 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Rabeda, Maciej > Sent: Wednesday, August 19, 2020 10:44 AM > To: Laszlo Ersek ; Vladimir Olovyannikov > ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-18 Thread Vladimir Olovyannikov via groups.io
Hi Rabeda, Thank you for reviewing. > -Original Message- > From: Rabeda, Maciej > Sent: Tuesday, August 18, 2020 9:54 AM > To: Vladimir Olovyannikov ; Laszlo > Ersek ; Gao, Zhichao ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ;

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-17 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Monday, August 17, 2020 1:44 PM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1] Sh

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-17 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Monday, August 17, 2020 11:01 AM > To: Rabeda, Maciej ; Vladimir Olovyannikov > ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1] S

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-17 Thread Vladimir Olovyannikov via groups.io
Hi Gao, Thanks for reviewing. As you suggest, I will postpone the next patchset submission until NetworkPkg maintainer(s) review. > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 16, 2020 6:48 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Laszlo Ersek ; Sa

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-04 Thread Vladimir Olovyannikov via groups.io
> > Just some quick remarks after a comparison with v3: > > On 07/27/20 18:48, Vladimir Olovyannikov via groups.io wrote: > > Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > > image downloading from http/https servers. > > HTTP download speed is usually

Re: [edk2-devel] [PATCH v5 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-27 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Monday, July 27, 2020 10:40 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [PATCH v5 0/1] ShellPkg/

[edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-27 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v5 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-27 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Samer El-Haj-Mahmoud Cc: Laszlo Ersek Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

Re: [edk2-devel] [PATCH v4 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-27 Thread Vladimir Olovyannikov via groups.io
and > > Hi Vladimir, > > On 07/23/20 22:50, Vladimir Olovyannikov via groups.io wrote: > > Signed-off-by: Vladimir Olovyannikov > > > > Tested-By: Samer El-Haj-Mahmoud > > Tested-By: Laszlo Ersek > > Cc: Zhichao Gao > > Cc: Maciej Rabeda >

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-24 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Friday, July 24, 2020 8:09 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3 1/

[edk2-devel] [PATCH v4 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-23 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

[edk2-devel] [PATCH v4 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-23 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Tested-By: Samer El-Haj-Mahmoud Tested-By: Laszlo Ersek Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloadin

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-23 Thread Vladimir Olovyannikov via groups.io
ao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > > Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > > image downloading from htt

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-23 Thread Vladimir Olovyannikov via groups.io
Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/23/20 16:54, Laszlo Ersek wrote: > > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > >> Introduce an http client

[edk2-devel] [PATCH v2 0/2] Enable HttpDynamicCommand for ArmVirtPkg and OvmfPkg

2020-07-22 Thread Vladimir Olovyannikov via groups.io
Hi, This patchset enables HttpDynamicCommand (Shell command "http") which can be used on ArmVirt and Ovmf platforms. HttpDynamicCommand needs to be available in the tree before this patchset can be applied. The patchset needs to be tested on both platforms. PATCH v2 patchset addresses comments fr

[edk2-devel] [PATCH v2 2/2] OvmfPkg: enable HttpDynamicCommand

2020-07-22 Thread Vladimir Olovyannikov via groups.io
Enable HttpDynamicCommand (Shell command "http") for OvmfPkg platforms. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 Signed-off-by: Vladimir Olovyannikov --- OvmfPkg/OvmfPkgIa32.dsc| 4 OvmfPkg/OvmfPkgIa32.fdf| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 4 OvmfPkg/OvmfPkgIa32

[edk2-devel] [PATCH v2 1/2] ArmVirtPkg: enable HttpDynamiCommand

2020-07-22 Thread Vladimir Olovyannikov via groups.io
Enable HttpDynamicCommand (http Shell command) BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 Signed-off-by: Vladimir Olovyannikov --- ArmVirtPkg/ArmVirt.dsc.inc | 4 ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + ArmVirtPkg/ArmVirtXen.fdf| 1 + 3 files changed,

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand

2020-07-22 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, Thank you for reviewing the patchset. > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, July 22, 2020 12:52 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > > Subject: Re: [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand

[edk2-devel] [PATCH 0/2] Enable HttpDynamicCommand for ArmVirtPkg and OvmfPkg

2020-07-21 Thread Vladimir Olovyannikov via groups.io
Hi, This patchset enables HttpDynamicCommand (Shell command "http") which can be used on ArmVirt and Ovmf platforms. HttpDynamicCommand needs to be available in the tree before this patchset can be applied. The patchset needs to be tested on both platforms. BZ reference: 2857 Thank you, Vladimir

[edk2-devel] [PATCH 1/2] ArmVirtPkg: enable HttpDynamiCommand

2020-07-21 Thread Vladimir Olovyannikov via groups.io
Enable HttpDynamicCommand (http Shell command) Signed-off-by: Vladimir Olovyannikov --- ArmVirtPkg/ArmVirt.dsc.inc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index cf44fc73890b..c7d52175ee37 100644 --- a/ArmVirtPkg/ArmVirt.ds

[edk2-devel] [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand

2020-07-21 Thread Vladimir Olovyannikov via groups.io
Enable HttpDynamicCommand (Shell command "http") for OvmfPkg platforms Signed-off-by: Vladimir Olovyannikov --- OvmfPkg/OvmfPkgIa32.dsc| 6 ++ OvmfPkg/OvmfPkgIa32X64.dsc | 6 ++ OvmfPkg/OvmfPkgX64.dsc | 6 ++ OvmfPkg/OvmfXen.dsc| 6 ++ 4 files changed, 24 insertio

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-16 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 16, 2020 5:20 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-16 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Samer El-Haj-Mahmoud > Sent: Thursday, July 16, 2020 8:26 AM > > Adding to Laszlo's feedback, yes thank you for this feature! I have been > using > this tool on some systems (like the Raspberry Pi) for some time now. It is > *very* useful for some use cases (su

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-15 Thread Vladimir Olovyannikov via groups.io
[PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/15/20 14:55, Laszlo Ersek wrote: > > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > >> Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > >> image downloading f

[edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-13 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-02 Thread Vladimir Olovyannikov via groups.io
tions need adjust: a) GetResponse function body b) "if (!gHttpError) {" section of GetResponse c) " ValueStr = ShellCommandLineGetValue (CheckPackage, L"-s");" the if section below this statement Thanks, Zhichao > -----Original Message- > From: devel@ed

[edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-07-01 Thread Vladimir Olovyannikov via groups.io
If the size of the supplied buffer in FileHandleReadLine(), module UefiFileHandleLib.c, was not 0, but was not enough to fit in the line, the size is increased, and then the Buffer of the new size is zeroed. This size is always larger than the supplied buffer size, causing supplied buffer overrun.

Re: [edk2-devel] [PATCH v1 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-06-30 Thread Vladimir Olovyannikov via groups.io
t; > > -Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Vladimir Olovyannikov via groups.io > > Sent: Friday, June 5, 2020 8:18 AM > > To: devel@edk2.groups.io > > Cc: Vladimir Olovyannikov ; > > Kinney, Michael D ; Gao, Liming >

[edk2-devel] [PATCH v1 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-06-04 Thread Vladimir Olovyannikov via groups.io
If the size of the supplied buffer in FileHandleReadLine(), module UefiFileHandleLib.c, was not 0, but was not enough to fit in the line, the size is increased, and then the Buffer of the new size is zeroed. This size is always larger than the supplied buffer size, causing supplied buffer overrun.

[edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-05-11 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-05-11 Thread Vladimir Olovyannikov via groups.io
Hi Zhichao, Sorry, somehow I overlooked your reply. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, April 15, 2020 11:56 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io; Ni, Ray > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: Re: [edk2-d

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-05-08 Thread Vladimir Olovyannikov via groups.io
> For example, instead of: > > > > > >fs0:\> http http://192.168.1.1:8080 dir1/file1.dat file2.dat > > > > > > > > > > > > Why not: > > > > > > fs0:\> http http://192.168.1.1:8080/dir1/file1.dat file2.dat > > > > > The

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-04-21 Thread Vladimir Olovyannikov via groups.io
parameters > > if "%u_proto%" == "tftp" then > > set -v tftp_blk_param " -s %tftp_blocksize%" > > set -v tftp_win_param " -w %tftp_windowsize%" > > endif > > ... > > # "Universalize" transfer command &

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-04-20 Thread Vladimir Olovyannikov via groups.io
d with no changes for any update protocol (be it tftp, http, etc.). %transfer_cmd%/md5sum.txt %esp_root%\md5sum.txt ... Thanks, Vladimir > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > Vladimir > > Olovyannikov via Groups.

[edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-01-24 Thread Vladimir Olovyannikov via Groups.Io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually x30 times faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This mak

Re: [edk2-devel] [PATCH 1/1] ShellPkg/Application: Support nested variables substitution from cmd line

2020-01-14 Thread Vladimir Olovyannikov via Groups.Io
anni...@broadcom.com; Gao, > > Zhichao > > Subject: RE: [edk2-devel] [PATCH 1/1] ShellPkg/Application: Support > > nested variables substitution from cmd line > > > > Vladimir, > > Is this enhancement an extension to Shell spec or violation of Shell > > spec?

Re: [edk2-devel] [PATCH 1/1] ShellPkg/Application: Support nested variables substitution from cmd line

2020-01-10 Thread Vladimir Olovyannikov via Groups.Io
g. Can you list the unit tests you have done? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Vladimir Olovyannikov via Groups.Io > Sent: Friday, January 10, 2020 6:07 AM > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > Cc: Vladimir Ol

[edk2-devel] [PATCH 1/1] ShellPkg/Application: Support nested variables substitution from cmd line

2020-01-09 Thread Vladimir Olovyannikov via Groups.Io
The current implementation of ShellSubstituteVariables() does not allow substitution of variables names containing another variable name(s) between %...% Example: %text%var_name%% where var_name variable contains 0. Here the variable value which should be returned on substitution would be contents

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Vladimir Olovyannikov via Groups.Io
Sami, I follow your reply style below. > -Original Message- > From: Sami Mujawar > Sent: Thursday, December 12, 2019 10:33 AM > To: Vladimir Olovyannikov ; Ard > Biesheuvel > Cc: devel@edk2.groups.io; nd ; Matteo Carlini > ; Laura Moretta > Subject: RE: Debugging aarch64 edk2 built with

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Vladimir Olovyannikov via Groups.Io
> -Original Message- > From: Sami Mujawar > Sent: Thursday, December 12, 2019 8:07 AM > To: Ard Biesheuvel ; Vladimir Olovyannikov > > Cc: edk2-devel-groups-io ; nd > Subject: RE: Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler > > Hi Vladimir, > > I have built the edk2 fir

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-10 Thread Vladimir Olovyannikov via Groups.Io
> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, December 10, 2019 9:13 AM > To: Vladimir Olovyannikov ; Sami > Mujawar > Cc: edk2-devel-groups-io > Subject: Re: Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler > > On Sat, 7 Dec 2019 at 00:50, Vladimir Olovyannik

[edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-06 Thread Vladimir Olovyannikov via Groups.Io
Hi Ard, We are about to switch to the latest Yocto. It is shipped with gcc-8.3 aarch64-linux-gnu compiler. We use DS5 for bare metal debugging. When I build edk2 with gcc-7-x/gcc-8.x, DS5 complains on DWARF format. I tried to explicitly set it to DWARF2, but still cannot even get the stack or

Re: [edk2-devel] [PATCH v2 093/105] .mailmap: Add an entry for Vladimir Olovyannikov

2019-12-06 Thread Vladimir Olovyannikov via Groups.Io
Reviewed-by: Vladimir Olovyannikov Thanks! > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, December 6, 2019 3:26 AM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Vladimir Olovyannikov > > Subject: [PATCH v2 093/105] .mailmap: Add an entry for Vladimir > O

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

2019-09-09 Thread Vladimir Olovyannikov via Groups.Io
Hi Bob, Steven, Thank you for update. Yes, it fails with “build clean”. Example: . ./edksetup.sh build -a AARCH64 -p BroadcomPlatformPkg/StingrayPkg/StingrayPkg.dsc -t GCC5 -b RELEASE -D PLAT=Stingray -D TARGET=RELEASE -D EDK2_STAMP="dev/bcm958742k 59b754c9f697" cleanall Bob, with your pa

[edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

2019-09-06 Thread Vladimir Olovyannikov via Groups.Io
Hi Steven, The commit 0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 BaseTools: Improve the cache hit in the edk2 build cache Author: Shi, Steven 2019-08-15 07:26:17 Committer: Feng, Bob C 2019-08-19 23:06:05 Parent: 811328172841ce3f7ec1fe7033c130726ad189b7 (ShellPkg/UefiShellDriver1CommandsLib: Mak