Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

2023-02-16 Thread dann frazier
On Fri, Feb 10, 2023 at 5:30 AM Sunil V L wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > Add support for RISC-V qemu virt machine. Most of the changes are migrated > from > edk2-platforms repo and added qemu specific libraries under OvmfPkg. > > The series has passed CI t

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-09 Thread dann frazier
On Thu, Jan 05, 2023 at 05:25:28PM +0100, Ard Biesheuvel wrote: > The early ID map used by ArmVirtQemu uses ASID scoped non-global > mappings, as this allows us to switch to the permanent ID map seamlessly > without the need for explicit TLB maintenance. > > However, this triggers a known erratum

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-05 Thread dann frazier
On Thu, Jan 05, 2023 at 12:46:19PM +0100, Ard Biesheuvel wrote: > On Wed, 4 Jan 2023 at 18:23, Ard Biesheuvel wrote: > > > > The early ID map used by ArmVirtQemu uses ASID scoped non-global > > mappings, as this allows us to switch to the permanent ID map seamlessly > > without the need for explic

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2023-01-03 Thread dann frazier
On Tue, Jan 03, 2023 at 08:39:24PM +0100, Alexander Graf wrote: > Hey Ard, > > On 03.01.23 10:59, Ard Biesheuvel wrote: > > On Thu, 29 Dec 2022 at 19:00, dann frazier > > wrote: > > > On Mon, Nov 28, 2022 at 04:46:10PM +0100, Gerd Hoffmann wrote: > > > >

Re: [edk2-devel] [PATCH v3 12/16] ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot

2023-01-03 Thread dann frazier
On Tue, Jan 03, 2023 at 10:02:27AM +0100, Ard Biesheuvel wrote: > On Thu, 29 Dec 2022 at 22:10, dann frazier wrote: > > > > On Mon, Sep 26, 2022 at 10:25:07AM +0200, Ard Biesheuvel wrote: > > > Now that we have all the pieces in place, switch the AArch64 version of >

Re: [edk2-devel] [PATCH v3 12/16] ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot

2022-12-29 Thread dann frazier
On Mon, Sep 26, 2022 at 10:25:07AM +0200, Ard Biesheuvel wrote: > Now that we have all the pieces in place, switch the AArch64 version of > ArmVirtQemu to a mode where the first thing it does out of reset is > enable a preliminary ID map that covers the NOR flash and sufficient > DRAM to create the

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2022-12-29 Thread dann frazier
On Mon, Nov 28, 2022 at 04:46:10PM +0100, Gerd Hoffmann wrote: > On Mon, Sep 26, 2022 at 10:24:58AM +0200, Ard Biesheuvel wrote: > > When the memory protections were implemented and enabled on ArmVirtQemu > > 5+ years ago, we had to work around the fact that GRUB at the time > > expected EFI_LOADER

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-07 Thread dann frazier
On Wed, Dec 07, 2022 at 11:22:10AM -0500, James Bottomley wrote: > On Wed, 2022-12-07 at 17:04 +0100, Ard Biesheuvel wrote: > > On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann wrote: > > > > > > On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote: > > > > On Wed, 2022-12-07 at 15:09 +0100,

Re: [edk2-devel] feature flag change notifications

2022-12-06 Thread dann frazier
for the types of changes that would require > > that behavior. Your examples are useful as a starting point. > > > > Once concern is how many of those #error/#warn conditions will > > build up over time and then a process to remove them after an > > expiration period

Re: [edk2-devel] feature flag change notifications

2022-12-06 Thread dann frazier
period. > > Mike > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of dann frazier > > Sent: Monday, December 5, 2022 4:10 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] feature flag change notifications > > > >

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-06 Thread dann frazier
On Tue, Dec 06, 2022 at 06:56:49AM +0100, Gerd Hoffmann wrote: > On Mon, Dec 05, 2022 at 04:36:15PM -0700, dann frazier wrote: > > On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote: > > > The email addresses for the reviewers of the MptScsi and > > >

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-05 Thread dann frazier
On Mon, Dec 5, 2022 at 6:25 PM Kinney, Michael D wrote: > > Hi Dann, > > The purpose of this first step was due to lack of > support/maintainers/reviewers. > > If there are issues, then we need to find maintainers/reviewers starting with > those that are using and depend on these features. > > If

[edk2-devel] feature flag change notifications

2022-12-05 Thread dann frazier
Hi, I maintain the edk2 packages in the Debian and Ubuntu distributions. A few times over the years I've had users report regressions that turned out to be due to upstream build flag changes. I wonder if it would be possible for upstream to communicate such changes - either via release notes or,

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-05 Thread dann frazier
On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote: > The email addresses for the reviewers of the MptScsi and > PvScsi are no longer valid. Disable the MptScsi and PvScsi > drivers in all DSC files until new maintainers/reviewers can > be identified. Hi Michael, This seems likel

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-07-01 Thread dann frazier
really even run on a processor that old. > > On Thu, Jun 30, 2022 at 12:25 AM dann frazier > wrote: > > > On Wed, Jun 29, 2022 at 11:06:01PM +0100, Pedro Falcato wrote: > > > This may be a strong opinion but I would consider toolchains that > > > explicitly ch

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
k we want edk2 builds changing if they happen to be built on one of them. -dann Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of dann > frazier > > Sent: Wednesday, June 29, 2022 4:25 PM > > To: Pedro Falcato > > Cc: edk2-dev

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
; switch the -march for the packages, override CFLAGS :) Opinion noted. But is there a downside to edk2 being explicit about its target CPU level on x86-64, given it already does so for IA32 and ARM? -dann > On Wed, Jun 29, 2022 at 10:57 PM dann frazier > wrote: > > > Pin

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
Ping on this. Would it be more palatable if I limited the change only to tested toolchains (gcc/clang)? Alternatively, is there a way to submit this code to CI to verify the !(gcc|clang) variants? -dann On Fri, Jun 10, 2022 at 12:09:18PM -0600, dann frazier wrote: > From: dann fraz

[edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-10 Thread dann frazier
From: dann frazier Some Linux distributions are experimenting with builds that target a higher x86-64 psABI, such as x86-64-v3. To avoid inheriting these compiler defaults in edk2 builds, and therefore breaking compatibility with machines using older CPUs, explicitly target the generic x86-64

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread dann frazier
day, May 17, 2022 8:43 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; dann frazier > > ; Aktas, Erdem ; > > James Bottomley ; Yao, Jiewen ; > > Tom Lendacky > > Subject: [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is > > on or o

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread dann frazier
TDVF uses CcProbe to check the guest type, and TDVF doesn't > support SMM, so this fix has no side-effect. This is confirmed to fix the issue I reported, thanks! Tested-by: dann frazier -dann > Cc: dann frazier > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Y

Re: [edk2-devel] [PATCH V2 5/6] MdePkg: Probe Cc guest in BaseIoLibIntrinsicSev

2022-05-16 Thread dann frazier
On Fri, Apr 15, 2022 at 08:07:08AM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902 > > Bad IO performance in SEC phase is observed after TDX features was > introduced. (after commit b6b2de884864 - "MdePkg: Support mmio for > Tdx guest in BaseIoLibIntrinsic"). > > Th

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/FvbServicesSmm: use the VmgExitLibNull

2022-02-15 Thread dann frazier
EncryptSevLib class > ---> "OvmfPkg/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf" instance > ---> VmgExitLib > ---> "UefiCpuPkg/Library/VmgExitLibNull"instance > > Fixes: ade62c18f4742301bbef474ac10518bde5972fba > Rep

Re: [edk2-devel] Regression found with latest edk2/OVMF SECUREBOOT/SMM build

2022-02-14 Thread dann frazier
[+ Brijesh] On Fri, Feb 11, 2022 at 05:48:38PM -0700, dann frazier wrote: > On Fri, Feb 11, 2022 at 06:31:35PM +, Aaron Young wrote: > > Hello, my apologies if this has already been > > discovered/discussed/addressed, but we are seeing a reproducible exception

Re: [edk2-devel] Regression found with latest edk2/OVMF SECUREBOOT/SMM build

2022-02-11 Thread dann frazier
On Fri, Feb 11, 2022 at 06:31:35PM +, Aaron Young wrote: > Hello, my apologies if this has already been > discovered/discussed/addressed, but we are seeing a reproducible exception > with latest (c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c) OVMF x86_64 build with > SECURE_BOOT/SMM enabled: >

Re: [edk2-devel] How /sys/firmware/fdt getting created

2019-11-01 Thread dann frazier
On Fri, Nov 01, 2019 at 10:17:30AM +0530, Prabhakar Kushwaha wrote: > On Fri, Nov 1, 2019 at 2:04 AM dann frazier > wrote: > > > > On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote: > > > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm > > > wrote:

Re: [edk2-devel] How /sys/firmware/fdt getting created

2019-10-31 Thread dann frazier
On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote: > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm > wrote: > > > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > > > +Leif, comment at bottom > > > > Thanks Laszlo. +Dann, -kexec.

Re: [edk2-devel] How /sys/firmware/fdt getting created

2019-10-31 Thread dann frazier
On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm wrote: > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > > +Leif, comment at bottom > > Thanks Laszlo. +Dann, -kexec. > > > On 10/30/19 09:16, Prabhakar Kushwaha wrote: > > >> So if you want to add these properties, you should add the

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

2019-09-27 Thread dann frazier
utoGenList function > explicitly, where the applying build rule action for > library is triggered. > > Cc: Liming Gao > Cc: dann frazier > Signed-off-by: Bob Feng Thanks Bob! Confirmed fixes my issue. Tested-by: dann frazier -dann > --- > BaseTools/Source/Python/A

Re: [edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-09-24 Thread dann frazier
ushed? AFAICT, yes. I'm just noticing now because I'm working on packaging the latest stable tag for Debian. -dann > Thanks, > Bob > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of dann > frazier > Sent: Tuesday, Septemb

Re: [edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-09-23 Thread dann frazier
On Wed, Aug 07, 2019 at 12:25:32PM +0800, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > Assign the Module AutoGen tasks into multiple > sub process. > > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > .../Source/Python/AutoGen/AutoGenWorker.py| 191