Re: 回复: [edk2-devel] [PATCH] MdePkg DebugLib: Enable FILE NAME as DEBUG ASSERT for GCC12

2024-09-12 Thread joeyli via groups.io
Hi gaoliming, Thanks for your review! I have sent pull request to edk2 github: https://github.com/tianocore/edk2/pull/6193 Joey Lee On Fri, Sep 13, 2024 at 08:57:26AM +0800, gaoliming via groups.io wrote: > Please submit it in Github Edk2 as pull request. I agree this is a good > change. > >

Re: [edk2-devel] [PATCH] MdePkg DebugLib: Enable FILE NAME as DEBUG ASSERT for GCC12

2024-09-11 Thread joeyli via groups.io
Hi all, On Thu, Sep 12, 2024 at 02:52:09PM +0800, Chun-Yi Lee wrote: > Using __FILE_NAME__ is useful for reducing the size of debug image and > it's also good for reproducable builds. The gcc-12 also supported this > macro. > > Ref: > https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1a9b3f04c11eb4

Re: [edk2-devel] How do debug tianocore.PatchCheck failed?

2024-07-02 Thread joeyli via groups.io
Hi Leif, Thanks for your response! On Tue, Jul 02, 2024 at 11:32:06AM +0100, Leif Lindholm wrote: > Hi Joey, > > On 2024-07-02 07:42, joeyli via groups.io wrote: > > Hi EDK2 experts, > > > > I was filed a submit request on github for > > "[PATCH] Embedd

[edk2-devel] How do debug tianocore.PatchCheck failed?

2024-07-01 Thread joeyli via groups.io
Hi EDK2 experts, I was filed a submit request on github for "[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But I got a Azure Pipelines/tianocore.PatchCheck failed: https://github.com/tianocore/edk2/pull/5550/checks?check_run_id=24185647984 Check failure on line

Re: [edk2-devel] [PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH

2024-04-30 Thread joeyli via groups.io
Hi all, On Fri, Apr 12, 2024 at 06:03:35PM +0800, joeyli via groups.io wrote: > Hi experts, > > On Fri, Apr 12, 2024 at 03:25:56PM +0800, Lee, Chun-Yi wrote: > > From: Chun-Yi Lee > > > > RISC-V ovmf used VirtualRealTimeClockLib but the default epoch is a > >

Re: [edk2-devel] [PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH

2024-04-12 Thread joeyli via groups.io
Hi experts, On Fri, Apr 12, 2024 at 03:25:56PM +0800, Lee, Chun-Yi wrote: > From: Chun-Yi Lee > > RISC-V ovmf used VirtualRealTimeClockLib but the default epoch is a > compilation time. It causes that the RISC-V ovmf binary image is NOT > reproducible. > > This patch added the support of SOURCE

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

2024-03-07 Thread joeyli via groups.io
Hi Laszlo, On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: > On 3/4/24 12:37, joeyli via groups.io wrote: > > Hi, > > > > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: > >> On Wed, Feb 07, 2024 at 03:55:49PM +0800,

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

2024-03-04 Thread joeyli via groups.io
Hi, On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: > On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: > > Hi Laszlo, > > > > First, thanks for your review! > > > > On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: &g

Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol

2023-11-15 Thread joeyli via groups.io
Hi Jiaxin, Thanks for your reminder! I have tested Gerd's patch and it works to me! Joey Lee On Wed, Nov 15, 2023 at 11:30:07AM +, Wu, Jiaxin wrote: > Hi Joey, > > Please check your local code whether has the commit > 170d4ce8e90abb1eff03852940a69c9d17f8afe5 from Gerd, > > Assert in 147

Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol

2023-11-14 Thread joeyli via groups.io
Hi Hongbin1, On Mon, May 29, 2023 at 02:39:38PM +0800, Zhang, Hongbin1 via groups.io wrote: > Some features like RAS need to use processor extended information > under smm, So add code to support it > > Signed-off-by: Hongbin1 Zhang I got a ASSERT when booting edk2-stable202308 on a issue machi

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread joeyli via groups.io
Hi Min Xu, On Fri, Apr 07, 2023 at 01:56:05AM +, Min Xu via groups.io wrote: > On Friday, April 7, 2023 4:29 AM, Tom Lendacky wrote: > > On 4/5/23 20:42, Xu, Min M wrote: > > > On April 3, 2023 7:21 PM, Gerd Hoffmann wrote: > > I agree that the efi variable store is not secure without smm

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-07 Thread joeyli via groups.io
On Mon, Apr 03, 2023 at 12:21:38AM +, Xu, Min M wrote: > On Friday, March 31, 2023 10:49 PM, Joeyli wrote: > > On Fri, Mar 31, 2023 at 10:25:09AM +0200, Gerd Hoffmann wrote: > > > On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > > > > Hi Gerd, > > > > > > > > On Thu, Mar 30, 2023 at 09

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-03-31 Thread joeyli via groups.io
On Fri, Mar 31, 2023 at 10:25:09AM +0200, Gerd Hoffmann wrote: > On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > > Hi Gerd, > > > > On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > > > On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > > > > From: Min M Xu > > > >

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-03-31 Thread joeyli via groups.io
Hi Gerd, On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > > From: Min M Xu > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4379 > > > > PlatformInitEmuVariableNvStore is called to initialize the > > EmuVariable

Re: [edk2-devel] [PATCH V5 4/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore

2023-03-21 Thread joeyli via groups.io
Hi Min M Xu, I have filed a EDK2 bug relates to this patch: Bug 4379 - Got NvVarStore FV headers were invalid when using OVMF with AMD SEV https://bugzilla.tianocore.org/show_bug.cgi?id=4379 I got a "NvVarStore FV headers were invalid." assert when using OVMF with AMD SEV. After reverted this

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg/PlatformInitLib: dynamic mmio window size

2023-03-15 Thread joeyli via groups.io
Hi Gerd, I got a page-fault in CpuIo2Dxe.dll when using edk2-stable202211 ovmf with qemu-kvm: X64 Exception Type - 0E(#PF - Page-Fault) CPU Apic ID - ExceptionData - 000B I:0 R:1 U:0 W:1 P:1 PK:0 SS:0 SGX:0 RIP - 7F2CB5E8, CS - 0038, RFLAGS

Re: [edk2-devel] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Better support for dynamic PcdFSBClock

2023-02-09 Thread joeyli via groups.io
On Tue, Nov 08, 2022 at 02:31:48PM +, Anthony PERARD via groups.io wrote: > From: Anthony PERARD > > The PcdFSBClock can be a dynamic PCD. This can be an issue when > InternalX86GetTimerFrequency() tries to get the value while been > called with TPL been set to TPL_HIGH_LEVEL. > > When the P

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-22 Thread joeyli via groups.io
Hi Jiewen, Thanks for your information. I will follow the process. Joey Lee On Wed, Dec 21, 2022 at 08:46:04AM +, Yao, Jiewen wrote: > Hi Joey > You are welcome. Thanks to catch the issue and provide the patch. > > One thing to clarify: The patch submitter is expected to pass CI, *before*

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread joeyli via groups.io
Hi Jiewen, Sorry for I didn't create tiano CI on github in time. And thanks for your help to merge my patch. I will create tiano CI in next time after getting our Review-by tag. Thanks! Joey Lee On Sat, Dec 17, 2022 at 03:17:42AM +, Yao, Jiewen via groups.io wrote: > Thanks for the fix. >

Re: [edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-14 Thread joeyli via groups.io
On Wed, Dec 14, 2022 at 03:12:22PM +0100, Gerd Hoffmann wrote: > > Sorry for I forgot to put my testing environment in patch description. > > My testing is on qemu with OVMF: > > > > - edk2-master or edk2-stable202211 > > build --verbose --debug=1 -D SECURE_BOOT_ENABLE -D TPM_ENABLE -D > > TP

Re: [edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-14 Thread joeyli via groups.io
Hi Jiewen, Thanks for your response! On Wed, Dec 14, 2022 at 06:53:42AM +, Yao, Jiewen via groups.io wrote: > Hey > Good catch! > > I think we need handle below valid cases: > 1. VAR_HEADER_VALID_ONLY (0x7F) <-- Header added (*) > 2. VAR_ADDED (0x3F) <-- Header + data added > 3. VAR_ADDED &

Re: [edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-14 Thread joeyli via groups.io
Hi, On Wed, Dec 14, 2022 at 09:46:36PM +0800, joeyli wrote: > Hi Gerd, > > Thanks for your response! > > On Wed, Dec 14, 2022 at 07:15:28AM +0100, Gerd Hoffmann via groups.io wrote: > > Hi, > > > > > When the variable store has those variables, then system > > > booting/rebooting will > > >

Re: [edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-14 Thread joeyli via groups.io
Hi Gerd, Thanks for your response! On Wed, Dec 14, 2022 at 07:15:28AM +0100, Gerd Hoffmann via groups.io wrote: > Hi, > > > When the variable store has those variables, then system booting/rebooting > > will > > hangs in a ASSERT: > > > > NvVarStore Variable header State was invalid. > > AS

Re: [edk2-devel] [PATCH] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Sev guest

2022-08-26 Thread joeyli via groups.io
Hi Gerd, On Fri, Aug 26, 2022 at 07:27:17AM +0200, Gerd Hoffmann wrote: > Hi, > > > - if (TdIsEnabled ()) { > > + if (TdIsEnabled () || MemEncryptSevIsEnabled()) { > > I think you can just use CcProbeLib and CcProbe() function to cover both > tdx and sev. > Thanks for your review and sugges

Re: [edk2-devel] ovmf miscompiles with gcc-12

2022-05-26 Thread joeyli via groups.io
Hi all, I have filed this issue on tianocore bugzilla: Bug 3934 - ovmf miscompiles with gcc-12 https://bugzilla.tianocore.org/show_bug.cgi?id=3934 Thanks Joey Lee On Thu, May 19, 2022 at 07:43:12AM +0200, Jiri Slaby via groups.io wrote: > Hi, > > we discovered that qemu-ovmf-x86_64 doesn't st

Re: [edk2-devel] How to create a account on bugzilla.tianocore.org ?

2022-05-25 Thread joeyli via groups.io
l@edk2.groups.io On Behalf Of joeyli via > > groups.io > > Sent: Sunday, May 22, 2022 8:23 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] How to create a account on bugzilla.tianocore.org ? > > > > Hi experts, > > > > We want to report bug

[edk2-devel] How to create a account on bugzilla.tianocore.org ?

2022-05-24 Thread joeyli via groups.io
Hi experts, We want to report bug on bugzilla.tianocore.org but the system doesn't provide link for creating new account. How should I do for creating a account on bugzilla.tianocore.org? Thanks! Joey Lee -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. Vi