Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Ard Biesheuvel
On Thu, 15 Feb 2024 at 20:55, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote: > > I looked at the EFI spec again, and EfiACPIReclaimMemory is not > > actually listed as a memory type that has this 64k alignment > > requirement. This makes sense, given that this memory

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Oliver Smith-Denny
On 2/14/2024 11:50 PM, Ard Biesheuvel wrote: I looked at the EFI spec again, and EfiACPIReclaimMemory is not actually listed as a memory type that has this 64k alignment requirement. This makes sense, given that this memory type has no significance to the firmware itself, only to the OS. OTOH,

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Oliver Smith-Denny
On 2/15/2024 9:21 AM, Ard Biesheuvel wrote: Of the two options you presented in this paragraph, I prefer the one where the allocation presented to the caller may not be aligned, but the region plus guards is. But disabling it entirely for these regions is still perfectly fine with me,

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Ard Biesheuvel
On Thu, 15 Feb 2024 at 18:08, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote> On Thu, 15 Feb 2024 at > 01:34, Oliver Smith-Denny > > wrote >> This could also be fixed with > > rearchitecting the heap guard system to > >> respect alignment requirements and shift the