Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-11 Thread Wang, Jian J
Liming, > -Original Message- > From: Gao, Liming > Sent: Wednesday, July 10, 2019 3:44 PM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Leif Lindholm ; Kinney, Michael D > > Subject: RE: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule > policy and

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Wang, Jian J
Mike, > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 1:28 AM > To: Leif Lindholm ; Kinney, Michael D > > Cc: Wang, Jian J ; devel@edk2.groups.io; Gao, > Liming > Subject: RE: [ PATCH v2 1/2] Readme.md: add submodule policy and clone > commands > > > >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Leif Lindholm
On Wed, Jul 10, 2019 at 05:28:27PM +, Kinney, Michael D wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Wednesday, July 10, 2019 10:18 AM > > To: Kinney, Michael D > > Cc: Wang, Jian J ; > > devel@edk2.groups.io; Gao, Liming > >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Michael D Kinney
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, July 10, 2019 10:18 AM > To: Kinney, Michael D > Cc: Wang, Jian J ; > devel@edk2.groups.io; Gao, Liming > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > policy and clone commands >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Leif Lindholm
On Wed, Jul 10, 2019 at 05:08:32PM +, Kinney, Michael D wrote: > Leif, > > I think the following command has to be run from the git > dir that the edk2 repo was cloned into. > > $ git submodule update --init > > So I think the correct instructions would be: > > $ git clone

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Michael D Kinney
Leif, I think the following command has to be run from the git dir that the edk2 repo was cloned into. $ git submodule update --init So I think the correct instructions would be: $ git clone https://github.com/tianocore/edk2.git $ cd edk2 $ git submodule update --init $ cd .. Mike >

Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Liming Gao
Jian: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, July 10, 2019 2:10 PM >To: devel@edk2.groups.io >Cc: Leif Lindholm ; Kinney, Michael D >; Gao, Liming >Subject: [edk2-devel] [ PATC

[edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands

2019-07-10 Thread Wang, Jian J
> v2: update wording per Leif's and others' comments REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 A section 'Submodules' is added to clarify the submodule policy in edk2 repo. Git commands are also added to show the correct way to clone submodule repos, in which '--recursive' is