Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

2022-02-25 Thread Ard Biesheuvel
On Wed, 2 Feb 2022 at 11:04, Sami Mujawar wrote: > > Hi Ard, > > Thank you for this patch. > > The timeout value 5 appears to be standard across platforms, so it looks good > to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > Merged as #2547 (with a mention of the change to 5

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

2022-02-02 Thread Sami Mujawar
Hi Ard, Thank you for this patch. The timeout value 5 appears to be standard across platforms, so it looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreGondois via groups.io" wrote: Hi, The value also

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

2022-02-02 Thread PierreGondois
Hi, The value also gets updated from 3 to 5, is it possible to note it in the commit message or to let it to 3 ? Otherwise the patch looks good to me, Reviewed-by: Pierre Gondois On 2/1/22 7:03 PM, Ard Biesheuvel wrote: Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up t

[edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

2022-02-01 Thread Ard Biesheuvel
Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up to the Timeout EFI variable automatically, which is how the boot manager stores the timeout preference. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(