Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-07-01 Thread dann frazier
Hi Pedro, Yeah, apparently GCC didn't document it until 8.1.0: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=c7cb6c178884 But it appears to have been introduced far earlier - best I can tell, in 4.1: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=3fec9fa9b726 It seems to be unrelated to

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread Pedro Falcato
GCC 5.4 documentation ( https://gcc.gnu.org/onlinedocs/gcc-5.4.0/gcc/x86-Options.html#x86-Options) doesn't include x86-64. I assume that specific option was added somewhere in the last 2-3 years when this x86-64-v* concept was added? I went looking around in linux and they don't seem to specify an

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
el-groups-io ; Feng, Bob C < > bob.c.f...@intel.com>; Gao, Liming ; > > Chen, Christine > > Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add > -march=x86-64 for X64 CLANG and GCC targets > > > > On Wed, Jun 29, 2022 at 11:06:01PM +0100, Pedro Falcato wr

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread Michael D Kinney
istine > Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 > for X64 CLANG and GCC targets > > On Wed, Jun 29, 2022 at 11:06:01PM +0100, Pedro Falcato wrote: > > This may be a strong opinion but I would consider toolchains that > > explicitly chang

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
On Wed, Jun 29, 2022 at 11:06:01PM +0100, Pedro Falcato wrote: > This may be a strong opinion but I would consider toolchains that > explicitly change the default -march from the well understood x86-64 (which > all 64-bit processors support) to be totally broken. If a distro wants to > switch the -

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread Pedro Falcato
This may be a strong opinion but I would consider toolchains that explicitly change the default -march from the well understood x86-64 (which all 64-bit processors support) to be totally broken. If a distro wants to switch the -march for the packages, override CFLAGS :) On Wed, Jun 29, 2022 at 10:

Re: [edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-29 Thread dann frazier
Ping on this. Would it be more palatable if I limited the change only to tested toolchains (gcc/clang)? Alternatively, is there a way to submit this code to CI to verify the !(gcc|clang) variants? -dann On Fri, Jun 10, 2022 at 12:09:18PM -0600, dann frazier wrote: > From: dann frazier > > S

[edk2-devel] [PATCH] BaseTools/tools_def.txt: Add -march=x86-64 for X64 CLANG and GCC targets

2022-06-10 Thread dann frazier
From: dann frazier Some Linux distributions are experimenting with builds that target a higher x86-64 psABI, such as x86-64-v3. To avoid inheriting these compiler defaults in edk2 builds, and therefore breaking compatibility with machines using older CPUs, explicitly target the generic x86-64 psA