Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-14 Thread Steven Shi
Hi Christian, I think about BZ 1895 again, and your suggestion of "change the hash to include the arch" is better. I've sent the v2 patch to enhance it. BTW, the CopyFileOnChange() is still necessary for BZ 1894. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure From: Rodriguez,

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-12 Thread Christian Rodriguez
Hi Steven, This looks good, thank you. Thanks, Christian From: Shi, Steven Sent: Tuesday, June 11, 2019 8:30 PM To: Rodriguez, Christian ; devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: RE: [PATCH] BaseTools: Cannot store library cache of different arch together Sorry, the

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-11 Thread Steven Shi
Sorry, the CopyFileOnChange() will ensure only once IO store/restore writing for each library. The extra IO read is ok. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure From: Shi, Steven Sent: Wednesday, June 12, 2019 11:24 AM To: Rodriguez, Christian ; devel@edk2.groups.io Cc: Gao,

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-11 Thread Steven Shi
Hi Christian, For the extra IO accesses for duplicated library, I plan to introduce the CopyFileOnChange() function to solve it. Below is the CopyFileOnChange() BZ, and I haven't sent its patch yet. The CopyFileOnChange() will ensure only once IO store/restore access for each library. To avoid

[edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-10 Thread Steven Shi
https://bugzilla.tianocore.org/show_bug.cgi?id=1895 Build cache cannot store cache for the same library modules in different arch together. E.g. Both the below IA32 and X64 arch BaseLib caches should exist after build Ovmf3264, but now only the one in X64 arch exist. The reason is the current