Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Lin, Derek (HPS SW)
Hi Phillippe, Yeah, I forgot to fill my example. Thanks for the catch. It is exactly as Bob mentioned, #include MACRO(xxx.h). There are silicon code use macro to separate definitions, and use the approach to reuse code. Like: #define PATH(x) // in platform 1 #define PATH(x) // in platform 2 #

Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Bob Feng
-Daudé Sent: Wednesday, October 16, 2019 7:54 PM To: devel@edk2.groups.io; derek.l...@hpe.com Cc: Feng, Bob C ; Gao, Liming ; Fan, ZhijuX Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include Hi Derek, On 10/16/19 8:17 AM, Lin, Derek (HPS SW) wrote

Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Philippe Mathieu-Daudé
Hi Derek, On 10/16/19 8:17 AM, Lin, Derek (HPS SW) wrote: When c/h file use macro after #include, for example, Apparently you forgot to write your example. In this case, GenMake is not able to create a healthy dependency for the c file. GenMake used to add $(FORCE_REBUILD) dependency in the

[edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-15 Thread Lin, Derek (HPS SW)
When c/h file use macro after #include, for example, In this case, GenMake is not able to create a healthy dependency for the c file. GenMake used to add $(FORCE_REBUILD) dependency in the c file, this guarantee the c file is always compiled in incremental build. But, this function is broken since