Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-15 Thread PierreGondois
Hello Jeshua, On 1/9/24 17:55, Jeshua Smith wrote: Two physical packages are on a multi-chip module and share resources on the module. The module then plugs into the baseboard/motherboard. Is it possible to elaborate on the resource being shared ? In our specific case the problem is related

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-09 Thread Jeshua Smith via groups.io
> > Two physical packages are on a multi-chip module and share resources on > the module. The module then plugs into the baseboard/motherboard. > > Is it possible to elaborate on the resource being shared ? In our specific case the problem is related to the PPTT's "Identical Implementation" flag

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-09 Thread PierreGondois
On 1/9/24 16:47, Jeshua Smith wrote: From: Pierre Gondois Sent: Tuesday, January 9, 2024 1:22 AM On 1/8/24 19:12, Jeshua Smith wrote: The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed.

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-09 Thread Jeshua Smith via groups.io
> From: Pierre Gondois > Sent: Tuesday, January 9, 2024 1:22 AM > On 1/8/24 19:12, Jeshua Smith wrote: > > The code was incorrectly assuming that root nodes had to be physical > > package nodes and vice versa. This is not always true, so the check is > > being removed. > > Does it mean that you

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-09 Thread PierreGondois
Hello Jeshua, On 1/8/24 19:12, Jeshua Smith wrote: The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed. Does it mean that you have a topology where the top-level node is not a physical package

[edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-08 Thread Jeshua Smith via groups.io
The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed. Signed-off-by: Jeshua Smith Tested-by: Ashish Singhal Reviewed-by: Ashish Singhal --- .../SsdtCpuTopologyGenerator.c| 23 ++