Re: [edk2-devel] [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files

2022-02-02 Thread Pedro Falcato
Jake, Sorry for the delay. Pushed as 8f41641a6f29e2ae3ffe2ed44a026db7993ed94f. On Tue, Jan 25, 2022 at 2:13 PM Jake Garver wrote: > This change modularizes the Ext4 DSC/FDF files following the model used > in edk2/NetworkPkg. > > A platform DSC can include Ext4 using "!include Features/Ext4.ds

Re: [edk2-devel] [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files

2022-01-28 Thread Pedro Falcato
Hi, Looks good to me. While I don't 100% understand why one would want this, I know there's a similar pattern in a few packages. All things considered, Reviewed-by: Pedro Falcato I'll wait for a day for any possible comments by other people before merging this. Thanks, Pedro On Tue, Jan 25, 2

[edk2-devel] [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files

2022-01-25 Thread Jake Garver via groups.io
This change modularizes the Ext4 DSC/FDF files following the model used in edk2/NetworkPkg. A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc". Ext.dsc.inc includes all the required information to enable Ext4 features. Similarly, "!include Features/Ext4.fdf.inc" would be used