iu, Chasel ; Zhang, Hongbin1
> ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Add FSP-I API for
> SMM support.
>
> Hi Pedro,
>
> Wow you are totally right... that is crazy! The exact opposite of the way
> 32-bit
> mode works!
>
> Good c
Sent: Monday, July 18, 2022 2:50 PM
To: edk2-devel-groups-io ; Desimone, Nathaniel L
Cc: Chiu, Chasel ; Zhang, Hongbin1
; Zeng, Star
Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Add FSP-I API for
SMM support.
On Mon, Jul 18, 2022 at 10:40 PM Nate DeSimone
Hi Nate,
Those whitespace and indents are for passing Uncrustify check.
I notice Uncrustify was enabled in Edk2 merging check and one of my previous
patch was failed due to spaces/indents were not agreed by Uncrustify, that's
why this time I run the Uncrustify offline before submitting the
On Mon, Jul 18, 2022 at 10:40 PM Nate DeSimone <
nathaniel.l.desim...@intel.com> wrote:
> Hi Chasel,
>
> Please see comments inline. Here is a summary of my feedback:
>
> #1) IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm - line 34 - Bug: eax
> should be rax
> #2)
Hi Chasel,
Please see comments inline. Here is a summary of my feedback:
#1) IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm - line 34 - Bug: eax should
be rax
#2) IntelFsp2Pkg/Include/FspEas/FspApi.h - Various unnecessary whitespace
changes that make the file look worse than before.
#3)
From: Hongbin1 Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Add FSP-I API entry point for SMM support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Signed-off-by: Hongbin1 Zhang
---
IntelFsp2Pkg/FspSecCore/SecFspApiChk.c | 13 +
