From: HoraceX Lien
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4544
These value of Major/Minor version are updated from SMBIOS memory data,
but BCD Revision is updated from PCD PcdSmbiosVersion.
We should also update PCD PcdSmbiosVersion from SMBIOS memory data,
to ensure that get consis
s.io
> Cc: Lien, HoraceX ; Liu, Zhiguang
> ; Bi, Dandan ; Zeng, Star
> ; Gao, Zhichao
> Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not
> match with SMBIOS version
>
> From: HoraceX Lien
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=45
, Zhichao ; Kinney,
Michael D
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is
not match with SMBIOS version
Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion
guaranteed to be in range 0..9?
Mike
> -Original Message-
> From: devel@edk2
, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is
not match with SMBIOS version
Hi Mike,
I have change code to
EntryPointStructureData.SmbiosBcdRevision = ((mPrivateData.Smbios.MajorVersion
& 0x0f)
guang ; Bi, Dandan
> ; Zeng, Star ; Gao, Zhichao
> ; Lien, HoraceX
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision
> is not match with SMBIOS version
>
> Hi Mike,
>
> Could you please reply for me?
> If you want to filter range 0-9, then I w
--
From: Kinney, Michael D
Sent: Friday, September 8, 2023 6:05 AM
To: Lien, HoraceX ; devel@edk2.groups.io; Gao, Liming
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao ; Kinney,
Michael D
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is
not match with
o, Liming
> Cc: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Gao, Zhichao
> ; Lien, HoraceX
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix
> BcdRevision is not match with SMBIOS version
>
> Hi Mike,
>
> Could you please reply for me?
> If you want
Michael D ; devel@edk2.groups.io;
> Gao, Liming
> Cc: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Gao, Zhichao
>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision
> is not match with SMBIOS version
>
> Hi Mike,
>
> No, we didn
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao ; Kinney,
Michael D
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is
not match with SMBIOS version
Forcing to 0 does not sound right.
You did not answer my question about the property of the globa
