Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Zhang, Shenglei
Shenglei ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH] > MinPlatformPkg/SecFspWrapperPlatformSecLib: Change > TopOfTemporaryRam type > > > Thanks for explanations. > So looks like the intentio

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
age- > From: Zhang, Shenglei > Sent: Thursday, September 5, 2019 10:11 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH] > MinPlatformPkg/SecFspWrapperPlatformSecLib: Change > Top

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Zhang, Shenglei
groups.io On Behalf Of Zhang, > > Shenglei > > Sent: Monday, September 2, 2019 8:35 PM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Chiu, Chasel > > ; Desimone, Nathaniel L > > ; Gao, Liming > > Subject: [edk2-devel] [PATCH] > MinPlatfor

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: > Change TopOfTemporaryRam type > > Cast TopOfTemporaryRam's from

[edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-02 Thread Zhang, Shenglei
Cast TopOfTemporaryRam's from UINT32 to UINTN in the expression. The original code (TopOfTemporaryRam - sizeof (UINT32)) may cause overflow. As a result the operation under 64-bit OS environment, (UINT)(...), may cast a overflowed 4-byte result to 8-byte one. Cc: Michael Kubacki Cc: Chasel Chiu