Message-
From: Zhang, Shenglei
Sent: Monday, September 16, 2019 8:36 PM
To: [email protected]; Desimone, Nathaniel L
Cc: Kubacki, Michael A ; Chiu, Chasel
; Gao, Liming
Subject: RE: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check
for pointers
Hi Nathaniel,
> -Origi
Hi Nathaniel,
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Saturday, September 14, 2019 6:31 AM
> To: Zhang, Shenglei ; [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg/T
Hi Shenglei,
Looking at this patch more closely. There appear to be bugs... please
see below. Please fix this along with your poor use of semi-colons and
white-space.
Thanks,
Nate
On 9/12/2019 11:54 AM, Nate DeSimone wrote:
> Your whitespace doesn't quite match the edk2 coding style guideline
Your whitespace doesn't quite match the edk2 coding style guidelines, but we
can fix that during commit.
Reviewed-by: Nate DeSimone
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, September 11, 2019 7:55 PM
To: [email protected]
Cc: Kubacki, Michael A ; Chiu, Chasel
; Des
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
Hi Shenglei,
Please send a second patch series with the copyrights updated.
Thanks,
Nate
-Original Message-
From: Zhang, Shenglei
Sent: Monday, September 2, 2019 5:35 AM
To: [email protected]
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming
Subject: [PAT
Please extend copyright for files you touched, and one more update in below
inline.
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, September 2, 2019 8:35 PM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subj
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
