[edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3904 TdxDxe driver is introduced for Intel TDX feature. Unfortunately, this driver also breaks boot process in SEV-ES guest. The root cause is in the PciLib which is imported by TdxDxe driver. In a SEV-ES guest the AmdSevDxe driver performs a Mem

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Yao, Jiewen
o > Cc: Xu, Min M ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > > Subject: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3904 > > TdxDxe driver is introduced for Intel TD

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Min Xu
On April 19, 2022 10:08 AM, Yao Jiewen wrote: > > If TdxDxe breaks SEV, should we skip the TdxDxe in SEV path? > > I don't understand why we need use Cfg8. > In TdxDxe driver we need to relocate APs and it requires the TdxMailboxLib. The lib chain is that TdxMailbox -> SynchronizationLib -> Ti

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Yao, Jiewen
> To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Brijesh Singh ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > On April 19, 2022 10:08 AM, Yao Jiewen wrote: > > > > If TdxDxe breaks

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Min Xu
On April 19, 2022 10:54 AM, Yao Jiewen wrote: > > Why does TdxDxe call TdxMailbox in an SEV platform? > Or why does TdxMailbox call SynchronizationLib in an SEV platform? > TdxDxe will not call TdxMailbox/SynchronizationLib in SEV platform. The problem is in the lib constructor. When TdxDxe drive

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Yao, Jiewen
y ; Tom > Lendacky > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > On April 19, 2022 10:54 AM, Yao Jiewen wrote: > > > > Why does TdxDxe call TdxMailbox in an SEV platform? > > Or why does TdxMailbox call SynchronizationLib in an SEV

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Min Xu
- > From: Yao, Jiewen > Sent: Tuesday, April 19, 2022 12:16 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Brijesh Singh ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > Do you mean, with SEV

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Yao, Jiewen
Erdem > ; James Bottomley ; Tom > Lendacky > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > In AmdSevDxe's entry point it clears the C-bit from PcdPciExpressBaseAddress > and other memory spaces if needed. Please see > https://github.com/tia

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-18 Thread Yao, Jiewen
; James Bottomley ; Tom > Lendacky > Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver > > Can SEV clear the C-bit in SEC phase? > > I think that is right way to ensure PCI Express can always be accessed by > anyone. > > > > -Orig

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-19 Thread Lendacky, Thomas via groups.io
anyone. -Original Message- From: Xu, Min M Sent: Tuesday, April 19, 2022 12:39 PM To: Yao, Jiewen ; devel@edk2.groups.io Cc: Brijesh Singh ; Aktas, Erdem ; James Bottomley ; Tom Lendacky Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver In AmdSevDxe's entry poi

Re: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver

2022-04-21 Thread Lendacky, Thomas via groups.io
Erdem ; James Bottomley ; Tom Lendacky Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Set PciLib for TdxDxe driver In AmdSevDxe's entry point it clears the C-bit from PcdPciExpressBaseAddress and other memory spaces if needed. Please see https://github.com/tianocore/edk2/blob/master/OvmfPkg