Thank you, Nickle.
-Original Message-
From: Nickle Wang
Sent: Sunday, March 12, 2023 8:05 AM
To: Igor Kulchytskyy ; devel@edk2.groups.io
Cc: Abner Chang ; Nick Ramirez
Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib:
IPMI implementation
Hi Igor,
Thank you f
Hi Igor,
Thank you for your review. I will incorporate your comments in version 2 patch
files.
Regards,
Nickle
-Original Message-
From: Igor Kulchytskyy
Sent: Saturday, March 11, 2023 2:49 AM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Abner Chang ; Nick Ramirez
Subject: RE: [EXTERNAL
Hi Nickle,
See my comments below the text.
Thank you,
Igor
-Original Message-
From: Nickle Wang
Sent: Wednesday, March 8, 2023 2:21 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nick
Ramirez
Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI
[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, March 9, 2023 1:49 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
>
> Subject: RE: [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI
> implementation
Hi Abner,
Thanks for your review.
>> + //
>> + // Get bootstrap credential from variable first // Status =
>> + GetBootstrapAccountCredentialsFromVariable (*UserId, *Password); if
>> + (!EFI_ERROR (Status)) {
>> +return EFI_SUCCESS;
>> + }
> I think the process should keep going if th
[AMD Official Use Only - General]
Hi Nickle,
My comments in below,
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 8, 2023 3:21 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH] RedfishPkg/RedfishPlatformCredentialI
This library follows Redfish Host Interface specification and use IPMI
command to get bootstrap account credential(NetFn 2Ch, Command 02h)
from BMC. RedfishHostInterfaceDxe will use this credential for the
following communication between BIOS and BMC.
Signed-off-by: Nickle Wang
Cc: Abner Chang
C
