Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-27 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, February 25, 2024 9:44 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] But thanks for this question. I update commit message and more some more explanations as below, Remove the references of "Redfish" from this driver. As REST JSON C Structure was not designed for Redfish only. Any RESTful applications can register the

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Nickle Wang via groups.io
Thanks for your explanation, Abner. Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Regards, Nickle From: Chang, Abner Sent: Tuesday, February 27, 2024 8:40 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: RE: [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, As from spec viewpoint, REST JSON C Structure was not designed for Redfish only. Which was designed for any RESTful application that uses JSON as the representation of data model. I was proposed having this driver under MdeModulePkg long time ago

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Nickle Wang via groups.io
Hi @abner.ch...@amd.com, RestJsonStructureDxe is a driver in RedfishPkg. May I know why we can not have dependency to RedfishPkg? Do we need to move it to MdeModulePkg for this goal (removing dependency to RedfishPkg)? Regards, Nickle > -Original

[edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-25 Thread Chang, Abner via groups.io
From: Abner Chang BZ #: 4711 - Add mode debug messages. - This driver shouldn't have a dependency on Redfish package and the references of "Redfish" terminology. Remove the references of "Redfish" from this driver. - Fix the missing parameter of DEBUG macros used in this driver.