[AMD Official Use Only - General]
Hi Mike,
The changes for both RedfishPkg and RedfishClinetPkg were merged. Thanks to
your contribution.
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Tuesday, June 27, 2023 8:05 AM
> To: Mike Maslenkin ; devel@edk2.groups.io
> Cc:
[AMD Official Use Only - General]
Thanks Mike. CI is running now, I will push it once it passes CI.
Abner
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, June 30, 2023 5:05 PM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
> Subject: Re:
Sorry, I created a PR for the change to edk2-redfish-client but that
depends on this change to edk2.
I created a new PR to edk2 for this patch:
https://github.com/tianocore/edk2/pull/4592
Thanks,
Mike
On Fri, Jun 30, 2023 at 5:13 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
>
[AMD Official Use Only - General]
Hi Mike,
I see there are CI errors for this PR, could you please check it? Thanks!
Abner
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, June 30, 2023 6:44 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
Sure!
https://github.com/tianocore/edk2-redfish-client/pull/43
Thanks,
Mike
On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike, could you please create a PR for this change? Then I can merge it
> once the change passed CI.
>
> Thanks
> Abner
[AMD Official Use Only - General]
Hi Mike, could you please create a PR for this change? Then I can merge it once
the change passed CI.
Thanks
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, June 21, 2023 8:26 AM
> To: Mike Maslenkin ; devel@edk2.groups.io
> Cc:
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, June 21, 2023 5:30 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH] RedfishPkg: Fix
BaseSortLib is the library instance name not the class name.
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
RedfishPkg/RedfishLibs.dsc.inc| 2 +-
2 files
