[edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-16 Thread Qi Zhang
wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Qi Zhang --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/Se

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-16 Thread Yao, Jiewen
Thank you Qi. i recommend we file a bugzilla on the scope of the problem After the scope is agreed, then you can send the patch. For example, I can ask why not remove the sha1supported field at all? I hope the community can reach consensus on the problem statement at first. thank you! Yao,

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-17 Thread Laszlo Ersek
On 03/17/21 05:19, Yao, Jiewen wrote: > Thank you Qi. > > i recommend we file a bugzilla on the scope of the problem I agree. We already have a number of BZs related to the disablement of SHA1 and MD5: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 https://bugzilla.tianocore.org/show_bug.

Re: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-17 Thread Qi Zhang
; Kumar, Rahul1 Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox +1 - Bret From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> on behalf of Laszlo Ersek v

Re: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-18 Thread Yao, Jiewen
J ; Kumar, Rahul1 Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox Submit a new BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3268 for this change. Patch set V2 has been sent out for review. Thanks! Qi Zhang From: Bret Barkelew mailto:bret