Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-11 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Monday, December 2, 2019 8:54 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Augustine, Linson > Subject: [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing > cmd-line > > REF: https://bugzilla.tian

Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-11 Thread Gao, Zhichao
i, Ray ; Augustine, Linson > > Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code > while fail parsing cmd-line > > Hi Zhichao, > > On 12/2/19 12:04 PM, Gao, Zhichao wrote: > >> -Original Message- > >> From: Philippe Mathieu-Dau

Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-02 Thread Augustine, Linson
Reviewed by Linson Augustine Regards, Linson. -Original Message- From: Gao, Zhichao Sent: Monday, December 2, 2019 6:24 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Augustine, Linson Subject: [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line REF: https://bug

Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-02 Thread Philippe Mathieu-Daudé
/ShellProtocol: Return error code while fail parsing cmd-line On 12/2/19 1:53 AM, Gao, Zhichao via Groups.Io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2395 Errors happened in the arguments parsing is not a critical error. And it would miss the error status code in the release version

Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-02 Thread Gao, Zhichao
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, December 2, 2019 6:21 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Ni, Ray ; Augustine, Linson > Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error

Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-02 Thread Philippe Mathieu-Daudé
On 12/2/19 1:53 AM, Gao, Zhichao via Groups.Io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2395 Errors happened in the arguments parsing is not a critical error. And it would miss the error status code in the release version of shell. So replace the ASSERT with returning error sta

[edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing cmd-line

2019-12-01 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2395 Errors happened in the arguments parsing is not a critical error. And it would miss the error status code in the release version of shell. So replace the ASSERT with returning error status code while fail parsing command-line in UpdateArgcAr