On 18/05/2021 19:42, Laszlo Ersek wrote:
On 05/18/21 09:51, Ni, Ray wrote:
Thanks for explaining why you don't think it's a good patch. I thought anytime
changing a code,
I should try to make it better, functional better, looks better.
My only point was that separate concerns should be implem
Hi Ray,
On 05/20/21 06:28, Ni, Ray wrote:
>>
>> My only point was that separate concerns should be implemented in
>> separate patches, or at least (if they are really difficult, or
>> overkill, to isolate) that they should be documented.
>>
>> Please try to think with your reviewers' mindsets in m
>
> My only point was that separate concerns should be implemented in
> separate patches, or at least (if they are really difficult, or
> overkill, to isolate) that they should be documented.
>
> Please try to think with your reviewers' mindsets in mind, when
> preparing a patch (commit message a
On 05/18/21 09:51, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Sunday, May 16, 2021 9:39 AM
>> To: devel@edk2.groups.io; Ni, Ray
>> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48
>> addre
> -Original Message-
> From: Laszlo Ersek
> Sent: Sunday, May 16, 2021 9:39 AM
> To: devel@edk2.groups.io; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48
> address size limitation
>
> On 05/15/21 02:04, Ni, Ray wrote:
>
On 05/15/21 02:04, Ni, Ray wrote:
> Laszlo,
> Do you think that another API is also needed: GetPhysicalAddressWidth() that
> returns number 36/52?
No. The GetPhysicalAddressBits() function that I proposed already returns this
information. It has three outputs: the number of bits (that is, the wi
Laszlo,
Do you think that another API is also needed: GetPhysicalAddressWidth() that
returns number 36/52?
physical address width is needed by (besides those that rely on the width for
mask calculation):
UefiCpuPkg\CpuMpPei\CpuPaging.c
UefiCpuPkg\PiSmmCpuDxeSmm\X64\PageTbl.c
MdeModulePkg\Co
On 05/12/21 06:53, Ni, Ray wrote:
> 5-level paging can be enabled on CPU which supports up to 52 physical
> address size. But when the feature was enabled, the 48 address size
> limit was not removed and the 5-level paging testing didn't access
> address >= 2^48. So the issue wasn't detected until
Reviewed-by: Eric Dong
-Original Message-
From: Ni, Ray
Sent: Wednesday, May 12, 2021 12:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek ; Kumar,
Rahul1
Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation
5-level paging can be enabled on CPU
5-level paging can be enabled on CPU which supports up to 52 physical
address size. But when the feature was enabled, the 48 address size
limit was not removed and the 5-level paging testing didn't access
address >= 2^48. So the issue wasn't detected until recently an
address >= 2^48 is accessed.
10 matches
Mail list logo
