ai, Luke
> ; Li, Kevin Y ;
> leif.lindh...@linaro.org; af...@apple.com; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> Done. And, push @30781febe2106cc0d7186e70136120353cd67df2
>
> Thanks
>
Chan, Amy ; Chaganty,
> Rangasai V ; Lai, Luke
> ; Li, Kevin Y ;
> leif.lindh...@linaro.org; af...@apple.com; Kinney, Michael D
> ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> Remember to add en
Cc: Ni, Ray ; Zeng, Star ; Chan, Amy
> ; Chaganty, Rangasai V
> ; Lai, Luke ; Li, Kevin Y
> ; leif.lindh...@linaro.org; af...@apple.com; Kinney,
> Michael D
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> Donal
Cc: Ni, Ray ; Zeng, Star ; Chan, Amy
> ; Chaganty, Rangasai V
> ; Lai, Luke ; Li, Kevin Y
> ; leif.lindh...@linaro.org;
> af...@apple.com; Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> Hi
Rangasai V
> >; Lai, Luke ; Li,
> >Kevin Y ; leif.lindh...@linaro.org;
> >af...@apple.com; Kinney, Michael D
> >Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library
> >by using CPUID(0x15) TSC leaf
> >
> >Thanks Laszlo help to review
ust 17, 2019 4:40 AM
>> To: Gao, Liming ; Kuo, Donald
>> ; Dong, Eric ;
>> devel@edk2.groups.io
>> Cc: Ni, Ray ; Zeng, Star ; Chan,
>> Amy ; Chaganty, Rangasai V
>> ; Lai, Luke ; Li, Kevin
>> Y ; leif.lindh...@linaro.org; af...@apple.com;
>Kinney,
&g
; Chan,
> Amy ; Chaganty, Rangasai V
> ; Lai, Luke ; Li, Kevin
> Y ; leif.lindh...@linaro.org; af...@apple.com; Kinney,
> Michael D
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> On 08/16/19 18:16, Laszlo Ersek
On 08/16/19 18:16, Laszlo Ersek wrote:
> On 08/15/19 06:02, Gao, Liming wrote:
>> Donald: This change is a new feature. Now, it is not in edk2 feature
>> planning list. If you want to catch it into 201908 stable tag, please
>> get approve from Stewards first. I have cc this mail to all Stewards.
>
On 08/15/19 06:02, Gao, Liming wrote:
> Donald: This change is a new feature. Now, it is not in edk2 feature
> planning list. If you want to catch it into 201908 stable tag, please
> get approve from Stewards first. I have cc this mail to all Stewards.
- I don't mind adding a new feature, as long
evel@edk2.groups.io <mailto:devel@edk2.groups.io>] On Behalf Of
> Vitaly Cheptsov via Groups.Io
> Sent: Thursday, August 15, 2019 5:10 AM
> To: Kuo, Donald mailto:donald....@intel.com>>
> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> Subject: Re: [edk2-devel] [
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using
CPUID(0x15) TSC leaf
Hi Donald,
Glad to hear it helped a little, and sorry for some outdated quotes.
Your clarification regarding model range is very helpful. Xeon W being client
and thus having client clock mak
Reviewed-by: Eric Dong
> -Original Message-
> From: Kuo, Donald
> Sent: Thursday, August 15, 2019 5:11 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
> ; Chan, Amy ; Chaganty,
> Rangasai V
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using
[mailto:devel@edk2.groups.io] On Behalf Of Vitaly
Cheptsov via Groups.Io
Sent: Thursday, August 15, 2019 5:10 AM
To: Kuo, Donald
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using
CPUID(0x15) TSC leaf
Hi Donald,
Glad to hear it helped a little
ted should still use AcpiTimerLib (default)
>
> Thanks,
> Donald
> <>
> <>From: vit9696 via [] [mailto:vit9696=protonmail.com
> <http://protonmail.com/>@[]]
> Sent: Thursday, August 15, 2019 3:20 PM
> To: Kuo, Donald mailto:donald....@intel.com>>;
> de
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35 +++
: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using
CPUID(0x15) TSC leaf
Hello,
Thank you for the patch! I reviewed the code and noticed select issues
explained below.
1. The following construction:
if (RegEbx == 0) {
DEBUG ((DEBUG_ERROR, "The CPU is not capble for Core Cr
Hello,
Thank you for the patch! I reviewed the code and noticed select issues
explained below.
1. The following construction:
if (RegEbx == 0) {
DEBUG ((DEBUG_ERROR, "The CPU is not capble for Core Crystal Clock Frequency
!!\n"));
ASSERT (RegEbx != 0);
}
Does not look good to me, and in my
Chaganty, Rangasai V
> ; Lai, Luke ; Li, Kevin
> Y ; Laszlo Ersek (ler...@redhat.com)
> ; leif.lindh...@linaro.org; af...@apple.com; Kinney,
> Michael D
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35 +++
Lai, Luke ; Li, Kevin Y
>
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> using CPUID(0x15) TSC leaf
>
> Hi Liming,
>
> As we plan to add new TimerLib to use CPUID Leaf 0x15 (CPU XTAL clock
> frequency) to calculate TSC to resolve performa
dk2.groups.io
> > Cc: Ni, Ray ; Zeng, Star ;
> > Dong, Eric ; Chan, Amy ;
> > Chaganty, Rangasai V
> > Subject: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by
> > using
> > CPUID(0x15) TSC leaf
> >
> > REF: https://bugzilla.tianocore.org
t; Rangasai V
> Subject: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using
> CPUID(0x15) TSC leaf
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
>
> Cc: Ray Ni
> Cc: Star Zeng
> Cc: Eric Dong
> Cc: Amy Chan
> Cc: Rangasai V Chag
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35 +++
Hi Donald,
Thanks for your explanation. In this case, Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Kuo, Donald
> Sent: Tuesday, August 13, 2019 11:26 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Chan,
> Amy ; Chaganty, Rangasai V
>
>
Hi Eric,
The CPUID Leaf 0x1:EDX.TSC[bit 4] is to check capability for
IA32_TIME_STAMP_COUNTER MSR and RDTSC instruction which defined in IA32 SDM
chapter 17.17
And what we implement is based on IA32 SDM Chapter 18.7 for CPU core XTAL clock
frequency which is from CPUID Leaf 0x15 and new TSC
Hi Donald,
Do you think it's necessary to check the TIME_STAMP_COUNTER capability before
using it? I see SDM has CPUID(0x01) which return the capability of
TIME_STAMP_COUNTER.
Thanks,
Eric
> -Original Message-
> From: Kuo, Donald
> Sent: Monday, August 12, 2019 7:23 PM
> To:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Donald Kuo
---
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++
.../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf
Some comments below.
> -Original Message-
> From: Kuo, Donald
> Sent: Monday, August 12, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
>
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15)
> TSC leaf
>
> REF:
33 matches
Mail list logo
