Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-24 Thread Guo Dong
How about update SmbiosDxe to detect if SMBIOS table is installed in Configuration Table in its entry point? If it is not installed, no change to current behavior (install SmbiosProtocol on an empty SMBIOS table). If it is installed, install SmbiosProtocol with the SMBIOS table from Configurati

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-21 Thread Ma, Maurice
Hi, Patrick, Since BlSupportDxe does some very basic initialization for UEFI payload (EX: Initialize PcdPciExpressBaseAddress dynamic PCD), and it needs to be done in very early phase. So it is desired not to push the dispatching order by adding more dependencies. Otherwise, drivers dispatch

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-21 Thread Patrick Rudolph
Hi Maurice, I'll adapt the function names to match EDK2 naming conventions. The SmbiosDxe is already part of UefiPayloadPkg, so it's not optional (right now). I don't see how registering gEfiSmbiosProtocolGuid could fail. If you think Depex must be true, there should be a) a comment stating the re

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-20 Thread Ma, Maurice
Hi, Patrick In this patch I noticed that we changed the BlSupportDxe dependency from True to gEfiSmbiosProtocolGuid. Since BlSupportDxe is considered as critical for UEFI payload, and on the other side SMBIOS driver could be optional in some case, do you think it is better to handle it throug

[edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-20 Thread Patrick Rudolph
The default EfiSmbiosProtocol operates on an empty SMBIOS table. As the SMBIOS tables are provided by the bootloader, install the SMBIOS tables using the EfiSmbiosProtocol. This fixes the settings menu not showing any hardware information, instead only "0 MB RAM" was displayed. Tests showed that