Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption

2021-08-10 Thread Guo Dong
Thanks to capture and fix this issue. Reviewed-by: Guo Dong -Original Message- From: Marvin Häuser Sent: Sunday, August 8, 2021 12:40 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Vitaly Cheptsov Subject: [PATCH] UefiPayloadPkg/UefiPayloadEntry

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption

2021-08-08 Thread Marvin Häuser
On 09/08/2021 06:20, Ni, Ray wrote: It's so lucky that no code calls AllocatePool so the bug didn't cause real issues. (I tried to remove AllocatePool() and build still passed.) Thanks for catching the bug. Reviewed-by: Ray Ni Can you kindly share how you found this issue? Hey Ray, clang-t

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption

2021-08-08 Thread Ni, Ray
It's so lucky that no code calls AllocatePool so the bug didn't cause real issues. (I tried to remove AllocatePool() and build still passed.) Thanks for catching the bug. Reviewed-by: Ray Ni Can you kindly share how you found this issue? Thanks, Ray -Original Message- From: Marvin Häu

[edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption

2021-08-08 Thread Marvin Häuser
UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin