Hi, Patrick,
Thank you, I will take a look on the new patch!
Regards
Maurice
> -Original Message-
> From: Patrick Rudolph
> Sent: Thursday, June 17, 2021 6:21
> To: Ma, Maurice
> Cc: devel@edk2.groups.io; Dong, Guo ; You,
> Benjamin
> Subject: Re: [PATCH] UefiPayloadPkg/UefiPayloadEnt
Hi Maurice,
I've implemented the requested changes. It now also accepts ACPI_NVS
as usable DRAM.
Thanks,
Patrick
On Thu, Jun 17, 2021 at 2:33 AM Ma, Maurice wrote:
>
> Hi, Rudolph,
>
> Thank you for submitting the patch. In general the approach looks good to
> me.
> Here I have several minor
Hi, Rudolph,
Thank you for submitting the patch. In general the approach looks good to me.
Here I have several minor comments on your patch as listed below:
1. For global variable in module, could we add "m" prefix ? EX: Change
"TopOfLowerUsableDram" to "mTopOfLowerUsableDram" ?
2. Ple
Original Message-
> > From: devel@edk2.groups.io On Behalf Of Patrick
> > Rudolph
> > Sent: Tuesday, June 15, 2021 6:23 AM
> > To: devel@edk2.groups.io
> > Cc: Ma, Maurice ; Dong, Guo
> > ; You, Benjamin
> > Subject: [edk2-devel] [PATCH] UefiPayload
devel@edk2.groups.io
> Cc: Ma, Maurice ; Dong, Guo
> ; You, Benjamin
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve
> bootloader memrange parsing
>
> Currently several DXE crash due to invalid memory resource settings.
> coreboot and slimbootloa
Currently several DXE crash due to invalid memory resource settings.
coreboot and slimbootloader provide an e820 compatible memory map,
which doesn't work well with EDK2 as the e820 spec is missing MMIO regions.
In e820 'reserved' could either mean "DRAM used by boot firmware" or "MMIO
in use and n